-
Notifications
You must be signed in to change notification settings - Fork 1.7k
pub test failure on 'banana' #2729
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Added Accepted label. |
Can you update the status file to skip this test until it is fixed. |
This doesn't break the buildbots, and I haven't heard anyone else having problems with it. I will fix it, but unless you're running into this too I'd rather not skip the test. Is that OK? |
I spent an hour thinking my change introduced the regression before I realized it was already broken. The buildbots seem to run the tests differently and hence are not running into it. |
Oh, I'm very sorry. Matt was the first one to bring this to my attention. Until he did that, I thought everything was fine. I'll skip the test. |
Added Fixed label. |
This issue has been moved to dart-lang/pub#36. |
New commits: git log --format="%C(auto) %h %s" 900e796a37fd9f68de9dd183cf4798fe5f055eaa..4ca4767a6c00b2dadecdaee9a4866dae40ef25f2 4ca4767a Added a dart pub outdated --transitive option (#2731) 6b145bd6 Deprecate --server argument to `pub publish` and `pub uploader`. (#2697) 7737023a don't warn if previous prerelease was null safe (#2730) 62f92838 Improve outdated --mode=null-safety (#2724) cc589ec3 Change message for no Latest resolution (#2729) 656803e9 Require sdk constraint (#2718) 8309d877 Added test that dev_dependency does not trigger null-safety warnings when publishing (#2727) 332ea049 Remove warning about mixed mode. (#2723) a98a1f23 Simplify null-safety analysis in `pub outdated --mode=null-safety` (#2721) 5fba2015 Outdated null safety implies prereleases (#2722) fb9ec4af Fixed bug in yaml_edit (#2703) Change-Id: I22a084aee06542e04a272269fb0134f0ac62f779 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/170690 Commit-Queue: Sigurd Meldgaard <[email protected]> Reviewed-by: Michael Thomsen <[email protected]> Reviewed-by: Jonas Jensen <[email protected]>
This issue was originally filed by [email protected]
I'm seeing a pub test failure about banana:
dart$ tools/test.py -mrelease
Test configuration: none_vm_release_ia32
[00:06 | 3% | + 149 | - 0]
FAILED: none-vm release_ia32 pub/pub_tests
Expected: pass
Actual: fail
stderr:
Unhandled exception:
Expect.fail('Output line 1 was: banana
expected: apple')
0. Function: 'Expect._fail@127eafe4' url: 'bootstrap' line:1514 col:5
1. Function: 'Expect.fail' url: 'bootstrap' line:1301 col:10
2. Function: '::_validateOutput@e8053a5' url: 'file:///usr/local/google/home/mattsh/dart-code1/dart/utils/tests/pub/test_pub.dart' line:116 col:18
3. Function: '::function' url: 'file:///usr/local/google/home/mattsh/dart-code1/dart/utils/tests/pub/test_pub.dart' line:60 col:22
4. Function: 'FutureImpl._complete@924b4b8' url: 'bootstrap_impl' line:3086 col:17
5. Function: 'FutureImpl._setValue@924b4b8' url: 'bootstrap_impl' line:3100 col:14
6. Function: 'CompleterImpl.complete' url: 'bootstrap_impl' line:3169 col:26
7. Function: 'FutureImpl.function' url: 'bootstrap_impl' line:3152 col:44
8. Function: 'FutureImpl._complete@924b4b8' url: 'bootstrap_impl' line:3086 col:17
9. Function: 'FutureImpl._setValue@924b4b8' url: 'bootstrap_impl' line:3100 col:14
10. Function: 'CompleterImpl.complete' url: 'bootstrap_impl' line:3169 col:26
11. Function: '::checkComplete' url: 'file:///usr/local/google/home/mattsh/dart-code1/dart/utils/pub/io.dart' line:179 col:23
12. Function: '::function' url: 'file:///usr/local/google/home/mattsh/dart-code1/dart/utils/pub/io.dart' line:193 col:18
13. Function: '[email protected]' url: 'dart:io' line:6849 col:18
14. Function: '[email protected]' url: 'dart:io' line:6855 col:53
15. Function: '_SocketBase@14117cc4._multiplex@14117cc4' url: 'dart:io' line:7301 col:25
16. Function: '[email protected]' url: 'dart:io' line:7414 col:59
17. Function: '_ReceivePortImpl@6be832b._handleMessage@6be832b' url: 'dart:isolate' line:288 col:22
The text was updated successfully, but these errors were encountered: