Update style guide #3160
Comments
|
Added this to the M1 milestone. |
|
I think Bob did this. Added Fixed label. |
|
Yup, thanks! |
|
This issue has been moved to Github as part of a migration. Please use the Issue on Github going forward: https://github.com/dart-lang/dartlang.org/issues |
kevmoo
added
type-enhancement
copybara-service bot
pushed a commit
that referenced
this issue
Oct 8, 2021
Changes: ``` > git log --format="%C(auto) %h %s" 37d0592..0764437 https://dart.googlesource.com/pub.git/+/07644370 Make gitignore validator use gitignores from repo-root and down. (#3169) https://dart.googlesource.com/pub.git/+/205ea58c Handle build-versions when reformatting ranges (#3170) https://dart.googlesource.com/pub.git/+/8f7bfb8c migrate 3 leaf files to null-safety (#3168) https://dart.googlesource.com/pub.git/+/df5db1f1 Extract some parts of pubspec parsing to a null-safe library. (#3160) ``` Diff: https://dart.googlesource.com/pub.git/+/37d05928939b3100e7e55c3dff922651db1de1e1~..0764437088fd58eb7af779ecef66bab40dfcf2e9/ Change-Id: I8d938dbf6c3fba3c3f4d98bbaa5835acfaf132a7 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/216020 Reviewed-by: Sarah Zakarias <[email protected]> Commit-Queue: Sigurd Meldgaard <[email protected]>
copybara-service bot
pushed a commit
that referenced
this issue
Sep 13, 2022
…8 revisions) https://dart.googlesource.com/dartdoc/+log/c64f800bd6a7..b0b0d6ace017 2022-09-13 [email protected] Use toList(growable:false) more (#3151) 2022-09-13 [email protected] Make Warnable.package non-nullable (#3155) 2022-09-13 [email protected] Update scorecard action to v2.0.3 (#3162) 2022-09-13 [email protected] Bump to 6.1.1 (#3161) 2022-09-12 [email protected] Allow analyzer 5.0.0 (#3160) 2022-09-12 [email protected] Make Extension.typeParameters late final (#3150) 2022-09-12 [email protected] Fix HTML of features (#3147) 2022-09-12 [email protected] Improve assert of function typedef (#3158) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dart-doc-dart-sdk Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Dart Documentation Generator: https://github.com/dart-lang/dartdoc/issues To file a bug in Dart SDK: https://github.com/dart-lang/sdk/issues To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Tbr: [email protected] Change-Id: I96e0843c13d07f35e1bab57cacaddd747f54e00b Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/259081 Commit-Queue: DEPS Autoroller <[email protected]> Reviewed-by: Devon Carew <[email protected]> Commit-Queue: Devon Carew <[email protected]>
This issue was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
We've got a bunch of internal notes we've been collecting about Dart usage. We should update the style guide with that.
One issue that has come up is using "double" as a type annotation. Our best practice is that "double" should never be used as an annotation. In all cases you should use "num". But the style guide is silent on this.
The text was updated successfully, but these errors were encountered: