Skip to content

Cherry pick for samples {Image, Categorical, FeatureSelection} #3221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from

Conversation

abgoswam
Copy link
Member

@abgoswam abgoswam commented Apr 5, 2019

This PR cherry picks the following commits from the master branch

#3165
#3179
#3184
#3208

@shauheen @glebuk

abgoswam added 4 commits April 5, 2019 18:05
…3165)

* updating image samples

* fix review comments (print preview)

* fix comments (minor nits)

* fix review comments (whitespaces)
* categorical transform estimators

* review comments

* fix review comments

* modify samples namespace
* samples for FeatureSelection transform estimators

* fix review comments

* fix review comments

* review comments

* take care of review comments

* fix copy paste output error
* fixing namespace for image samples

* fix compile error
@abgoswam abgoswam requested review from shauheen, glebuk, shmoradims and sfilipi and removed request for shmoradims and sfilipi April 5, 2019 18:11
Copy link

@shmoradims shmoradims left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@shauheen shauheen added this to the 0419 milestone Apr 9, 2019
@shauheen
Copy link
Contributor

Done as part of #3333 . Thanks @abgoswam

@shauheen shauheen closed this Apr 14, 2019
@ghost ghost locked as resolved and limited conversation to collaborators Mar 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants