Remove SubComponent #852
Merged
Remove SubComponent #852
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Working towards dotnet#585
And one minor comment change to remove a SubComponent reference.
Zruty0
reviewed
Sep 7, 2018
| using Xunit; | ||
| using Float = System.Single; |
There was a problem hiding this comment.
Float [](start = 6, length = 5)
can we remove this silly thing?
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change completely removes SubComponent from ML.NET product, and moves it to the test code (since it is so heavily used there).
This PR builds on top of #817, so the first commit can be reviewed on that PR.