Update SHAs for coreclr, corefx, core-setup and standard to pick up source-build fixes #313
Conversation
| @@ -4,7 +4,7 @@ | |||
| <PropertyGroup> | |||
| <BuildArguments>-ConfigurationGroup=$(Configuration) -PortableBuild=false -SkipTests=true </BuildArguments> | |||
| <BuildArguments Condition="$(Platform.Contains('arm'))">$(BuildArguments) -TargetArchitecture=$(Platform) -DisableCrossgen=true -CrossBuild=true</BuildArguments> | |||
| <BuildCommand>$(ProjectDirectory)/build$(ShellExtension) $(BuildArguments) -- /p:BuildDebPackage=false</BuildCommand> | |||
| <BuildCommand>$(ProjectDirectory)/build$(ShellExtension) $(BuildArguments) -- /p:BuildDebPackage=false /p:BuildAllPackages=true</BuildCommand> | |||
There was a problem hiding this comment.
Why did we need to pass BuildAllPackages=true? I wouldn't expect that to be necessary.
There was a problem hiding this comment.
The CLI build in source-build failed because of 2 missing depencencies: Microsoft.Extensions.DependencyModel and Microsoft.DotNet.PlatformAbstractions. These are conditionally built based on this property.
There was a problem hiding this comment.
We intentionally don't build these in servicing, similar to corefx, unless we have changes we want to ship. It has been a while since I've thought about this but it feels like we would have a lot more failures higher up based on not building all the packages.
I guess for now this should work. For reference the corefx issue I filed a while back is #210.
…ld/source-build into updateCoreFxCoreSetupSHAs
dseefeld
force-pushed
the
updateCoreFxCoreSetupSHAs
branch
from
0bcf512 to
d774da5
Compare
…ld.Runtime to fix sporadic issue with CI where a broken version of Microsoft.Build.Runtime.15.4.8 was being installed from the msbuild myget feed. Add cli-deps to NuGet.Config for cli update-dependencies. Add ExternalRestoreSource to repo build command for cli.
…ith BuildTest=false
|
We will temporarily disable the ARM CI build. This is ready to merge. |
Source-build specific fixes were made in corefx and core-setup. Move to the release/2.0.0 version of these to pick up the code changes.
fixes #311