-
Notifications
You must be signed in to change notification settings - Fork 136
Update SHAs for coreclr, corefx, core-setup and standard to pick up source-build fixes #313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
dseefeld
merged 9 commits into
dotnet:dev/release/2.0
from
dseefeld:updateCoreFxCoreSetupSHAs
Feb 8, 2018
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
04c602b
Move SHAs forward for core-setup and corefx to get source-build changes
dseefeld 3ee25ef
Update other versions
dseefeld b9d749d
Change core-setup to build with "BuildAllPackages" = true
dseefeld 416d444
Move SHAs forward for core-setup and corefx to get source-build changes
dseefeld a1b7126
Update other versions
dseefeld a1286e0
Change core-setup to build with "BuildAllPackages" = true
dseefeld d774da5
Merge branch 'updateCoreFxCoreSetupSHAs' of https://github.com/dseefe…
dseefeld d20e032
Update cli SHA to more recent SHA to get new version of Microsoft.Bui…
dseefeld c329f8c
Update SHAs for corefx and core-setup to pickup fixes. Build corefx …
dseefeld File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1 @@ | ||
2.0.0-servicing-02221-03 | ||
2.0.0-servicing-02312-03 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Submodule core-setup
updated
23 files
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why did we need to pass BuildAllPackages=true? I wouldn't expect that to be necessary.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The CLI build in source-build failed because of 2 missing depencencies: Microsoft.Extensions.DependencyModel and Microsoft.DotNet.PlatformAbstractions. These are conditionally built based on this property.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We intentionally don't build these in servicing, similar to corefx, unless we have changes we want to ship. It has been a while since I've thought about this but it feels like we would have a lot more failures higher up based on not building all the packages.
I guess for now this should work. For reference the corefx issue I filed a while back is #210.