Skip to content

Check Node version early #5430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gaearon opened this issue Oct 14, 2018 · 17 comments
Open

Check Node version early #5430

gaearon opened this issue Oct 14, 2018 · 17 comments

Comments

@gaearon
Copy link
Contributor

gaearon commented Oct 14, 2018

We need to add better Node version checks. The current one doesn’t cover all requirements (like Node >= 8.9.0).

@vldmrkl
Copy link

vldmrkl commented Oct 15, 2018

@gaearon, are the checks supposed to be changed under engines in package.json files?

Do I understand it correctly? If yes, I'd be happy to contribute.

@zivkaziv
Copy link

Hey guys, is someone working on it? I'll be happy to contribute

@ianschmitz
Copy link
Contributor

@zivkaziv there's #5482 and #5501 already it looks like. Thanks though!

@maximilianotulian
Copy link

Hey guys, this one is available? Regards!

@ianschmitz
Copy link
Contributor

Hey @maximilianotulian yes this is available. You should be able to base your work on #5430. Sorry we lost track of this

@maximilianotulian
Copy link

Thanks @ianschmitz, I will give it a try

@ianschmitz
Copy link
Contributor

Hey @maximilianotulian yes this is available. You should be able to base your work on #5430. Sorry we lost track of this

Sorry i meant #5501 @maximilianotulian

@nsisodiya
Copy link

@gaearon IMO, the pre-install script can check node version and exit if it doesn't find suitable node version.

@dmitrij-borchuk
Copy link

Hey, do I understand correctly the issue? Looks like you are not satisfied with the current version checker (NOT the node version itself)? I took a look into the PRs that was done here and all of them updating the node version. Only this one https://github.com/facebook/create-react-app/pull/5501/files improved version checker, but it was not approved. Could anybody tell me what was wrong with it (apart of yarn.lock in .gitignore)?

@elit-altum
Copy link

elit-altum commented Sep 23, 2020

@ianschmitz Can I try this one? Would love to contribute here!

Seems like there is now a check for v10 for node here. Would you like to have specific warnings for other node versions like 8.9.0 etc. If I understand the issue correctly?

I think #9614 can also be looked at under a PR made for this issue.

@iansu iansu modified the milestones: 4.x, 4.0 Sep 30, 2020
@iansu iansu modified the milestones: 4.0, 4.0.1 Oct 23, 2020
@iansu iansu modified the milestones: 4.0.1, 4.0.2 Nov 23, 2020
@mrmckeb mrmckeb modified the milestones: 4.0.2, 4.0.3 Feb 3, 2021
@iansu iansu modified the milestones: 4.0.3, 4.0.4 Feb 22, 2021
@iansu iansu modified the milestones: 4.1, 4.2 May 26, 2021
@OBACodes
Copy link

Hi there,
Seems like this is still not done. Is it open for grabs?
cheers,

@raix raix modified the milestones: 5.1, 5.x Dec 17, 2021
@tchassijordan
Copy link

Hey @iansu @raix.
Is this issue still up for a grab, I want to take this one up.

@namann11
Copy link

Hey guys, is someone working on it? I'll be happy to contribute

1 similar comment
@shrey-suri
Copy link

Hey guys, is someone working on it? I'll be happy to contribute

@Amit-Morade
Copy link

I would like to work on this

@HarshMankar
Copy link

HarshMankar commented Feb 7, 2024

Hi , is someone working on it? I'll be happy to contribute

@ryuga001
Copy link

Hi , can you assign me this issue ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests