-
-
Notifications
You must be signed in to change notification settings - Fork 27k
Check Node version early #5430
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
@gaearon, are the checks supposed to be changed under engines in package.json files? Do I understand it correctly? If yes, I'd be happy to contribute. |
Hey guys, is someone working on it? I'll be happy to contribute |
Hey guys, this one is available? Regards! |
Hey @maximilianotulian yes this is available. You should be able to base your work on #5430. Sorry we lost track of this |
Thanks @ianschmitz, I will give it a try |
Sorry i meant #5501 @maximilianotulian |
@gaearon IMO, the pre-install script can check node version and exit if it doesn't find suitable node version. |
Hey, do I understand correctly the issue? Looks like you are not satisfied with the current version checker (NOT the node version itself)? I took a look into the PRs that was done here and all of them updating the node version. Only this one https://github.com/facebook/create-react-app/pull/5501/files improved version checker, but it was not approved. Could anybody tell me what was wrong with it (apart of |
@ianschmitz Can I try this one? Would love to contribute here! Seems like there is now a check for I think #9614 can also be looked at under a PR made for this issue. |
Hi there, |
Hey guys, is someone working on it? I'll be happy to contribute |
1 similar comment
Hey guys, is someone working on it? I'll be happy to contribute |
I would like to work on this |
Hi , is someone working on it? I'll be happy to contribute |
Hi , can you assign me this issue ? |
We need to add better Node version checks. The current one doesn’t cover all requirements (like Node >= 8.9.0).
The text was updated successfully, but these errors were encountered: