Check Node version early #5430 #5501
Conversation
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
|
Another PR #5482 I do like pulling from package but think we should use semver.satisfies to check the version |
|
oh yeah, makes sense. but there are two node version checks both in index.js and createReactApp.js. Can't we remove the redundancy and add semver.satisfies in index.js @stramel |
|
IMO we remove the additional checks and only check in here using server instead of checking the parts of the version |
|
cool. I will add the change in this PR. |
| @@ -11,3 +11,4 @@ npm-debug.log* | |||
| yarn-debug.log* | |||
| yarn-error.log* | |||
| /.changelog | |||
| yarn.lock | |||
There was a problem hiding this comment.
Just curious, but why add yarn.lock to gitignore? Why not commit it?
|
This pull request has been automatically marked as stale because it has not had any recent activity. It will be closed in 5 days if no further activity occurs. |
|
This pull request has been automatically closed because it has not had any recent activity. If you have a question or comment, please open a new issue. Thank you for your contribution! |
No description provided.