Skip to content

Update node version check #5482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Update node version check #5482

wants to merge 2 commits into from

Conversation

ronihcohen
Copy link

@ronihcohen ronihcohen commented Oct 19, 2018 •
edited
Loading

@facebook-github-bot
Copy link

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

bugzpodder
bugzpodder reviewed Oct 19, 2018
View reviewed changes
Copy link

@bugzpodder bugzpodder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think eslint 5 requires 8.10 or something?

@stramel
Copy link

stramel commented Oct 19, 2018

Curious if we want to update the package.json engines.node field with this restraint and reference that in this file when doing the check?

@stramel stramel mentioned this pull request Oct 21, 2018
Closed
@ianschmitz ianschmitz mentioned this pull request Nov 17, 2018
Open
@stale
Copy link

stale bot commented Nov 18, 2018

This pull request has been automatically marked as stale because it has not had any recent activity. It will be closed in 5 days if no further activity occurs.

@stale stale bot added the stale label Nov 18, 2018
@iansu iansu removed the stale label Nov 19, 2018
@iansu iansu added this to the 2.1.2 milestone Nov 19, 2018
@Timer Timer modified the milestones: 2.1.2, 2.1.3 Dec 23, 2018
@ianschmitz
Copy link
Contributor

Curious if we want to update the package.json engines.node field with this restraint and reference that in this file when doing the check?

This sounds like a great way to do it.

@ianschmitz ianschmitz modified the milestones: 2.1.3, 2.1.4 Jan 4, 2019
adica
adica reviewed Jan 29, 2019
View reviewed changes
Copy link

@adica adica left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please change also Please update to Node 6 or higher for a better, fully supported experience to Please update to Node 9 or higher...

@ianschmitz ianschmitz modified the milestones: 2.1.4, 2.1.5 Feb 10, 2019
@iansu iansu modified the milestones: 2.1.6, 2.1.x, 3.x Mar 6, 2019
@ianschmitz
Copy link
Contributor

Looks like this was already changed. Thanks!

@ianschmitz ianschmitz closed this Aug 7, 2019
@lock lock bot locked and limited conversation to collaborators Aug 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@adica adica adica left review comments

@bugzpodder bugzpodder bugzpodder left review comments

Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
5.x
Development

Successfully merging this pull request may close these issues.
8 participants
@ronihcohen @facebook-github-bot @stramel @ianschmitz @adica @bugzpodder @iansu @Timer