Skip to content

GULLogger - count errors and warnigns #2601

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 21, 2019
Merged

GULLogger - count errors and warnigns #2601

merged 3 commits into from
Mar 21, 2019

Conversation

maksymmalyhin
Copy link
Contributor

paulb777
paulb777 reviewed Mar 21, 2019
View reviewed changes
Copy link
Member

@paulb777 paulb777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, what is the plan for a client?

@maksymmalyhin
Copy link
Contributor Author

@paulb777 As per @davidair, the data will be sent along with other Firebase analytics data. It will be a separate CL.

@maksymmalyhin maksymmalyhin merged commit 1e08a55 into master Mar 21, 2019
maksymmalyhin added a commit that referenced this pull request Apr 3, 2019
@maksymmalyhin
Revert "GULLogger - count errors and warnigns (#2601)"
629dafa 
This reverts commit 1e08a55.
@maksymmalyhin maksymmalyhin mentioned this pull request Apr 3, 2019
Merged
maksymmalyhin added a commit that referenced this pull request Apr 3, 2019
@maksymmalyhin
Revert "GULLogger - count errors and warnigns" (#2714)
b2cd981 
* Revert "GULLogger: logged issue counting concurrency issue fix (#2627)"

This reverts commit 961e9b0.

* Revert "GULLogger - issue count synchronous getters  (#2610)"

This reverts commit c6da7d6.

* Revert "GULLogger - count errors and warnigns (#2601)"

This reverts commit 1e08a55.
@paulb777 paulb777 deleted the mm/logger-count branch April 13, 2019 15:59
Corrob pushed a commit that referenced this pull request Apr 25, 2019
@maksymmalyhin @Corrob
GULLogger - count errors and warnigns (#2601)
076195f
Corrob pushed a commit that referenced this pull request Apr 25, 2019
@maksymmalyhin @Corrob
Revert "GULLogger - count errors and warnigns" (#2714)
25bd9e0 
* Revert "GULLogger: logged issue counting concurrency issue fix (#2627)"

This reverts commit 961e9b0.

* Revert "GULLogger - issue count synchronous getters  (#2610)"

This reverts commit c6da7d6.

* Revert "GULLogger - count errors and warnigns (#2601)"

This reverts commit 1e08a55.
@firebase firebase locked and limited conversation to collaborators Oct 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@paulb777 paulb777 paulb777 approved these changes

@ryanwilson ryanwilson Awaiting requested review from ryanwilson

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@maksymmalyhin @paulb777 @googlebot