Skip to content

GULLogger: logged issue counting concurrency issue fix #2627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 26, 2019

Conversation

maksymmalyhin
Copy link
Contributor

  • don't set global queue as a target for GULLoggerCounterQueue. dispatch_barier_async on a global queue behaves as just dispatch_async, so the counter could be updated concurrently.

…ue to make sure dispatch_barrier_async works correctly.
@maksymmalyhin maksymmalyhin merged commit 961e9b0 into master Mar 26, 2019
@maksymmalyhin maksymmalyhin deleted the mm/log-counter branch March 26, 2019 19:12
maksymmalyhin added a commit that referenced this pull request Apr 3, 2019
maksymmalyhin added a commit that referenced this pull request Apr 3, 2019
* Revert "GULLogger: logged issue counting concurrency issue fix (#2627)"

This reverts commit 961e9b0.

* Revert "GULLogger - issue count synchronous getters  (#2610)"

This reverts commit c6da7d6.

* Revert "GULLogger - count errors and warnigns (#2601)"

This reverts commit 1e08a55.
Corrob pushed a commit that referenced this pull request Apr 25, 2019
* Revert "GULLogger: logged issue counting concurrency issue fix (#2627)"

This reverts commit 961e9b0.

* Revert "GULLogger - issue count synchronous getters  (#2610)"

This reverts commit c6da7d6.

* Revert "GULLogger - count errors and warnigns (#2601)"

This reverts commit 1e08a55.
@firebase firebase locked and limited conversation to collaborators Oct 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants