Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

[UWP] Remove 1px offset to make root widget fully shown #27922

Merged
merged 1 commit into from
Oct 14, 2021
Merged

[UWP] Remove 1px offset to make root widget fully shown #27922

merged 1 commit into from
Oct 14, 2021

Conversation

moko256
Copy link
Contributor

@moko256 moko256 commented Aug 6, 2021 •
edited
Loading

This PR fixes extra 1px offset from window's top-left and make root widget fully shown, on UWP on the device that is not Xbox.
This fixes flutter/flutter#87785.

Screenshot (using example from: flutter/flutter#87785):

Before After
one_px_border_winuwp one_px_border_winuwp_fixed

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide] and the [C++, Objective-C, Java style guides].
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See [testing the engine] for instructions on
    writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the [CLA].
  • All existing and new tests are passing.

@google-cla google-cla bot added the cla: yes label Aug 6, 2021
@chinmaygarde
Copy link
Member

cc @clarkezone who was the author of the original patch. I think this looks fine but I also don't understand the intent of the original implementation.

@clarkezone
Copy link

Thx. I will take a look in the next day or so.

@clarkezone
Copy link

clarkezone commented Sep 8, 2021 •
edited
Loading

Sorry for the delay, will look this evening.

Edit: I am having build issues with Windows top of tree currently, posted in discord waiting to here back

@clarkezone
Copy link

please can you update this to ToT, I'm unblocked to look at it now

@moko256 moko256 force-pushed the moko256_uwp_remove_extra_1px_offset branch from 81cfb21 to 425fc26 Compare October 10, 2021 19:08
@moko256
Copy link
Contributor Author

moko256 commented Oct 10, 2021 •
edited
Loading

@clarkezone I rebased with master now.

@moko256 moko256 force-pushed the moko256_uwp_remove_extra_1px_offset branch from 425fc26 to 2ba8ddf Compare October 12, 2021 23:49
clarkezone
clarkezone approved these changes Oct 14, 2021
View reviewed changes
Copy link

@clarkezone clarkezone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thx for your patience.

@chinmaygarde chinmaygarde added the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label Oct 14, 2021
@fluttergithubbot fluttergithubbot merged commit 08c7f86 into flutter:master Oct 14, 2021
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 14, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 14, 2021
@engine-flutter-autoroll
08c7f86 [UWP] Remove 1px offset to make root widget fully shown (flut…
0d67f89 
…ter/engine#27922)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 14, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 14, 2021
@engine-flutter-autoroll
08c7f86 [UWP] Remove 1px offset to make root widget fully shown (flut…
cdd377b 
…ter/engine#27922)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 15, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 15, 2021
@engine-flutter-autoroll
08c7f86 [UWP] Remove 1px offset to make root widget fully shown (flut…
b65eb63 
…ter/engine#27922)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 15, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 15, 2021
@engine-flutter-autoroll
08c7f86 [UWP] Remove 1px offset to make root widget fully shown (flut…
874b228 
…ter/engine#27922)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 15, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 15, 2021
@engine-flutter-autoroll
08c7f86 [UWP] Remove 1px offset to make root widget fully shown (flut…
d8b0d24 
…ter/engine#27922)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 15, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 15, 2021
@engine-flutter-autoroll
08c7f86 [UWP] Remove 1px offset to make root widget fully shown (flut…
88e63a9 
…ter/engine#27922)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 15, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 15, 2021
@engine-flutter-autoroll
08c7f86 [UWP] Remove 1px offset to make root widget fully shown (flut…
5b6e2b8 
…ter/engine#27922)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 15, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 15, 2021
@engine-flutter-autoroll
08c7f86 [UWP] Remove 1px offset to make root widget fully shown (flut…
63591ba 
…ter/engine#27922)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 15, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 15, 2021
@engine-flutter-autoroll
08c7f86 [UWP] Remove 1px offset to make root widget fully shown (flut…
bd10a65 
…ter/engine#27922)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 15, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 15, 2021
@engine-flutter-autoroll
08c7f86 [UWP] Remove 1px offset to make root widget fully shown (flut…
8b5ce46 
…ter/engine#27922)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 15, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 15, 2021
@engine-flutter-autoroll
08c7f86 [UWP] Remove 1px offset to make root widget fully shown (flut…
2c4efbe 
…ter/engine#27922)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 15, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 15, 2021
@engine-flutter-autoroll
08c7f86 [UWP] Remove 1px offset to make root widget fully shown (flut…
6c62dad 
…ter/engine#27922)
@iskakaushik iskakaushik mentioned this pull request Oct 15, 2021
Merged
8 tasks
iskakaushik added a commit to iskakaushik/flutter that referenced this pull request Oct 15, 2021
@iskakaushik
https://github.com/flutter/engine/compare/8034050e7810...60d0fdf
b15edde 
Also ignores: flutter#91906

2021-10-15 [email protected] [web] Add goldctl as a dependency in LUCI (flutter/engine#29168)
2021-10-15 [email protected] Revert "Set system bar appearance using WindowInsetsControllerCompat instead of the deprecated View#setSystemUiVisibility (flutter#29060)" (flutter/engine#29206)
2021-10-15 [email protected] Roll Dart SDK from e8c02a935741 to 42acd2ae8fa8 (1 revision) (flutter/engine#29205)
2021-10-15 [email protected] Roll Dart SDK from 9f3cd7a49814 to e8c02a935741 (1 revision) (flutter/engine#29204)
2021-10-15 [email protected] Roll Skia from 012f7146067a to b24bad31dc05 (3 revisions) (flutter/engine#29203)
2021-10-15 [email protected] Roll Skia from 72602b668e22 to 012f7146067a (1 revision) (flutter/engine#29202)
2021-10-15 [email protected] Roll Dart SDK from aaca2ac128ae to 9f3cd7a49814 (1 revision) (flutter/engine#29201)
2021-10-15 [email protected] Set the use_ios_simulator flag only on platforms where it is defined (iOS/Mac) (flutter/engine#29199)
2021-10-14 [email protected] [fuchsia] Create CF v2 Flutter runner. (flutter/engine#29142)
2021-10-14 [email protected] Roll Dart SDK from 82b0281cbcf3 to aaca2ac128ae (1 revision) (flutter/engine#29198)
2021-10-14 [email protected] Roll Skia from aa9656d8caa6 to 72602b668e22 (1 revision) (flutter/engine#29196)
2021-10-14 [email protected] Ignore implicit_dynamic_function analyzer error for js_util generic methods (flutter/engine#29192)
2021-10-14 [email protected] [web] use 'dart compile js' instead of 'dart2js' in web_ui and felt (flutter/engine#29179)
2021-10-14 [email protected] Roll Dart SDK from 081a57c06088 to 82b0281cbcf3 (3 revisions) (flutter/engine#29195)
2021-10-14 [email protected] Roll Skia from d0c7f636453b to aa9656d8caa6 (3 revisions) (flutter/engine#29194)
2021-10-14 [email protected] Set system bar appearance using WindowInsetsControllerCompat instead of the deprecated View#setSystemUiVisibility (flutter/engine#29060)
2021-10-14 [email protected] [UWP] Remove 1px offset to make root widget fully shown (flutter/engine#27922)
2021-10-14 [email protected] Roll Skia from ab19daec3b88 to d0c7f636453b (1 revision) (flutter/engine#29191)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
kylinchen pushed a commit to XianyuTech/engine that referenced this pull request Oct 22, 2021
@moko256 @kylinchen
[UWP] Remove 1px offset to make root widget fully shown (flutter#27922)
7a641ad
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
1 more reviewer

@clarkezone clarkezone clarkezone approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
cla: yes platform-windows waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[UWP] App has extra 1x1 offset and root widget is not shown fully
4 participants
@moko256 @chinmaygarde @clarkezone @fluttergithubbot