Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Ignore implicit_dynamic_function analyzer error for js_util generic methods #29192

Merged
merged 3 commits into from
Oct 14, 2021
Merged

Ignore implicit_dynamic_function analyzer error for js_util generic methods #29192

merged 3 commits into from
Oct 14, 2021

Conversation

rileyporter
Copy link
Contributor

@rileyporter rileyporter commented Oct 14, 2021 •
edited
Loading

Dart js_util methods are changing to have a generic return type, which will allow type inference and remove explicit and implicit casts. This will cause the analyzer to trigger for implicit_dynamic_function on some instances where dynamic is the inferred type.

This pull request is part of a chain to:
(1) ignore these instances in the analyzer
(2) land the Dart js_util changes
(3) update these Flutter instances to state the explicit types

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide] and the [C++, Objective-C, Java style guides].
  • I listed at least one issue that this PR fixes in the description above. ** pre-emptively fixing an issue, no issue to track**
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See [testing the engine] for instructions on ** only commenting changes, no tests to add**
    writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the [CLA].
  • All existing and new tests are passing.

@flutter-dashboard flutter-dashboard bot added the platform-web Code specifically for the web engine label Oct 14, 2021
@google-cla google-cla bot added the cla: yes label Oct 14, 2021
@rileyporter rileyporter mentioned this pull request Oct 14, 2021
Closed
8 tasks
@yjbanov yjbanov self-requested a review October 14, 2021 19:52
yjbanov
yjbanov approved these changes Oct 14, 2021
View reviewed changes
Copy link
Contributor

@yjbanov yjbanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rileyporter
Copy link
Contributor Author

I don't think I have access to add the waiting-for-tree-to-go-green label, but I think this should be ready to submit whenever the tree is green.

@sigmundch sigmundch added the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label Oct 14, 2021
@fluttergithubbot fluttergithubbot merged commit 6be7c14 into flutter:master Oct 14, 2021
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 14, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 14, 2021
@engine-flutter-autoroll
6be7c14 Ignore implicit_dynamic_function analyzer error for js_util g…
5116eb0 
…eneric methods (flutter/engine#29192)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 15, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 15, 2021
@engine-flutter-autoroll
6be7c14 Ignore implicit_dynamic_function analyzer error for js_util g…
078a001 
…eneric methods (flutter/engine#29192)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 15, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 15, 2021
@engine-flutter-autoroll
6be7c14 Ignore implicit_dynamic_function analyzer error for js_util g…
f2e0dbb 
…eneric methods (flutter/engine#29192)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 15, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 15, 2021
@engine-flutter-autoroll
6be7c14 Ignore implicit_dynamic_function analyzer error for js_util g…
53d9636 
…eneric methods (flutter/engine#29192)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 15, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 15, 2021
@engine-flutter-autoroll
6be7c14 Ignore implicit_dynamic_function analyzer error for js_util g…
b6d9edd 
…eneric methods (flutter/engine#29192)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 15, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 15, 2021
@engine-flutter-autoroll
6be7c14 Ignore implicit_dynamic_function analyzer error for js_util g…
fdcdf3c 
…eneric methods (flutter/engine#29192)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 15, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 15, 2021
@engine-flutter-autoroll
6be7c14 Ignore implicit_dynamic_function analyzer error for js_util g…
d3b4f97 
…eneric methods (flutter/engine#29192)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 15, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 15, 2021
@engine-flutter-autoroll
6be7c14 Ignore implicit_dynamic_function analyzer error for js_util g…
d06d69b 
…eneric methods (flutter/engine#29192)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 15, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 15, 2021
@engine-flutter-autoroll
6be7c14 Ignore implicit_dynamic_function analyzer error for js_util g…
3004ad0 
…eneric methods (flutter/engine#29192)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 15, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 15, 2021
@engine-flutter-autoroll
6be7c14 Ignore implicit_dynamic_function analyzer error for js_util g…
400e9d2 
…eneric methods (flutter/engine#29192)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 15, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 15, 2021
@engine-flutter-autoroll
6be7c14 Ignore implicit_dynamic_function analyzer error for js_util g…
a95bc1b 
…eneric methods (flutter/engine#29192)
@iskakaushik iskakaushik mentioned this pull request Oct 15, 2021
Merged
8 tasks
iskakaushik added a commit to iskakaushik/flutter that referenced this pull request Oct 15, 2021
@iskakaushik
https://github.com/flutter/engine/compare/8034050e7810...60d0fdf
b15edde 
Also ignores: flutter#91906

2021-10-15 [email protected] [web] Add goldctl as a dependency in LUCI (flutter/engine#29168)
2021-10-15 [email protected] Revert "Set system bar appearance using WindowInsetsControllerCompat instead of the deprecated View#setSystemUiVisibility (flutter#29060)" (flutter/engine#29206)
2021-10-15 [email protected] Roll Dart SDK from e8c02a935741 to 42acd2ae8fa8 (1 revision) (flutter/engine#29205)
2021-10-15 [email protected] Roll Dart SDK from 9f3cd7a49814 to e8c02a935741 (1 revision) (flutter/engine#29204)
2021-10-15 [email protected] Roll Skia from 012f7146067a to b24bad31dc05 (3 revisions) (flutter/engine#29203)
2021-10-15 [email protected] Roll Skia from 72602b668e22 to 012f7146067a (1 revision) (flutter/engine#29202)
2021-10-15 [email protected] Roll Dart SDK from aaca2ac128ae to 9f3cd7a49814 (1 revision) (flutter/engine#29201)
2021-10-15 [email protected] Set the use_ios_simulator flag only on platforms where it is defined (iOS/Mac) (flutter/engine#29199)
2021-10-14 [email protected] [fuchsia] Create CF v2 Flutter runner. (flutter/engine#29142)
2021-10-14 [email protected] Roll Dart SDK from 82b0281cbcf3 to aaca2ac128ae (1 revision) (flutter/engine#29198)
2021-10-14 [email protected] Roll Skia from aa9656d8caa6 to 72602b668e22 (1 revision) (flutter/engine#29196)
2021-10-14 [email protected] Ignore implicit_dynamic_function analyzer error for js_util generic methods (flutter/engine#29192)
2021-10-14 [email protected] [web] use 'dart compile js' instead of 'dart2js' in web_ui and felt (flutter/engine#29179)
2021-10-14 [email protected] Roll Dart SDK from 081a57c06088 to 82b0281cbcf3 (3 revisions) (flutter/engine#29195)
2021-10-14 [email protected] Roll Skia from d0c7f636453b to aa9656d8caa6 (3 revisions) (flutter/engine#29194)
2021-10-14 [email protected] Set system bar appearance using WindowInsetsControllerCompat instead of the deprecated View#setSystemUiVisibility (flutter/engine#29060)
2021-10-14 [email protected] [UWP] Remove 1px offset to make root widget fully shown (flutter/engine#27922)
2021-10-14 [email protected] Roll Skia from ab19daec3b88 to d0c7f636453b (1 revision) (flutter/engine#29191)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@rileyporter rileyporter mentioned this pull request Oct 21, 2021
Closed
kylinchen pushed a commit to XianyuTech/engine that referenced this pull request Oct 22, 2021
@rileyporter @kylinchen
Ignore implicit_dynamic_function analyzer error for js_util generic m…
d6eb9a0 
…ethods (flutter#29192)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
1 more reviewer

@yjbanov yjbanov yjbanov approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
cla: yes platform-web Code specifically for the web engine waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rileyporter @yjbanov @sigmundch @fluttergithubbot