Set system bar appearance using WindowInsetsControllerCompat instead of the deprecated View#setSystemUiVisibility #29060

wytesk133 · 2021-10-07T12:11:40Z

The deprecated APIs conflict with Android 12's SplashScreenView#remove behavior causing light status bar icon on light background.

Part of flutter/flutter#91128
Internal bugs: b/199402891, b/201727280

If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
I listed at least one issue that this PR fixes in the description above.
I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on
writing and running engine tests.
I updated/added relevant documentation (doc comments with ///).
I signed the CLA.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

flutter-dashboard · 2021-10-07T12:11:43Z

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

blasten · 2021-10-07T20:33:06Z

fyi @camsim99 - Camille was working on this issue.

tools/cipd/android_embedding_bundle/build.gradle

camsim99 · 2021-10-08T16:06:59Z

@wytesk133 Can you also take a look at the usage of View#setSystemUiVisibility in FlutterActivityDelegate?

wytesk133 · 2021-10-08T20:19:20Z

@camsim99 Seems like there are many other get/setSystemUiVisibility usages. I don't think I'll have the bandwidth to look into them, but let me know in the chat or email if I can be in any help (e.g., testing with my team's app, etc.).

…of the deprecated View#setSystemUiVisibility The deprecated APIs conflict with Android 12's `SplashScreenView#remove` behavior causing light status bar icon on light background.

wytesk133 · 2021-10-14T18:33:11Z

Friendly ping

blasten

LGTM

blasten · 2021-10-14T18:45:40Z

@wytesk133 are you able to file an issue for the remaining changes?

wytesk133 · 2021-10-14T19:39:23Z

The PR should fix b/201727280.

For the remaining parts, there is already flutter/flutter#91128 filed for b/199402891.

btw, I don't have write access, so could you also help merging this PR?

Thank you!

…instead of the deprecated View#setSystemUiVisibility (flutter/engine#29060)

…instead of the deprecated View#setSystemUiVisibility (#29060)" This reverts commit d8d9c4f.

…instead of the deprecated View#setSystemUiVisibility (flutter/engine#29060)

…instead of the deprecated View#setSystemUiVisibility (#29060)" (#29206) This reverts commit d8d9c4f.

…instead of the deprecated View#setSystemUiVisibility (flutter/engine#29060)

Also ignores: flutter#91906 2021-10-15 [email protected] [web] Add goldctl as a dependency in LUCI (flutter/engine#29168) 2021-10-15 [email protected] Revert "Set system bar appearance using WindowInsetsControllerCompat instead of the deprecated View#setSystemUiVisibility (flutter#29060)" (flutter/engine#29206) 2021-10-15 [email protected] Roll Dart SDK from e8c02a935741 to 42acd2ae8fa8 (1 revision) (flutter/engine#29205) 2021-10-15 [email protected] Roll Dart SDK from 9f3cd7a49814 to e8c02a935741 (1 revision) (flutter/engine#29204) 2021-10-15 [email protected] Roll Skia from 012f7146067a to b24bad31dc05 (3 revisions) (flutter/engine#29203) 2021-10-15 [email protected] Roll Skia from 72602b668e22 to 012f7146067a (1 revision) (flutter/engine#29202) 2021-10-15 [email protected] Roll Dart SDK from aaca2ac128ae to 9f3cd7a49814 (1 revision) (flutter/engine#29201) 2021-10-15 [email protected] Set the use_ios_simulator flag only on platforms where it is defined (iOS/Mac) (flutter/engine#29199) 2021-10-14 [email protected] [fuchsia] Create CF v2 Flutter runner. (flutter/engine#29142) 2021-10-14 [email protected] Roll Dart SDK from 82b0281cbcf3 to aaca2ac128ae (1 revision) (flutter/engine#29198) 2021-10-14 [email protected] Roll Skia from aa9656d8caa6 to 72602b668e22 (1 revision) (flutter/engine#29196) 2021-10-14 [email protected] Ignore implicit_dynamic_function analyzer error for js_util generic methods (flutter/engine#29192) 2021-10-14 [email protected] [web] use 'dart compile js' instead of 'dart2js' in web_ui and felt (flutter/engine#29179) 2021-10-14 [email protected] Roll Dart SDK from 081a57c06088 to 82b0281cbcf3 (3 revisions) (flutter/engine#29195) 2021-10-14 [email protected] Roll Skia from d0c7f636453b to aa9656d8caa6 (3 revisions) (flutter/engine#29194) 2021-10-14 [email protected] Set system bar appearance using WindowInsetsControllerCompat instead of the deprecated View#setSystemUiVisibility (flutter/engine#29060) 2021-10-14 [email protected] [UWP] Remove 1px offset to make root widget fully shown (flutter/engine#27922) 2021-10-14 [email protected] Roll Skia from ab19daec3b88 to d0c7f636453b (1 revision) (flutter/engine#29191) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

…of the deprecated View#setSystemUiVisibility (flutter#29060)

…instead of the deprecated View#setSystemUiVisibility (flutter#29060)" (flutter#29206) This reverts commit d8d9c4f.

…rCompat instead of the deprecated View#setSystemUiVisibility (flutter#29060)" (flutter#29206)" This reverts commit b1e7ad8.

flutter-dashboard bot added the platform-android label Oct 7, 2021

flutter-dashboard bot added the needs tests label Oct 7, 2021

google-cla bot added the cla: yes label Oct 7, 2021

wytesk133 force-pushed the status-bar-fix branch 6 times, most recently from c9f6b47 to 0ce146c Compare October 7, 2021 18:02

zanderso requested a review from blasten October 7, 2021 20:28

blasten reviewed Oct 7, 2021

View reviewed changes

tools/cipd/android_embedding_bundle/build.gradle Outdated Show resolved Hide resolved

wytesk133 force-pushed the status-bar-fix branch from 0ce146c to 0446157 Compare October 8, 2021 05:44

wytesk133 force-pushed the status-bar-fix branch 7 times, most recently from 1b12a37 to 1a6a63d Compare October 9, 2021 08:47

Set system bar appearance using WindowInsetsControllerCompat instead …

fc5e633

…of the deprecated View#setSystemUiVisibility The deprecated APIs conflict with Android 12's `SplashScreenView#remove` behavior causing light status bar icon on light background.

wytesk133 force-pushed the status-bar-fix branch from 1a6a63d to fc5e633 Compare October 9, 2021 15:14

wytesk133 requested a review from blasten October 9, 2021 16:26

blasten approved these changes Oct 14, 2021

View reviewed changes

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 15, 2021

d8d9c4f Set system bar appearance using WindowInsetsControllerCompat …

1ecccb6

…instead of the deprecated View#setSystemUiVisibility (flutter/engine#29060)

engine-flutter-autoroll mentioned this pull request Oct 15, 2021

Roll Engine from 8034050e7810 to fe7861cafbfb (11 revisions) flutter/flutter#91865

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 15, 2021

d8d9c4f Set system bar appearance using WindowInsetsControllerCompat …

253d6a2

…instead of the deprecated View#setSystemUiVisibility (flutter/engine#29060)

engine-flutter-autoroll mentioned this pull request Oct 15, 2021

Roll Engine from 8034050e7810 to 41f767223488 (12 revisions) flutter/flutter#91876

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 15, 2021

d8d9c4f Set system bar appearance using WindowInsetsControllerCompat …

4aaf03f

…instead of the deprecated View#setSystemUiVisibility (flutter/engine#29060)

engine-flutter-autoroll mentioned this pull request Oct 15, 2021

Roll Engine from 8034050e7810 to da2884a1c5bc (13 revisions) flutter/flutter#91878

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 15, 2021

d8d9c4f Set system bar appearance using WindowInsetsControllerCompat …

bc45b9a

…instead of the deprecated View#setSystemUiVisibility (flutter/engine#29060)

engine-flutter-autoroll mentioned this pull request Oct 15, 2021

Roll Engine from 8034050e7810 to 32450391ac2d (15 revisions) flutter/flutter#91882

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 15, 2021

d8d9c4f Set system bar appearance using WindowInsetsControllerCompat …

b098f72

…instead of the deprecated View#setSystemUiVisibility (flutter/engine#29060)

renyou added a commit that referenced this pull request Oct 15, 2021

Revert "Set system bar appearance using WindowInsetsControllerCompat …

621a6ea

…instead of the deprecated View#setSystemUiVisibility (#29060)" This reverts commit d8d9c4f.

renyou mentioned this pull request Oct 15, 2021

Revert "Set system bar appearance using WindowInsetsControllerCompat instead of the deprecated View#setSystemUiVisibility" #29206

Merged

engine-flutter-autoroll mentioned this pull request Oct 15, 2021

Roll Engine from 8034050e7810 to 32450391ac2d (15 revisions) flutter/flutter#91888

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 15, 2021

d8d9c4f Set system bar appearance using WindowInsetsControllerCompat …

affbbb8

…instead of the deprecated View#setSystemUiVisibility (flutter/engine#29060)

renyou added a commit that referenced this pull request Oct 15, 2021

Revert "Set system bar appearance using WindowInsetsControllerCompat …

b1e7ad8

…instead of the deprecated View#setSystemUiVisibility (#29060)" (#29206) This reverts commit d8d9c4f.

engine-flutter-autoroll mentioned this pull request Oct 15, 2021

Roll Engine from 8034050e7810 to bcdd9fe95e7f (16 revisions) flutter/flutter#91892

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 15, 2021

d8d9c4f Set system bar appearance using WindowInsetsControllerCompat …

d020700

…instead of the deprecated View#setSystemUiVisibility (flutter/engine#29060)

engine-flutter-autoroll mentioned this pull request Oct 15, 2021

Roll Engine from 8034050e7810 to b1e7ad8c0103 (17 revisions) flutter/flutter#91897

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 15, 2021

d8d9c4f Set system bar appearance using WindowInsetsControllerCompat …

bae8c93

…instead of the deprecated View#setSystemUiVisibility (flutter/engine#29060)

engine-flutter-autoroll mentioned this pull request Oct 15, 2021

Roll Engine from 8034050e7810 to 60d0fdfa2232 (18 revisions) flutter/flutter#91901

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 15, 2021

d8d9c4f Set system bar appearance using WindowInsetsControllerCompat …

6d98414

…instead of the deprecated View#setSystemUiVisibility (flutter/engine#29060)

engine-flutter-autoroll mentioned this pull request Oct 15, 2021

Roll Engine from 8034050e7810 to cfa388895461 (19 revisions) flutter/flutter#91904

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 15, 2021

d8d9c4f Set system bar appearance using WindowInsetsControllerCompat …

71c5155

…instead of the deprecated View#setSystemUiVisibility (flutter/engine#29060)

iskakaushik mentioned this pull request Oct 15, 2021

Roll Engine from 8034050e7810 to 60d0fdfa2232 (18 revisions) flutter/flutter#91907

Merged

8 tasks

kylinchen pushed a commit to XianyuTech/engine that referenced this pull request Oct 22, 2021

Set system bar appearance using WindowInsetsControllerCompat instead …

cee9419

…of the deprecated View#setSystemUiVisibility (flutter#29060)

blasten mentioned this pull request Oct 29, 2021

Reland "Set system bar appearance using WindowInsetsController" #29403

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Set system bar appearance using WindowInsetsControllerCompat instead of the deprecated View#setSystemUiVisibility #29060

Set system bar appearance using WindowInsetsControllerCompat instead of the deprecated View#setSystemUiVisibility #29060

Uh oh!

wytesk133 commented Oct 7, 2021 •

edited

Loading

Uh oh!

flutter-dashboard bot commented Oct 7, 2021

Uh oh!

blasten commented Oct 7, 2021

Uh oh!

Uh oh!

camsim99 commented Oct 8, 2021

Uh oh!

wytesk133 commented Oct 8, 2021

Uh oh!

wytesk133 commented Oct 14, 2021

Uh oh!

blasten left a comment

Uh oh!

blasten commented Oct 14, 2021

Uh oh!

wytesk133 commented Oct 14, 2021

Uh oh!

Uh oh!

Set system bar appearance using WindowInsetsControllerCompat instead of the deprecated View#setSystemUiVisibility #29060

Set system bar appearance using WindowInsetsControllerCompat instead of the deprecated View#setSystemUiVisibility #29060

Uh oh!

Conversation

wytesk133 commented Oct 7, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-launch Checklist

Uh oh!

flutter-dashboard bot commented Oct 7, 2021

Uh oh!

blasten commented Oct 7, 2021

Uh oh!

Uh oh!

camsim99 commented Oct 8, 2021

Uh oh!

wytesk133 commented Oct 8, 2021

Uh oh!

wytesk133 commented Oct 14, 2021

Uh oh!

blasten left a comment

Choose a reason for hiding this comment

Uh oh!

blasten commented Oct 14, 2021

Uh oh!

wytesk133 commented Oct 14, 2021

Uh oh!

Uh oh!

wytesk133 commented Oct 7, 2021 •

edited

Loading