This repository was archived by the owner on Feb 25, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 6k
[Impeller] Removed last ivars to raw vk::Device's. #42215
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
659a1ff
to
b4c3cb2
Compare
87deb58
to
f4bbe42
Compare
f4bbe42
to
1c540de
Compare
@@ -131,10 +133,16 @@ class ContextVK final : public Context, | |||
std::shared_ptr<FenceWaiterVK> GetFenceWaiter() const; | |||
|
|||
private: | |||
vk::UniqueInstance instance_; | |||
struct UniqueDeviceHolder : public DeviceHolder { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Avoid the "Unique" name for something that does not provide an interface similar to std::unique_ptr
. Call this something like DeviceHolderImpl
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
jason-simmons
approved these changes
May 23, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 23, 2023
zanderso
pushed a commit
to flutter/flutter
that referenced
this pull request
May 23, 2023
…127416) flutter/engine@a6e37bd...ccf50f3 2023-05-23 [email protected] Roll Fuchsia Linux SDK from Zbd3haNY2Idcdu1Fj... to -dXJ_pnUVwmjscIYm... (flutter/engine#42250) 2023-05-23 [email protected] [Impeller] Removed last ivars to raw vk::Device's. (flutter/engine#42215) 2023-05-23 [email protected] Roll Skia from 225d51031ad0 to 292879d286e9 (5 revisions) (flutter/engine#42249) 2023-05-23 [email protected] Build arm64 FlutterEmbedder.framework and lipo the result (flutter/engine#42233) 2023-05-23 [email protected] Roll watcher dependency for web_ui to 1.1.0. (flutter/engine#42248) 2023-05-23 [email protected] [web] Move platformViewRegistry to ui_web (flutter/engine#41877) 2023-05-23 [email protected] Roll Skia from 3ded22186598 to 225d51031ad0 (1 revision) (flutter/engine#42246) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from Zbd3haNY2Idc to -dXJ_pnUVwmj If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
CaseyHillers
pushed a commit
to CaseyHillers/flutter
that referenced
this pull request
May 24, 2023
…lutter#127416) flutter/engine@a6e37bd...ccf50f3 2023-05-23 [email protected] Roll Fuchsia Linux SDK from Zbd3haNY2Idcdu1Fj... to -dXJ_pnUVwmjscIYm... (flutter/engine#42250) 2023-05-23 [email protected] [Impeller] Removed last ivars to raw vk::Device's. (flutter/engine#42215) 2023-05-23 [email protected] Roll Skia from 225d51031ad0 to 292879d286e9 (5 revisions) (flutter/engine#42249) 2023-05-23 [email protected] Build arm64 FlutterEmbedder.framework and lipo the result (flutter/engine#42233) 2023-05-23 [email protected] Roll watcher dependency for web_ui to 1.1.0. (flutter/engine#42248) 2023-05-23 [email protected] [web] Move platformViewRegistry to ui_web (flutter/engine#41877) 2023-05-23 [email protected] Roll Skia from 3ded22186598 to 225d51031ad0 (1 revision) (flutter/engine#42246) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from Zbd3haNY2Idc to -dXJ_pnUVwmj If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the last ivars that hold onto a
Device
directly. This have recently been the cause of crashes, so the safer thing is to remove them all.For the Allocator and the Sampler library, removing the device ivars is likely just a precaution since they should have only been accessed from the raster thread and killed before the Device. The fence waiter however was potentially accessing the device from a separate thread, so that was much more risky and likely to cause crashes.
Testing: The existing
impeller_unittests
verify this is setup correctly.Pre-launch Checklist
///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.