This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Build arm64 FlutterEmbedder.framework and lipo the result #42233
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zanderso
force-pushed
the
lipo-embedder-framework
branch
from
7509a3a to
6d8a722
Compare
zanderso
force-pushed
the
lipo-embedder-framework
branch
from
6d8a722 to
cf9ea79
Compare
|
cc @jiahaog after this lands could you try it out with https://github.com/jiahaog/flt ? |
chinmaygarde
approved these changes
May 23, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 23, 2023
zanderso
pushed a commit
to flutter/flutter
that referenced
this pull request
May 23, 2023
…127416) flutter/engine@a6e37bd...ccf50f3 2023-05-23 [email protected] Roll Fuchsia Linux SDK from Zbd3haNY2Idcdu1Fj... to -dXJ_pnUVwmjscIYm... (flutter/engine#42250) 2023-05-23 [email protected] [Impeller] Removed last ivars to raw vk::Device's. (flutter/engine#42215) 2023-05-23 [email protected] Roll Skia from 225d51031ad0 to 292879d286e9 (5 revisions) (flutter/engine#42249) 2023-05-23 [email protected] Build arm64 FlutterEmbedder.framework and lipo the result (flutter/engine#42233) 2023-05-23 [email protected] Roll watcher dependency for web_ui to 1.1.0. (flutter/engine#42248) 2023-05-23 [email protected] [web] Move platformViewRegistry to ui_web (flutter/engine#41877) 2023-05-23 [email protected] Roll Skia from 3ded22186598 to 225d51031ad0 (1 revision) (flutter/engine#42246) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from Zbd3haNY2Idc to -dXJ_pnUVwmj If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
jiahaog
added a commit
to jiahaog/flt
that referenced
this pull request
May 24, 2023
This flutter commit contains flutter/engine#42233, which includes a fat binary in `FlutterEmbedder.framework`.
jiahaog
added a commit
to jiahaog/flt
that referenced
this pull request
May 24, 2023
This flutter commit contains flutter/engine#42233, which includes a fat binary in `FlutterEmbedder.framework`.
|
Thanks Zach, I was able to use this in jiahaog/flt@d8dd1e1. I don't have an arm mac to verify though, can you give it a shot? |
CaseyHillers
pushed a commit
to CaseyHillers/flutter
that referenced
this pull request
May 24, 2023
…lutter#127416) flutter/engine@a6e37bd...ccf50f3 2023-05-23 [email protected] Roll Fuchsia Linux SDK from Zbd3haNY2Idcdu1Fj... to -dXJ_pnUVwmjscIYm... (flutter/engine#42250) 2023-05-23 [email protected] [Impeller] Removed last ivars to raw vk::Device's. (flutter/engine#42215) 2023-05-23 [email protected] Roll Skia from 225d51031ad0 to 292879d286e9 (5 revisions) (flutter/engine#42249) 2023-05-23 [email protected] Build arm64 FlutterEmbedder.framework and lipo the result (flutter/engine#42233) 2023-05-23 [email protected] Roll watcher dependency for web_ui to 1.1.0. (flutter/engine#42248) 2023-05-23 [email protected] [web] Move platformViewRegistry to ui_web (flutter/engine#41877) 2023-05-23 [email protected] Roll Skia from 3ded22186598 to 225d51031ad0 (1 revision) (flutter/engine#42246) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from Zbd3haNY2Idc to -dXJ_pnUVwmj If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies the mac_host_engine build config to build the FlutterEmbedder.framework for arm64, and adds a generator that creates a fat framework containing both the intel and arm64 dylibs. The fat framework is uploaded to the gcs bucket instead of the thin intel-only one.
The script to create the lipo'd embedder framework is different enough from the desktop framework to have a separate script, but this still triggers the pylint duplicate-code check. Due to a bug in our version of pylint (pylint-dev/pylint#214), it isn't possible to disable per-file, so this PR also disables the check globally.