Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Roll watcher dependency for web_ui to 1.1.0. #42248

Merged
merged 2 commits into from
May 23, 2023
Merged

Conversation

aam
Copy link
Member

@aam aam commented May 23, 2023

Incoming dart sdk roll https://dart.googlesource.com/sdk.git/+log/90b4df96e9dc..4881eadbade6 needs updated version of watcher due to FileSystemEvent becoming sealed.

Incoming dart sdk change needs updated version of watcher
@flutter-dashboard flutter-dashboard bot added the platform-web Code specifically for the web engine label May 23, 2023
@aam
Copy link
Member Author

aam commented May 23, 2023

cc @brianquinlan

Copy link
Member

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

@aam aam merged commit e9d1310 into flutter:main May 23, 2023
@aam aam deleted the roll-web-ui-watcher branch May 23, 2023 16:44
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 23, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 23, 2023
zanderso pushed a commit to flutter/flutter that referenced this pull request May 23, 2023
…127416)

flutter/engine@a6e37bd...ccf50f3

2023-05-23 [email protected] Roll Fuchsia Linux SDK from
Zbd3haNY2Idcdu1Fj... to -dXJ_pnUVwmjscIYm... (flutter/engine#42250)
2023-05-23 [email protected] [Impeller]
Removed last ivars to raw vk::Device's. (flutter/engine#42215)
2023-05-23 [email protected] Roll Skia from 225d51031ad0 to
292879d286e9 (5 revisions) (flutter/engine#42249)
2023-05-23 [email protected] Build arm64
FlutterEmbedder.framework and lipo the result (flutter/engine#42233)
2023-05-23 [email protected] Roll watcher dependency for web_ui to 1.1.0.
(flutter/engine#42248)
2023-05-23 [email protected] [web] Move platformViewRegistry to ui_web
(flutter/engine#41877)
2023-05-23 [email protected] Roll Skia from 3ded22186598 to
225d51031ad0 (1 revision) (flutter/engine#42246)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from Zbd3haNY2Idc to -dXJ_pnUVwmj

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the
revert to ensure that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
CaseyHillers pushed a commit to CaseyHillers/flutter that referenced this pull request May 24, 2023
…lutter#127416)

flutter/engine@a6e37bd...ccf50f3

2023-05-23 [email protected] Roll Fuchsia Linux SDK from
Zbd3haNY2Idcdu1Fj... to -dXJ_pnUVwmjscIYm... (flutter/engine#42250)
2023-05-23 [email protected] [Impeller]
Removed last ivars to raw vk::Device's. (flutter/engine#42215)
2023-05-23 [email protected] Roll Skia from 225d51031ad0 to
292879d286e9 (5 revisions) (flutter/engine#42249)
2023-05-23 [email protected] Build arm64
FlutterEmbedder.framework and lipo the result (flutter/engine#42233)
2023-05-23 [email protected] Roll watcher dependency for web_ui to 1.1.0.
(flutter/engine#42248)
2023-05-23 [email protected] [web] Move platformViewRegistry to ui_web
(flutter/engine#41877)
2023-05-23 [email protected] Roll Skia from 3ded22186598 to
225d51031ad0 (1 revision) (flutter/engine#42246)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from Zbd3haNY2Idc to -dXJ_pnUVwmj

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the
revert to ensure that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
platform-web Code specifically for the web engine
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants