Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

gabeschine
Copy link
Contributor

@gabeschine gabeschine commented Apr 23, 2024

Delete an extra "" in CONTRIBUTING.md` in a code block.

No issues associated with this change.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@jason-simmons jason-simmons added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 26, 2024
@auto-submit auto-submit bot merged commit 4c71969 into flutter:main Apr 26, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 26, 2024
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Apr 27, 2024
…147440)

flutter/engine@c410180...bc05539

2024-04-26 [email protected] Roll Dart SDK from 9936bafe5eb1 to 919c7cab870b (1 revision) (flutter/engine#52407)
2024-04-26 [email protected] Delete errant back-tick in CONTRIBUTING.md (flutter/engine#52324)
2024-04-26 [email protected] [fuchsia] route fuchsia.sysmem2.Allocator (flutter/engine#52187)
2024-04-26 [email protected] [Impeller] clamp maximum glyph scale. (flutter/engine#52403)
2024-04-26 [email protected] Add markdown docs about RBE (flutter/engine#52394)
2024-04-26 [email protected] Roll Skia from 52083c205016 to 3401ef9641cc (5 revisions) (flutter/engine#52402)
2024-04-26 [email protected] Fix function type cast warnings for macOS embedder callbacks (flutter/engine#52377)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

autosubmit Merge PR when tree becomes green via auto submit App

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants