This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Impeller] clamp maximum glyph scale. #52403
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 25, 2024 16:24
|
Reading this code and we probably also need to clamp the glyph scale at 1. EDIT: that is a task for another day. |
added 4 commits
April 25, 2024 16:56
…e into clamp_max_glyph_size
|
Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change). If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review. |
jonahwilliams
requested review from
gaaclarke and
matanlurey
and removed request for
matanlurey
chinmaygarde
approved these changes
Apr 26, 2024
| // static | ||
| Scalar TextFrame::RoundScaledFontSize(Scalar scale, Scalar point_size) { | ||
| return std::round(scale * 100) / 100; | ||
| // An arbitrarily chosen maximum text scale to ensure that regardless of the |
jonahwilliams
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 26, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Apr 27, 2024
…147440) flutter/engine@c410180...bc05539 2024-04-26 [email protected] Roll Dart SDK from 9936bafe5eb1 to 919c7cab870b (1 revision) (flutter/engine#52407) 2024-04-26 [email protected] Delete errant back-tick in CONTRIBUTING.md (flutter/engine#52324) 2024-04-26 [email protected] [fuchsia] route fuchsia.sysmem2.Allocator (flutter/engine#52187) 2024-04-26 [email protected] [Impeller] clamp maximum glyph scale. (flutter/engine#52403) 2024-04-26 [email protected] Add markdown docs about RBE (flutter/engine#52394) 2024-04-26 [email protected] Roll Skia from 52083c205016 to 3401ef9641cc (5 revisions) (flutter/engine#52402) 2024-04-26 [email protected] Fix function type cast warnings for macOS embedder callbacks (flutter/engine#52377) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Workaround for flutter/flutter#136112
If the glyph scale is too large, say in the hundreds or thousands, then glyph itself will likely be too big to fit in the atlas. Instead of failing to render - clamp the scale (not the size, which is bounds * scale) to a much lower scaling parameter.