Add markdown docs about RBE #52394
Add markdown docs about RBE #52394
Conversation
…147440) flutter/engine@c410180...bc05539 2024-04-26 [email protected] Roll Dart SDK from 9936bafe5eb1 to 919c7cab870b (1 revision) (flutter/engine#52407) 2024-04-26 [email protected] Delete errant back-tick in CONTRIBUTING.md (flutter/engine#52324) 2024-04-26 [email protected] [fuchsia] route fuchsia.sysmem2.Allocator (flutter/engine#52187) 2024-04-26 [email protected] [Impeller] clamp maximum glyph scale. (flutter/engine#52403) 2024-04-26 [email protected] Add markdown docs about RBE (flutter/engine#52394) 2024-04-26 [email protected] Roll Skia from 52083c205016 to 3401ef9641cc (5 revisions) (flutter/engine#52402) 2024-04-26 [email protected] Fix function type cast warnings for macOS embedder callbacks (flutter/engine#52377) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
| ## Getting started | ||
|
|
||
| The first step is to add an entry to the `.gclient` file. The entry to add is | ||
| `"use_rbe": True` in the `custom_vars` section. It should look like this: |
There was a problem hiding this comment.
Drive by comment, as I'm following these docs at the moment (because my understanding is goma no longer works?)
What should it look like? Should there be more after :
There was a problem hiding this comment.
Maybe like
solutions = [
{
"managed": False,
"name": "src/flutter",
"url": "[email protected]:gmackall/engine.git",
"custom_deps": {},
"deps_file": "DEPS",
"safesync_url": "",
"custom_vars": {
"use_rbe": True,
},
},
]
|
|
||
| After making this edit, you must be authenticated as a Googler by CIPD so that | ||
| the RBE configurations can be downloaded from the `flutter_internal` | ||
| [CIPD bucket](https://chrome-infra-packages.appspot.com/p/flutter_internal): |
There was a problem hiding this comment.
Should this be https://chrome-infra-packages.appspot.com/p/infra_internal? The linked bucket doesn't exist
There was a problem hiding this comment.
The link should show up after authenticating with CIPD, I think.
| `PATH` environment variable. Alternatively, you can get the gcloud SDK on your | ||
| path by installing it on your system by following the instructions at | ||
| [https://cloud.google.com/sdk/docs/install] | ||
| (https://cloud.google.com/sdk/docs/install). |
There was a problem hiding this comment.
I think this line break is preventing the link from working properly, but also I think it would still show up as a link without the markdown formatting.
|
|
||
| On macOS, before running the `gcloud` command ensure that `python3` is on your | ||
| path, and does not come from e.g. homebrew. The command `which python3` should | ||
| return `/usr/bin/python3`. |
There was a problem hiding this comment.
I think more documentation would be helpful here, after talking to @johnmccutchan what I ended up doing was gcloud init followed by selecting my @google account, followed by entering a project id that John shared with me (Not putting here because I don't know if its a problem to list it externally, but if not we should probably also add that here?)
Hopefully that is correct?
There was a problem hiding this comment.
Thanks for catching this. I messed up my initial import of the markdown, but I think I have everything corrected except for the links in #52442.
3 participants
No description provided.