Skip to content

[all] Update UIViewControllerBasedStatusBarAppearance to true #4225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 19, 2023
Merged

[all] Update UIViewControllerBasedStatusBarAppearance to true #4225

merged 2 commits into from
Jun 19, 2023

Conversation

cyanglaz
Copy link
Contributor

Now that we support UIViewControllerBasedStatusBar by default (after engine roll: flutter/flutter@c716776), we should make this value to be true.

Part of flutter/flutter#128969

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@cyanglaz cyanglaz removed the request for review from domesticmouse June 15, 2023 20:35
@cyanglaz cyanglaz removed the request for review from Hixie June 15, 2023 20:35
@cyanglaz cyanglaz removed the request for review from goderbauer June 15, 2023 20:35
@cyanglaz cyanglaz removed the request for review from tarrinneal June 15, 2023 20:35
@hellohuanlin
Copy link
Contributor

can you explain more about this flag and the future plan (if any)?

@stuartmorgan-g
Copy link
Contributor

What effect does this have prior to your PR landing (e.g., if someone runs the examples on stable)?

@cyanglaz
Copy link
Contributor Author

What effect does this have prior to your PR landing (e.g., if someone runs the examples on stable)?

Actually, the status bar hide feature won't work on stable. I think we can still migrate now in this repository because I don't see any tests are using this feature. It is easy to forget if we wait until the feature lands on stable.

@cyanglaz
Copy link
Contributor Author

can you explain more about this flag and the future plan (if any)?

The flag is to enable ViewControllerBased status bar styling API. The UIApplication based APIs are deprecated in iOS 9. The default value of this flag is true, meaning if info.plist does not have this flag, the value is true.

To disable ViewControllerBased status bar styling, the app needs to explicitly declare this flag in info.plist and set it to false.

Flutter app explicitly declared the flag to be false and used deprecated UIApplication APIs due to historical reasons that I'm not entirely sure but I think it is safe to flip the flag now.

There are no future plans. The project is done once the flag is flipped. The only thing I'd say is that we need to monitor to see if there are new related issues filed.

@hellohuanlin
Copy link
Contributor

does a new xcode project contain this flag? should we just remove this flag?

@cyanglaz
Copy link
Contributor Author

does a new xcode project contain this flag? should we just remove this flag?

New project does not have this flag. Yeah, removing is the same as making it to true.

stuartmorgan-g
stuartmorgan-g approved these changes Jun 16, 2023
View reviewed changes
Copy link
Contributor

@stuartmorgan-g stuartmorgan-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, although it seems like removing it might be preferable so we're not keeping cruft in the plist forever. Either way is fine though.

@cyanglaz
Copy link
Contributor Author

LGTM, although it seems like removing it might be preferable so we're not keeping cruft in the plist forever. Either way is fine though.

Updated to removing the flags

@stuartmorgan-g stuartmorgan-g added the override: no changelog needed Override the check requiring CHANGELOG updates for most changes label Jun 17, 2023
@stuartmorgan-g
Copy link
Contributor

Overriding changelog: this change isn't interesting to plugin clients.

@cyanglaz cyanglaz added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 19, 2023
@auto-submit auto-submit bot merged commit 6e1918f into flutter:main Jun 19, 2023
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 19, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 19, 2023
@engine-flutter-autoroll
6e1918f [all] Update UIViewControllerBasedStatusBarAppearance to true (…
9ac9779 
…flutter/packages#4225)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 19, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 19, 2023
@engine-flutter-autoroll
6e1918f [all] Update UIViewControllerBasedStatusBarAppearance to true (…
54df9e4 
…flutter/packages#4225)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 20, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 20, 2023
@engine-flutter-autoroll
6e1918f [all] Update UIViewControllerBasedStatusBarAppearance to true (…
63cddb8 
…flutter/packages#4225)
fluttermirroringbot pushed a commit to flutter/flutter that referenced this pull request Jun 20, 2023
@engine-flutter-autoroll
Roll Packages from 59d93d6 to 6e1918f (6 revisions) (#129176)
ca6f08a 
flutter/packages@59d93d6...6e1918f

2023-06-19 [email protected] [all] Update UIViewControllerBasedStatusBarAppearance to true (flutter/packages#4225)
2023-06-17 [email protected] Add missing ignores for `textScaleFactor` deprecation (flutter/packages#4239)
2023-06-17 [email protected] [url_launcher] Remove deprecated onPlatformMessage calls (flutter/packages#4233)
2023-06-17 [email protected] [ci] Add LUCI version of build-all for web (flutter/packages#4232)
2023-06-16 [email protected] [ci] Introduce LUCI version of Linux build-all-packages tests (flutter/packages#4229)
2023-06-16 [email protected] Roll Flutter from b0188cd to fc8856e (14 revisions) (flutter/packages#4231)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
This was referenced Jul 7, 2023
Merged
Closed
Merged
@reidbaker reidbaker mentioned this pull request Jul 26, 2023
Merged
11 tasks
@reidbaker reidbaker mentioned this pull request Aug 4, 2023
Merged
11 tasks
amake added a commit to amake/orgro that referenced this pull request Aug 11, 2023
@amake
Remove UIViewControllerBasedStatusBar
36ad8ae 
See flutter/packages#4225
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stuartmorgan-g stuartmorgan-g stuartmorgan-g approved these changes

@hellohuanlin hellohuanlin hellohuanlin approved these changes

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App override: no changelog needed Override the check requiring CHANGELOG updates for most changes p: animations p: camera p: dynamic_layouts The dynamic_layouts package p: extension_google_sign_in_as_googleapis_auth p: file_selector p: flutter_adaptive_scaffold p: flutter_markdown p: go_router p: google_maps_flutter p: google_sign_in p: image_picker p: in_app_purchase p: ios_platform_images p: local_auth p: palette_generator p: path_provider p: pigeon p: quick_actions p: rfw Remote Flutter Widgets p: shared_preferences p: url_launcher p: video_player p: webview_flutter platform-ios
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cyanglaz @hellohuanlin @stuartmorgan-g