Skip to content

Add missing ignores for textScaleFactor deprecation #4239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 17, 2023

Conversation

LongCatIsLooong
Copy link
Contributor

#4209 missed a few deprecations since it was reformatted and the "ignore" was placed on the incorrect lines.

Now dart analyze --fatal-infos says no issues found.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@LongCatIsLooong LongCatIsLooong added override: no versioning needed Override the check requiring version bumps for most changes override: no changelog needed Override the check requiring CHANGELOG updates for most changes labels Jun 17, 2023
@domesticmouse
Copy link
Contributor

No idea why Cirrus CI is upset.

@LongCatIsLooong
Copy link
Contributor Author

It seems to be upset over the formatting. Should be fixed now. Thanks for the quick review!

@LongCatIsLooong LongCatIsLooong added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 17, 2023
@auto-submit auto-submit bot merged commit 5933993 into flutter:main Jun 17, 2023
@LongCatIsLooong LongCatIsLooong deleted the fix-missing-ignores branch June 17, 2023 03:45
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 19, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 19, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 19, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 20, 2023
fluttermirroringbot pushed a commit to flutter/flutter that referenced this pull request Jun 20, 2023
flutter/packages@59d93d6...6e1918f

2023-06-19 [email protected] [all] Update UIViewControllerBasedStatusBarAppearance to true (flutter/packages#4225)
2023-06-17 [email protected] Add missing ignores for `textScaleFactor` deprecation (flutter/packages#4239)
2023-06-17 [email protected] [url_launcher] Remove deprecated onPlatformMessage calls (flutter/packages#4233)
2023-06-17 [email protected] [ci] Add LUCI version of build-all for web (flutter/packages#4232)
2023-06-16 [email protected] [ci] Introduce LUCI version of Linux build-all-packages tests (flutter/packages#4229)
2023-06-16 [email protected] Roll Flutter from b0188cd to fc8856e (14 revisions) (flutter/packages#4231)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosubmit Merge PR when tree becomes green via auto submit App override: no changelog needed Override the check requiring CHANGELOG updates for most changes override: no versioning needed Override the check requiring version bumps for most changes p: flutter_markdown
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants