Add missing ignores for textScaleFactor deprecation
#4239
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LongCatIsLooong
force-pushed
the
fix-missing-ignores
branch
from
3213ce4 to
4b867bb
Compare
domesticmouse
approved these changes
Jun 17, 2023
LongCatIsLooong
added
override: no versioning needed
|
No idea why Cirrus CI is upset. |
|
It seems to be upset over the formatting. Should be fixed now. Thanks for the quick review! |
LongCatIsLooong
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 19, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 19, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 19, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 20, 2023
fluttermirroringbot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jun 20, 2023
flutter/packages@59d93d6...6e1918f 2023-06-19 [email protected] [all] Update UIViewControllerBasedStatusBarAppearance to true (flutter/packages#4225) 2023-06-17 [email protected] Add missing ignores for `textScaleFactor` deprecation (flutter/packages#4239) 2023-06-17 [email protected] [url_launcher] Remove deprecated onPlatformMessage calls (flutter/packages#4233) 2023-06-17 [email protected] [ci] Add LUCI version of build-all for web (flutter/packages#4232) 2023-06-16 [email protected] [ci] Introduce LUCI version of Linux build-all-packages tests (flutter/packages#4229) 2023-06-16 [email protected] Roll Flutter from b0188cd to fc8856e (14 revisions) (flutter/packages#4231) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
This was referenced Jul 7, 2023
11 tasks
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#4209 missed a few deprecations since it was reformatted and the "ignore" was placed on the incorrect lines.
Now
dart analyze --fatal-infossays no issues found.Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.