[url_launcher] Remove deprecated onPlatformMessage calls #4233
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 16, 2023
goderbauer
added
the
autosubmit
auto-submit
bot
removed
the
autosubmit
|
auto label is removed for flutter/packages, pr: 4233, Failed to merge flutter/packages/4233 with Pull request could not be merged: Required status check "ci.yaml validation" is expected.. |
goderbauer
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 19, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 19, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 19, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 20, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jun 20, 2023
flutter/packages@59d93d6...6e1918f 2023-06-19 [email protected] [all] Update UIViewControllerBasedStatusBarAppearance to true (flutter/packages#4225) 2023-06-17 [email protected] Add missing ignores for `textScaleFactor` deprecation (flutter/packages#4239) 2023-06-17 [email protected] [url_launcher] Remove deprecated onPlatformMessage calls (flutter/packages#4233) 2023-06-17 [email protected] [ci] Add LUCI version of build-all for web (flutter/packages#4232) 2023-06-16 [email protected] [ci] Introduce LUCI version of Linux build-all-packages tests (flutter/packages#4229) 2023-06-16 [email protected] Roll Flutter from b0188cd to fc8856e (14 revisions) (flutter/packages#4231) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
auto-submit bot
pushed a commit
to flutter/engine
that referenced
this pull request
Jun 20, 2023
This reverts commit aefe104. This is a straight reland without any additional changes. The package that was still using the outdated API causing the original revert has been updated in flutter/packages#4233. **Do not land this until that PR has rolled into the framework.**
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
This was referenced Jul 7, 2023
11 tasks
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The framework has been fully migrated to ChannelBuffers about 2 years ago, meaning all Flutter versions supported by this package (>=3.3.0) only use ChannelBuffers and not the old
onPlatformMessagecall. Therefore, the old calls can now just be removed.(This surfaced because we only remembered just now to deprecate the old long unused API.)