-
Notifications
You must be signed in to change notification settings - Fork 3.3k
[video_player] Unfork publish: for macOS #5578
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[video_player] Unfork publish: for macOS #5578
Conversation
Now that `publish:` is avaiable for macOS on 3.16, remove the forking that compiled that call out for macOS. Fixes flutter/flutter#135320
@@ -110,12 +110,12 @@ | |||
/* End PBXFrameworksBuildPhase section */ | |||
|
|||
/* Begin PBXGroup section */ | |||
331C80D6294CF71000263BE5 /* RunnerTests */ = { | |||
330B3F8E2B1F9C6A00E6DC3F /* RunnerTests */ = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes in the project file are because RunnerTests was a folder rather than a group, but the folder doesn't actually exist (since the tests are in the darwin/
shared directory instead) which was causing issues in the Xcode UI.
@@ -1,3 +1,7 @@ | |||
## 2.5.3 | |||
|
|||
* Publishes an instance of the plugin to the registrar on macOS, as on iOS. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
im curious who is currently using this instance on iOS
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably nobody (although in practice it could be anyone, in code we don't control). I expect the reason the publish call exists is because of the (deeply unfortunate, IMO, and I want to revisit this API at some point) fact that the only way to get this engine shutdown call is to publish an instance of yourself.
(This PR isn't because we need the publish functionality on macOS, but because I want to minimize forking.)
I'll need to land #4962 first and then sync this PR, to pick up the |
flutter/packages@ca16173...15584a3 2023-12-07 [email protected] [gis_web] Migrate to package:web. (flutter/packages#5581) 2023-12-07 [email protected] Drop quiver usage in several packages (flutter/packages#5595) 2023-12-07 [email protected] [video_player] Unfork publish: for macOS (flutter/packages#5578) 2023-12-07 [email protected] [web_benchmarks] migrate to pkg:web (flutter/packages#5592) 2023-12-07 [email protected] [animations] Bump minimum supported Dart version to 3.2 (flutter/packages#5598) 2023-12-06 [email protected] [animations] Bump minimum Flutter version (flutter/packages#5596) 2023-12-06 [email protected] Migrate Material curves to new names (flutter/packages#4898) 2023-12-06 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[pointer_interceptor] Add ios implementation and move web implementation to federated structure" (flutter/packages#5591) 2023-12-06 [email protected] [pointer_interceptor] Add ios implementation and move web implementation to federated structure (flutter/packages#5500) 2023-12-06 [email protected] [pigeon] Use dart:io output inheritance for tooling (flutter/packages#5536) 2023-12-06 [email protected] Fix benchmark reload bug and migrate away from deprecated `js_util` APIs (flutter/packages#5577) 2023-12-06 [email protected] [google_sign_in] Add macOS support (flutter/packages#4962) 2023-12-06 [email protected] [rfw,flutter_markdown] Apparently you need a comma to end an //ignore (flutter/packages#5582) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Now that `publish:` is avaiable for macOS on 3.16, remove the forking that compiled that call out for macOS. Fixes flutter/flutter#135320
Now that `publish:` is avaiable for macOS on 3.16, remove the forking that compiled that call out for macOS. Fixes flutter/flutter#135320
Now that
publish:
is avaiable for macOS on 3.16, remove the forking that compiled that call out for macOS.Fixes flutter/flutter#135320
Pre-launch Checklist
dart format
.)[shared_preferences]
pubspec.yaml
with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.md
to add a description of the change, following repository CHANGELOG style.///
).