-
Notifications
You must be signed in to change notification settings - Fork 3.3k
[animations] Bump minimum Flutter version #5596
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Should apply the land on red to fix the tree
(or similarly named label :P)
CI is complaining about the sdk also needing an update to 3.2.0 (which is the one that shipped with flutter) and the animations package needing a version/changelog update (I agree this should be published, otherwise people can end up with inconsistent package setups!) |
Bumps minimum supported Dart version to 3.2 to fix CI issues with #5596. Also adds CHANGELOG entry I missed before :/
Please revert rather than fixing forward in the future; the way this was done, we now have a situation where the animation package can only be published manually, and with a confusing situation where the published version would not be the commit that actually bumped the version (unlike every other publish event). I would strongly suggest doing a PR that reverts this and the original, and then landing a new PR that is a single fix, so that auto-publish can run as normal. |
Never mind, I see #5598 now. So it's resolved for now, but I would still much prefer a revert in this kind of situation next time. |
flutter/packages@ca16173...15584a3 2023-12-07 [email protected] [gis_web] Migrate to package:web. (flutter/packages#5581) 2023-12-07 [email protected] Drop quiver usage in several packages (flutter/packages#5595) 2023-12-07 [email protected] [video_player] Unfork publish: for macOS (flutter/packages#5578) 2023-12-07 [email protected] [web_benchmarks] migrate to pkg:web (flutter/packages#5592) 2023-12-07 [email protected] [animations] Bump minimum supported Dart version to 3.2 (flutter/packages#5598) 2023-12-06 [email protected] [animations] Bump minimum Flutter version (flutter/packages#5596) 2023-12-06 [email protected] Migrate Material curves to new names (flutter/packages#4898) 2023-12-06 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[pointer_interceptor] Add ios implementation and move web implementation to federated structure" (flutter/packages#5591) 2023-12-06 [email protected] [pointer_interceptor] Add ios implementation and move web implementation to federated structure (flutter/packages#5500) 2023-12-06 [email protected] [pigeon] Use dart:io output inheritance for tooling (flutter/packages#5536) 2023-12-06 [email protected] Fix benchmark reload bug and migrate away from deprecated `js_util` APIs (flutter/packages#5577) 2023-12-06 [email protected] [google_sign_in] Add macOS support (flutter/packages#4962) 2023-12-06 [email protected] [rfw,flutter_markdown] Apparently you need a comma to end an //ignore (flutter/packages#5582) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bumps minimum Fluter version to fix flutter#4898 (comment).
Bumps minimum supported Dart version to 3.2 to fix CI issues with flutter#5596. Also adds CHANGELOG entry I missed before :/
Bumps minimum Fluter version to fix flutter#4898 (comment).
Bumps minimum supported Dart version to 3.2 to fix CI issues with flutter#5596. Also adds CHANGELOG entry I missed before :/
Bumps minimum Fluter version to fix #4898 (comment).
Pre-launch Checklist
dart format
.)[shared_preferences]
pubspec.yaml
with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.md
to add a description of the change, following repository CHANGELOG style.///
).