Feature/path interpolation simple #284
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This has now been replaced with `which` which is also platform agnostic. The only difference is that `which` does not cache the result of the query. However, realistically speaking calling which once per new file being opened is a trivial cost. Moreover, already opened files are cached automatically so no `which` calls are made when changing between opened files.
We now prompt the user to install fortran-language-server and Fortran IntelliSense if the packages are missing. There is a slight issue with the calls being asynchronous, so if they are installed in the wrong order Fortran IntelliSense first and then fortls an error is being throw.
Adds support for `findent` and `fprettify`. Fixes #29.
Fixes Rename fortran_fixed-form to FortranFixedForm #259
Fixes Extension does not activate for FixedForm #257
Fixes Linting does not work for fixed format files #258
Create the tag once this is merged to master
1. Fixes conditional trigger for linting 2. Moves which as a dependency 3. Adds logging output for when parts of the extension are enabled
The includePaths and linterExtraArgs are interpolated for VSCode internal variables. Furthermore, the includePaths is then passed through glob-fast to epxand any and all glob expressions. glob-fast will only look for directories and not files.
Also updates the tests to use strictEqual Adds production, test and dev tscofig compilation
This has now been replaced with `which` which is also platform agnostic. The only difference is that `which` does not cache the result of the query. However, realistically speaking calling which once per new file being opened is a trivial cost. Moreover, already opened files are cached automatically so no `which` calls are made when changing between opened files.
We now prompt the user to install fortran-language-server and Fortran IntelliSense if the packages are missing. There is a slight issue with the calls being asynchronous, so if they are installed in the wrong order Fortran IntelliSense first and then fortls an error is being throw.
Adds support for `findent` and `fprettify`. Fixes #29.
Fixes Rename fortran_fixed-form to FortranFixedForm #259
Fixes Extension does not activate for FixedForm #257
Fixes Linting does not work for fixed format files #258
1. Fixes conditional trigger for linting 2. Moves which as a dependency 3. Adds logging output for when parts of the extension are enabled
The replace occurs at the top of the cyclical cache
When the read permissions are missing from a directory, `fast-glob` throws a EACCES error and if you try and suppress it, it ends up with a race condition. This is most likely a bug and I have opened an issue. In the meantime, we are using `glob` which is noticeably slower to recover.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an alternative to #238 where instead of overloading the .get function we simply do search and replace.
There is an issue with
fast-globand how it fails when there is lack of read access in a repo. I open a ticket on the repo but in the meantime I have implemented a relatively robust solution which is iffast-globfails we revert to usingglobwhich is noticeably slower but can handle the intricacies with different read permissions.