feat(ui): Render errored threads in issue details #15516
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This still requires an acceptance test, which @marandaneto is helping me to create right now. |
|
Store normalization at the moment still deletes the |
bruno-garcia
approved these changes
Nov 8, 2019
src/sentry/static/sentry/app/components/events/interfaces/threads.jsx
Outdated
Show resolved
Hide resolved
billyvg
reviewed
Nov 8, 2019
src/sentry/static/sentry/app/components/events/interfaces/threads.jsx
Outdated
Show resolved
Hide resolved
src/sentry/static/sentry/app/components/events/interfaces/threads.jsx
Outdated
Show resolved
Hide resolved
* master: (59 commits) fix(btn-group-break): quick fix for issues table nav items (#15585) feat(ui): Change `<SmartSearchBar>` to simulate "search" on En… (#15345) ref: Update semaphore to 0.4.61 (#15574) fix(api): Fix failing snuba test in Django 1.9 chore(ts): convert sentry app component files (#15575) build(github-actions): RIP github actions (#15577) feat(ui): Adapt user-feedback page to lightweight organization context (#15551) ref(logo replacement): converted pngs to svgs (#15552) Remove unused animated-ellipsis (#15515) fix: Fix `get_participants` to use `__in` correctly. build(webpack): Remove `lodash-webpack-plugin` (#15521) moved the bulk of plugins from test_only_plugins into new_sentry_plugins (#15468) ref: Remove "store.save-event-skips-nodestore" option from code (#15568) logging(app-context): adds more logging context for slack api errors (#15557) build(babel): Remove `@babel/polyfill` (#15564) chore(ts): convert sentryApps (#15565) chore(ts): convert SentryAppIcon (#15569) fix: Avoid updating with None (#15549) feat(api): Project key creation rate limit params (#15366) fix(api): Fix failing snuba test in Django 1.9 ...
bruno-garcia
added a commit
that referenced
this pull request
Dec 12, 2019
Merged
bruno-garcia
added a commit
that referenced
this pull request
Dec 13, 2019
scefali
pushed a commit
that referenced
this pull request
Dec 23, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're introducing a new thread attribute called
errored. It indicates that a thread is the cause of an error, without having crashed the application. Formally, the UI would only handlecrashedthreads.This extends the UI to also consider threads with
errored, if there is no crashed thread. Such a thread is marked specially in the thread list, and selected by default.See getsentry/relay#306