ref(sdk): Migrate to get_isolation_scope
#93019
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
loewenheim
approved these changes
Jun 6, 2025
Migrate calls of `sentry_sdk.Scope.get_isolation_scope` to `sentry_sdk.get_isolation_scope`. Calls where `Scope` is first imported and then where `Scope.get_isolation_scope` is called are left as-is; we will address those separately. Split off from #92011.
szokeasaurusrex
force-pushed
the
szokeasaurusrex/get_isolation_scope
branch
from
4c154c8 to
e8ff8c7
Compare
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## master #93019 +/- ##
==========================================
- Coverage 87.89% 87.89% -0.01%
==========================================
Files 10294 10294
Lines 590765 590765
Branches 22974 22974
==========================================
- Hits 519230 519224 -6
- Misses 71088 71094 +6
Partials 447 447 |
sl0thentr0py
approved these changes
Jun 10, 2025
jan-auer
added a commit
that referenced
this pull request
Jun 10, 2025
* master: Revert "ref(spans): Pin redis sharding to partition index (#93209)" chore: add DemoModeGuardMiddleware logging (#92926) feat(tempest): Dynamically fetch ip addresses (#93012) fix(demo-mode): cleanup demo-mode sync options (#92918) ref(sdk): Migrate to `sentry_sdk.get_global_scope` (#93020) ref(sdk): Migrate to `get_isolation_scope` (#93019) ref(spans): Pin redis sharding to partition index (#93209)
andrewshie-sentry
pushed a commit
that referenced
this pull request
Jun 19, 2025
Migrate calls of `sentry_sdk.Scope.get_isolation_scope` to `sentry_sdk.get_isolation_scope`. Calls where `Scope` is first imported and then where `Scope.get_isolation_scope` is called are left as-is; we will address those separately. Split off from #92011. <!-- Describe your PR here. --> <!-- Sentry employees and contractors can delete or ignore the following. --> ### Legal Boilerplate Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrate calls of
sentry_sdk.Scope.get_isolation_scopetosentry_sdk.get_isolation_scope. Calls whereScopeis first imported and then whereScope.get_isolation_scopeis called are left as-is; we will address those separately.Split off from #92011.
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.