Skip to content

ref(sdk): Migrate to sentry_sdk.get_global_scope #93020

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 10, 2025

Conversation

szokeasaurusrex
Copy link
Member

Migrate calls of sentry_sdk.Scope.get_global_scope to sentry_sdk.get_global_scope.

Split off from #92011.

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Jun 6, 2025
Copy link
Member

@asottile-sentry asottile-sentry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Migrate calls of `sentry_sdk.Scope.get_isolation_scope` to `sentry_sdk.get_isolation_scope`. Calls where `Scope` is first imported and then where `Scope.get_isolation_scope` is called are left as-is; we will address those separately.

Split off from #92011.
@szokeasaurusrex szokeasaurusrex force-pushed the szokeasaurusrex/get_isolation_scope branch from 4c154c8 to e8ff8c7 Compare June 6, 2025 14:52
@szokeasaurusrex szokeasaurusrex requested review from a team as code owners June 6, 2025 14:52
Migrate calls of `sentry_sdk.Scope.get_global_scope` to `sentry_sdk.get_global_scope`.

Split off from #92011.
Base automatically changed from szokeasaurusrex/get_isolation_scope to master June 10, 2025 11:40
@szokeasaurusrex szokeasaurusrex merged commit d8a65c7 into master Jun 10, 2025
58 checks passed
@szokeasaurusrex szokeasaurusrex deleted the szokeasaurusrex/get_global_scope branch June 10, 2025 11:41
Copy link

codecov bot commented Jun 10, 2025

Codecov Report

Attention: Patch coverage is 94.44444% with 1 line in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/sentry/replays/usecases/ingest/__init__.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #93020      +/-   ##
==========================================
- Coverage   87.89%   87.89%   -0.01%     
==========================================
  Files       10294    10294              
  Lines      590765   590765              
  Branches    22974    22974              
==========================================
- Hits       519230   519225       -5     
- Misses      71088    71093       +5     
  Partials      447      447              

jan-auer added a commit that referenced this pull request Jun 10, 2025
* master:
  Revert "ref(spans): Pin redis sharding to partition index (#93209)"
  chore: add DemoModeGuardMiddleware logging (#92926)
  feat(tempest): Dynamically fetch ip addresses (#93012)
  fix(demo-mode): cleanup demo-mode sync options (#92918)
  ref(sdk): Migrate to `sentry_sdk.get_global_scope` (#93020)
  ref(sdk): Migrate to `get_isolation_scope` (#93019)
  ref(spans): Pin redis sharding to partition index (#93209)
andrewshie-sentry pushed a commit that referenced this pull request Jun 19, 2025
Migrate calls of `sentry_sdk.Scope.get_global_scope` to
`sentry_sdk.get_global_scope`.

Split off from #92011.

<!-- Describe your PR here. -->

<!--

  Sentry employees and contractors can delete or ignore the following.

-->

### Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated
in the State of Delaware in 2015 as Functional Software, Inc. and is
gonna need some rights from me in order to utilize my contributions in
this here PR. So here's the deal: I retain all rights, title and
interest in and to my contributions, and by keeping this boilerplate
intact I confirm that Sentry can use, modify, copy, and redistribute my
contributions, under Sentry's choice of terms.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants