Skip to content

Support preview Protected Branches API #974

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 14 commits into from

Conversation

gmlewis
Copy link
Collaborator

@gmlewis gmlewis commented Aug 10, 2018

Fixes #876.
Closes #934.

@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

@gmlewis
Copy link
Collaborator Author

gmlewis commented Aug 10, 2018

Actually, now that I'm looking at the final results of the merge, all the important things have been addressed, and the extra omitemptys are really not desirable anyway because these fields can't be omitted as they are not pointers.

Closing.

@gmlewis gmlewis closed this Aug 10, 2018
@gmlewis gmlewis deleted the scriptonist-Issue876 branch August 10, 2018 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants