Skip to content

#509: Component Object Pattern, #466 Monitor Object pattern, #564 Collection Pipeline Pattern #757

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 7 commits into from

Conversation

nikhilbarar
Copy link
Contributor

An implementation of Component Object Pattern using IBM Selenium.

Added a new module 'component-object'.

@nikhilbarar nikhilbarar changed the title #509: Component Object Pattern #509: Component Object Pattern#466 Monitor Object pattern Jun 12, 2018
@nikhilbarar nikhilbarar changed the title #509: Component Object Pattern#466 Monitor Object pattern #509: Component Object Pattern, #466 Monitor Object pattern Jun 12, 2018
@nikhilbarar
Copy link
Contributor Author

An implementation of Monitor Object Pattern.

Added a new module 'monitor-object'.

@nikhilbarar
Copy link
Contributor Author

Hi, requesting a review. Please let me know if any changes are required.

@npathai
Copy link
Contributor

npathai commented Jun 26, 2018

@nikhilbarar Thanks for the PR 👍 I will review it in a day or two and let you know of any changes.

@npathai npathai requested review from npathai and removed request for npathai June 26, 2018 08:07
@npathai npathai self-assigned this Jun 26, 2018
@nikhilbarar
Copy link
Contributor Author

Thanks @npathai 👍

@nikhilbarar
Copy link
Contributor Author

nikhilbarar commented Jul 1, 2018

Added an implementation of Collection Pipeline Pattern.

Added a new module 'collection-pipeline'.

@nikhilbarar nikhilbarar changed the title #509: Component Object Pattern, #466 Monitor Object pattern #509: Component Object Pattern, #466 Monitor Object pattern, #564 Collection Pipeline Pattern Jul 1, 2018
@npathai
Copy link
Contributor

npathai commented Jul 2, 2018

@nikhilbarar I suggest you to create three different branches in your clone and raise three different PRs for them. Adding stuff to single PR makes it too bulky to review in a single pass.

I took a quick look at all implementations and I doubt whether Component Object pattern can be considered a Java design pattern in current implementation. It is written in Javascript. What are your thoughts on this?

Raise three different PRs and close this one.

@nikhilbarar
Copy link
Contributor Author

Apologies for the delay and inconvenience. I've raised 3 separate pull requests #767 #768 #769 for these issues.

Component Object pattern, as per my understanding, is a testing design pattern, which helps us in creating reusable components for end to end testing. The example uses Selenium web driver to create java components representing UI components (fetched using HTML selectors through selenium libraries). It then goes on to demonstrate the reusability of these components in different JUnit test cases.

I believe the user interface can be written in any language but the component creation and their use should remain the same. The interface just helps in demonstrating the use of the pattern.
Please advise.

@npathai
Copy link
Contributor

npathai commented Jul 16, 2018

@nikhilbarar Thanks I am closing this PR and I will initiate further communication on new PRs.

@npathai npathai closed this Jul 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants