-
-
Notifications
You must be signed in to change notification settings - Fork 27k
#509: Component Object Pattern, #466 Monitor Object pattern, #564 Collection Pipeline Pattern #757
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
An implementation of Monitor Object Pattern. Added a new module 'monitor-object'. |
Hi, requesting a review. Please let me know if any changes are required. |
@nikhilbarar Thanks for the PR 👍 I will review it in a day or two and let you know of any changes. |
Thanks @npathai 👍 |
Added an implementation of Collection Pipeline Pattern. Added a new module 'collection-pipeline'. |
@nikhilbarar I suggest you to create three different branches in your clone and raise three different PRs for them. Adding stuff to single PR makes it too bulky to review in a single pass. I took a quick look at all implementations and I doubt whether Component Object pattern can be considered a Java design pattern in current implementation. It is written in Javascript. What are your thoughts on this? Raise three different PRs and close this one. |
Apologies for the delay and inconvenience. I've raised 3 separate pull requests #767 #768 #769 for these issues. Component Object pattern, as per my understanding, is a testing design pattern, which helps us in creating reusable components for end to end testing. The example uses Selenium web driver to create java components representing UI components (fetched using HTML selectors through selenium libraries). It then goes on to demonstrate the reusability of these components in different JUnit test cases. I believe the user interface can be written in any language but the component creation and their use should remain the same. The interface just helps in demonstrating the use of the pattern. |
…erns # Conflicts: # pom.xml
@nikhilbarar Thanks I am closing this PR and I will initiate further communication on new PRs. |
An implementation of Component Object Pattern using IBM Selenium.
Added a new module 'component-object'.