Skip to content

#466: Monitor object #768

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 18 commits into from
Closed

Conversation

nikhilbarar
Copy link
Contributor

An implementation of Monitor Object Pattern.

Added a new module 'monitor-object'.

@iluwatar
Copy link
Owner

iluwatar commented Aug 1, 2018

@nikhilbarar the PR has conflicts that should be resolved

@iluwatar
Copy link
Owner

@nikhilbarar please indicate if you are still working on this. Otherwise it will be closed.

@nikhilbarar
Copy link
Contributor Author

@iluwatar Yes, I'll resolve the conflicts and update

@iluwatar
Copy link
Owner

@nikhilbarar The code looks great and the tests work. By convention we have included App.java in the examples that provides a starting point for the example. In that file please provide a description what the example does so it is easy for the reader to start studying. See the other patterns for an example.

@iluwatar
Copy link
Owner

iluwatar commented Sep 2, 2018

  • Could you add little description to App.java as well so the reader can comprehend the example more quickly?
  • Can you add AppTest.java that tests that running the App.java succeeds? This is a convention used in other examples too.

@iluwatar iluwatar self-assigned this Oct 13, 2018
@npathai
Copy link
Contributor

npathai commented Oct 23, 2018

@nikhilbarar You have done great job here, any update? I don't want this PR to die 😞

@nikhilbarar
Copy link
Contributor Author

@npathai Apologies for the late response. I'm working on this and will update it in a couple of days.

@iluwatar
Copy link
Owner

This pull request is about to be closed due to inactivity

@iluwatar iluwatar closed this Jul 21, 2019
@iluwatar iluwatar added this to the 1.21.0 milestone Jul 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants