-
Notifications
You must be signed in to change notification settings - Fork 15.1k
feat: add Hugo segments #51630
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add Hugo segments #51630
Conversation
✅ Pull request preview available for checkingBuilt without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, nice work. It needs a small tweak then we can merge it.
/area web-development
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This also needs updating:
serve: module-check ## Boot the development server.
hugo server --buildDrafts --buildFuture --environment development
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
c7270c6
to
bc657d2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, now the site loads faster.
Can you update the README to include the segments usage?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm happy with this. It doesn't change the command to build the live site and the Netlify preview still includes all the active localizations.
(in other words: this PR doesn't change the content of the published site)
/LGTM
/approve
LGTM label has been added. Git tree hash: c425d8adba3990cc7e8a9835b4b63ec20de90ff5
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lmktfy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@milinddethe15 would you be willing to file an issue about updating the README? Small issues like that help new contributors to get started. |
Related issue: #51576
When I rendered the entire site, the initial execution time was 26.88 seconds, but when I limited it to Persian[fa], it was 8.69 seconds.
Since the Persian PR #51598 has not yet been approved, I have made changes to the English language in this PR.
The previous way of running still works:
To use segments, we can execute them either individually or in multiples.
individually:
multiples: