Skip to content

Conversation

xirehat
Copy link
Member

@xirehat xirehat commented Jul 17, 2025

Related issue: #51576

When I rendered the entire site, the initial execution time was 26.88 seconds, but when I limited it to Persian[fa], it was 8.69 seconds.

Since the Persian PR #51598 has not yet been approved, I have made changes to the English language in this PR.

The previous way of running still works:

make container-serve

To use segments, we can execute them either individually or in multiples.

individually:

make container-serve segments=en

multiples:

make container-serve segments=en,fa

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 17, 2025
@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Jul 17, 2025
@k8s-ci-robot k8s-ci-robot requested a review from katcosgrove July 17, 2025 12:36
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jul 17, 2025
Copy link

netlify bot commented Jul 17, 2025

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit bc657d2
🔍 Latest deploy log https://app.netlify.com/projects/kubernetes-io-main-staging/deploys/6879651a0f44920008e375a9
😎 Deploy Preview https://deploy-preview-51630--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Contributor

@lmktfy lmktfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, nice work. It needs a small tweak then we can merge it.

/area web-development

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This also needs updating:

serve: module-check ## Boot the development server.
	hugo server --buildDrafts --buildFuture --environment development

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@k8s-ci-robot k8s-ci-robot added the area/web-development Issues or PRs related to the kubernetes.io's infrastructure, design, or build processes label Jul 17, 2025
@xirehat xirehat force-pushed the kubernetes-website-hugo-segments branch from c7270c6 to bc657d2 Compare July 17, 2025 21:03
Copy link

@milinddethe15 milinddethe15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, now the site loads faster.
Can you update the README to include the segments usage?

Copy link
Contributor

@lmktfy lmktfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy with this. It doesn't change the command to build the live site and the Netlify preview still includes all the active localizations.

(in other words: this PR doesn't change the content of the published site)

/LGTM
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 18, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: c425d8adba3990cc7e8a9835b4b63ec20de90ff5

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lmktfy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 18, 2025
@k8s-ci-robot k8s-ci-robot merged commit dcf3905 into kubernetes:main Jul 18, 2025
6 checks passed
@lmktfy
Copy link
Contributor

lmktfy commented Jul 18, 2025

@milinddethe15 would you be willing to file an issue about updating the README? Small issues like that help new contributors to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/web-development Issues or PRs related to the kubernetes.io's infrastructure, design, or build processes cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants