[DNM] `starkware-development` synced with `2.x.y` #2148

gabrielbosio · 2025-07-31T18:41:16Z

No description provided.

* Add comment on proof-mode extra step * Add comment on temporary segments * Update vm/src/vm/vm_memory/memory.rs Co-authored-by: fmoletta <[email protected]> * Update vm/src/vm/vm_memory/memory.rs Co-authored-by: fmoletta <[email protected]> * Update vm/src/vm/vm_memory/memory.rs Co-authored-by: Franco Giachetta <[email protected]> --------- Co-authored-by: fmoletta <[email protected]> Co-authored-by: Franco Giachetta <[email protected]>

* Replace thiserror-no-std with thiserror 2 * Fix fuzzer using old thiserror-no-std --------- Co-authored-by: Edgar <[email protected]> Co-authored-by: Edgar Luque <[email protected]> Co-authored-by: Julian Gonzalez Calderon <[email protected]> Co-authored-by: Gabriel Bosio <[email protected]>

* fix: handle unfilled values in mul mod runner * update changelog * Move changelog entry * Remove whiteline * Add test --------- Co-authored-by: Gabriel Bosio <[email protected]> Co-authored-by: Julián González Calderón <[email protected]>

* Replace anyhow error with variants * Update changelog * Update tests * Use box to keep error enum small

* fix comment * fix comment * fix * change comment * format

…ding (#2015) * fix issues like WriteReturnFp due to the gas builtin * try fix tests and update changelog * fix test

…#[command(...)] in v4.x (#2003) * Update main.rs * Update main.rs * Update CHANGELOG.md to refactor: Clap attribute macros from #[clap(...)] to #[arg(...)] and #[command(...)] in v4.x --------- Co-authored-by: Julián González Calderón <[email protected]>

* Fix flow notation * Fix dependency

…2022)

* Add Commit Signing section * Clarify that this only affects to internal branches Co-authored-by: Julian Gonzalez Calderon <[email protected]> --------- Co-authored-by: Julian Gonzalez Calderon <[email protected]> Co-authored-by: Franco Giachetta <[email protected]>

…2023)

* Fix flow notation * Fix dependency

…2022)

* Add Commit Signing section * Clarify that this only affects to internal branches Co-authored-by: Julian Gonzalez Calderon <[email protected]> --------- Co-authored-by: Julian Gonzalez Calderon <[email protected]> Co-authored-by: Franco Giachetta <[email protected]>

…2023)

* feat: implement VirtualMachine::is_accessed Signed-off-by: Dori Medini <[email protected]> * chore: refactor, test, changelog Signed-off-by: Dori Medini <[email protected]> --------- Signed-off-by: Dori Medini <[email protected]>

* feat: add get_current_step getter Signed-off-by: Dori Medini <[email protected]> * chore: changelog Signed-off-by: Dori Medini <[email protected]> * test: add coverage Signed-off-by: Dori Medini <[email protected]> --------- Signed-off-by: Dori Medini <[email protected]>

# TITLE Cherry-pick all the commits from main Description of the pull request changes and motivation. ## Checklist - [ ] Linked to Github Issue - [ ] Unit tests added - [ ] Integration tests added. - [ ] This change requires new documentation. - [ ] Documentation has been added/updated. - [ ] CHANGELOG has been updated.

Added a label that triggers skipping of this job

# TITLE ## Description Description of the pull request changes and motivation. ## Checklist - [ ] Linked to Github Issue - [ ] Unit tests added - [ ] Integration tests added. - [ ] This change requires new documentation. - [ ] Documentation has been added/updated. - [ ] CHANGELOG has been updated.  - - - This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/lambdaclass/cairo-vm/2036)

* Bump Cairo to v2.12.0-dev.0 * Updte CHANGELOG.md * Update lock * Use as_str instead of as_ref Compiler cannot infer type with as_ref * Update entrypoint offset Changes in the compiler must have changed casm generation

Co-authored-by: Whichqua <[email protected]>

Added another flag to allow fast serialization of 'prover_input_info' into a binary file

* Remove duplicated `get_val` (#2065) * avoid installing gmp if it is already installed * revert part of the last commit * changelog * remove unwanted file * CI: Make cache keys depend on Cairo version (#2056) * Add Makefile and requirements.txt to cache key * Don't fetch cairo stwo exclusive programs * Remove empty file * Restrict caching Cairo programs Revert how the Rust workflow uses the Cairo program paths to calculate the cache keys. This change would imply the branch only adds Makefile and requirements.txt to the cache key computation. --------- Co-authored-by: gabrielbosio <[email protected]> Co-authored-by: Gabriel Bosio <[email protected]> * dev: make Memory::get `pub` (#2039) * dev: make Memory::get `pub` * edit changelog * dev: expose get_maybe_relocatable instead * add comment on borrowed variant * add tests * feat(breaking): add support for hint accessible scopes (#2042) * feat: add support for hint accessible scopes update changelog * Update vm/src/hint_processor/hint_processor_definition.rs Co-authored-by: Julian Gonzalez Calderon <[email protected]> --------- Co-authored-by: Julian Gonzalez Calderon <[email protected]> * feat: add support for alias identifiers destination in program serde (#2071) * feat: add support for aliases destination in program serde * add changelog --------- Co-authored-by: Julián González Calderón <[email protected]> * fix: Add boundary tests for SecpSplitOutOfRange in secp_utils (#2062) * fix: Add boundary tests for SecpSplitOutOfRange in secp_utils * Update secp_utils.rs * Update CHANGELOG.md * Update secp_utils.rs * remove optimizations * Update CHANGELOG.md * Update CHANGELOG.md * Update CHANGELOG.md * empty commit to fix CI --------- Co-authored-by: Julian Gonzalez Calderon <[email protected]> * docs: add --run_from_cairo_pie documentation for Cairo 0 and Cairo 1 (#2077) * docs: add --run_from_cairo_pie flag usage documentation for Cairo 0 * docs: add --run_from_cairo_pie flag usage documentation for Cairo 1 * Update README.md Co-authored-by: Julian Gonzalez Calderon <[email protected]> * Update README.md * Update README.md * Update README.md Co-authored-by: Julian Gonzalez Calderon <[email protected]> * Update README.md Co-authored-by: Gabriel Bosio <[email protected]> * Update README.md Co-authored-by: Julian Gonzalez Calderon <[email protected]> --------- Co-authored-by: Julian Gonzalez Calderon <[email protected]> Co-authored-by: Gabriel Bosio <[email protected]> * Fix WRITE_DIVMOD_SEGMENT hint (#2078) * Minor fixes - use CAIRO_PRIME * Add error handling * Update CHANGELOG.md * Bump cairo-lang to 0.13.5 (#1959) * Update cairo-lang versin * Update changelog * Add new hints * Specify prime in new hints * Only apply mod floor if prime is not CAIRO_PRIME * Properly implement pack for a different prime * Fix pack in compute_doubling_slope * Add negative_points.cairo test * Add try_get_point_from_x for negative points * Add double_x test for negative points * Allow to many arguments * Add codecov to cairo-0-secp-hints feature * Prepare for Release v3.0.0-rc.1 (#2092) * Update version * Update lock * Update toolchain * Update changelog * Fix clippy * Update toolchain in CI * fix: correct cache keys for no-std test coverage in CI (#2093) * Update rust.yml * Update rust.yml * Update rust toolchain to 1.87.0 (#2100) * update rust toolchain to 1.87.0 * remove uneeded file * update rust in workflows * update changelog * clippy * clippy * remove unneeded clippy allow * fix Changelog link (#2104) * Improve memory_segments coverage (#2110) * Add tests for .gen_arg() and .write_arg() * Add test for .is_valid_memory_value() * Assert contents of memory segments --------- Co-authored-by: Franco Giachetta <[email protected]> Co-authored-by: Julian Gonzalez Calderon <[email protected]> Co-authored-by: Mathieu <[email protected]> Co-authored-by: VolodymyrBg <[email protected]> Co-authored-by: GarmashAlex <[email protected]> Co-authored-by: crStiv <[email protected]> Co-authored-by: DiegoC <[email protected]>

This reverts commit 7269a8f.

* Update cairo-lang versin * Update changelog * Add new hints * Specify prime in new hints * Only apply mod floor if prime is not CAIRO_PRIME * Properly implement pack for a different prime * Fix pack in compute_doubling_slope * Add negative_points.cairo test * Add try_get_point_from_x for negative points * Add double_x test for negative points * Allow to many arguments * Add codecov to cairo-0-secp-hints feature Co-authored-by: Julian Gonzalez Calderon <[email protected]>

…le (#2142) * Update changelog * Pin types-rs version

github-actions · 2025-07-31T19:00:39Z

Benchmark Results for unmodified programs 🚀

Command	Mean [s]	Min [s]	Max [s]	Relative
`base big_factorial`	2.128 ± 0.012	2.118	2.152	1.00 ± 0.01
`head big_factorial`	2.128 ± 0.008	2.119	2.140	1.00

Command	Mean [s]	Min [s]	Max [s]	Relative
`base big_fibonacci`	2.056 ± 0.019	2.040	2.103	1.00 ± 0.01
`head big_fibonacci`	2.053 ± 0.021	2.033	2.106	1.00

Command	Mean [s]	Min [s]	Max [s]	Relative
`base blake2s_integration_benchmark`	7.795 ± 0.043	7.713	7.838	1.02 ± 0.01
`head blake2s_integration_benchmark`	7.616 ± 0.038	7.580	7.699	1.00

Command	Mean [s]	Min [s]	Max [s]	Relative
`base compare_arrays_200000`	2.208 ± 0.012	2.192	2.237	1.00 ± 0.01
`head compare_arrays_200000`	2.205 ± 0.011	2.194	2.230	1.00

Command	Mean [s]	Min [s]	Max [s]	Relative
`base dict_integration_benchmark`	1.432 ± 0.011	1.417	1.456	1.00
`head dict_integration_benchmark`	1.443 ± 0.012	1.431	1.468	1.01 ± 0.01

Command	Mean [s]	Min [s]	Max [s]	Relative
`base field_arithmetic_get_square_benchmark`	1.239 ± 0.005	1.232	1.250	1.01 ± 0.01
`head field_arithmetic_get_square_benchmark`	1.230 ± 0.005	1.221	1.239	1.00

Command	Mean [s]	Min [s]	Max [s]	Relative
`base integration_builtins`	7.913 ± 0.120	7.824	8.240	1.03 ± 0.02
`head integration_builtins`	7.665 ± 0.057	7.585	7.746	1.00

Command	Mean [s]	Min [s]	Max [s]	Relative
`base keccak_integration_benchmark`	8.158 ± 0.096	8.072	8.334	1.05 ± 0.01
`head keccak_integration_benchmark`	7.797 ± 0.024	7.764	7.836	1.00

Command	Mean [s]	Min [s]	Max [s]	Relative
`base linear_search`	2.175 ± 0.007	2.162	2.185	1.00 ± 0.01
`head linear_search`	2.165 ± 0.009	2.154	2.176	1.00

Command	Mean [s]	Min [s]	Max [s]	Relative
`base math_cmp_and_pow_integration_benchmark`	1.515 ± 0.007	1.506	1.525	1.00 ± 0.01
`head math_cmp_and_pow_integration_benchmark`	1.513 ± 0.014	1.502	1.550	1.00

Command	Mean [s]	Min [s]	Max [s]	Relative
`base math_integration_benchmark`	1.465 ± 0.006	1.452	1.475	1.00 ± 0.01
`head math_integration_benchmark`	1.465 ± 0.012	1.451	1.496	1.00

Command	Mean [s]	Min [s]	Max [s]	Relative
`base memory_integration_benchmark`	1.222 ± 0.006	1.211	1.232	1.00 ± 0.01
`head memory_integration_benchmark`	1.220 ± 0.016	1.210	1.254	1.00

Command	Mean [s]	Min [s]	Max [s]	Relative
`base operations_with_data_structures_benchmarks`	1.580 ± 0.007	1.569	1.590	1.02 ± 0.01
`head operations_with_data_structures_benchmarks`	1.549 ± 0.019	1.533	1.602	1.00

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`base pedersen`	531.5 ± 1.6	528.7	533.8	1.00 ± 0.01
`head pedersen`	531.0 ± 2.8	526.7	536.3	1.00

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`base poseidon_integration_benchmark`	629.6 ± 4.2	622.1	634.9	1.03 ± 0.01
`head poseidon_integration_benchmark`	608.8 ± 2.2	605.3	612.6	1.00

Command	Mean [s]	Min [s]	Max [s]	Relative
`base secp_integration_benchmark`	1.833 ± 0.011	1.820	1.853	1.01 ± 0.01
`head secp_integration_benchmark`	1.810 ± 0.009	1.796	1.825	1.00

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`base set_integration_benchmark`	629.6 ± 1.9	627.6	633.3	1.00 ± 0.01
`head set_integration_benchmark`	629.4 ± 3.4	625.8	637.9	1.00

Command	Mean [s]	Min [s]	Max [s]	Relative
`base uint256_integration_benchmark`	4.339 ± 0.019	4.311	4.376	1.01 ± 0.01
`head uint256_integration_benchmark`	4.295 ± 0.028	4.258	4.357	1.00

codecov · 2025-07-31T19:07:56Z

Codecov Report

❌ Patch coverage is 96.13821% with 19 lines in your changes missing coverage. Please review.
✅ Project coverage is 96.66%. Comparing base (08edc6f) to head (7f124f7).

Files with missing lines	Patch %	Lines
vm/src/vm/vm_core.rs	87.50%	7 Missing ⚠️
vm/src/cairo_run.rs	76.19%	5 Missing ⚠️
vm/src/vm/runners/cairo_runner.rs	97.05%	4 Missing ⚠️
cairo-vm-cli/src/main.rs	82.35%	3 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff            @@
##            2.x.y    #2148    +/-   ##
========================================
  Coverage   96.66%   96.66%            
========================================
  Files         103      104     +1     
  Lines       43645    44068   +423     
========================================
+ Hits        42190    42599   +409     
- Misses       1455     1469    +14

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

JulianGCalderon and others added 30 commits March 17, 2025 15:05

stav: extract information for the prover from the runner (#2001)

c87b23d

Replace security anyhow errors with enum variants (#1946)

7dde1c6

* Replace anyhow error with variants * Update changelog * Update tests * Use box to keep error enum small

Fix comment in initialize_builtins() (#2005)

2723e6f

* fix comment * fix comment * fix * change comment * format

Removed CODEOWNERS file (#2018)

04e5e8d

Fix CantWriteReturnFp and other issues related to the initial gas loa…

5307101

…ding (#2015) * fix issues like WriteReturnFp due to the gas builtin * try fix tests and update changelog * fix test

Add starkware-development to CI (like another main) (#2025)

957f7f1

Keep None memory cells for the prover input info (#2021)

f8e3a82

CI: Fix cache not found error (#2026)

7c4ecdf

* Fix flow notation * Fix dependency

Remove dependancy in cairo pie when collectiog builtin segments info (#…

63fa1b7

…2022)

use btreemap instead of hashmap for deterministic iteration order. (#…

60e6f24

…2023)

Add starkware-development to CI (like another main) (#2025)

106e5f8

Keep None memory cells for the prover input info (#2021)

ce73503

CI: Fix cache not found error (#2026)

05fb44f

* Fix flow notation * Fix dependency

Remove dependancy in cairo pie when collectiog builtin segments info (#…

bdd75dd

…2022)

use btreemap instead of hashmap for deterministic iteration order. (#…

92e3188

…2023)

feat: implement VirtualMachine::is_accessed (#2033)

7b9e1c5

* feat: implement VirtualMachine::is_accessed Signed-off-by: Dori Medini <[email protected]> * chore: refactor, test, changelog Signed-off-by: Dori Medini <[email protected]> --------- Signed-off-by: Dori Medini <[email protected]>

Update changelog.yml (#2037)

82e465b

Added a label that triggers skipping of this job

fill holes is builtins segments

2137db8

Bump Cairo to v2.12.0-dev.0 (#2040)

368e3fb

* Bump Cairo to v2.12.0-dev.0 * Updte CHANGELOG.md * Update lock * Use as_str instead of as_ref Compiler cannot infer type with as_ref * Update entrypoint offset Changes in the compiler must have changed casm generation

fix: Always use a normal segment in first SegmentArena segment (#1845)

0038711

Co-authored-by: Whichqua <[email protected]>

fill holes is builtins segments

6dfd853

YairVaknin-starkware and others added 23 commits April 14, 2025 22:00

Fix_zero_offset_output_base_assumption (#2068)

9c44e1c

add flag to serialize prover input info into binary files

58174f3

use bincode for faster writing prover input info (#2074)

33d75ca

Added another flag to allow fast serialization of 'prover_input_info' into a binary file

Use_btreemap_for_deterministic_order_of_pie_keys (#2085)

dc1c49b

[BREAKING] Compute_missing_builtin_cells_only_in_proof_mode (#2088)

b1a91f9

move prover input info to a new seperate file (#2079)

a5b3c9d

add trace not enabled error

547dca1

add trace not enabled error (#2080)

da5dffd

add test to filling holes (#2087)

627c1ac

memory comparision test only for non proof mode cases

41486b5

Stav/remove test compare to python vm (#2086)

b818326

Revert "Sync with main (#2116)" (#2117)

870fd60

This reverts commit 7269a8f.

Enable_using_secure_run_in_proof_mode (#2113)

15de4b2

take ownershop instad of clone

9277002

Stav/remove clone trace (#2127)

b85e5c6

Fixed bad submodule (#2131)

4226352

Added support for large files in PIE (#2136)

b6c2f5a

[starkware-development] Pin types-rs version to the one set in lockfi…

df70ca8

…le (#2142) * Update changelog * Pin types-rs version

Include_output_builtin_in_prover_input_info (#2138)

00406f0

add relocate trace flag to the runner

9d2256f

Stav/disable relocate trace with flag (#2133)

1a224f8

gabrielbosio force-pushed the starkware-development-sync-2.x.y branch from c878460 to b06518a Compare July 31, 2025 18:42

gabrielbosio force-pushed the starkware-development-sync-2.x.y branch from b06518a to 4a6f373 Compare July 31, 2025 19:12

Merge branch '2.x.y' into starkware-development-sync-2.x.y

7f124f7

gabrielbosio force-pushed the starkware-development-sync-2.x.y branch from 4a6f373 to 7f124f7 Compare August 1, 2025 13:53

gabrielbosio closed this Aug 6, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[DNM] `starkware-development` synced with `2.x.y` #2148

[DNM] `starkware-development` synced with `2.x.y` #2148

Uh oh!

gabrielbosio commented Jul 31, 2025

Uh oh!

github-actions bot commented Jul 31, 2025 •

edited

Loading

Uh oh!

codecov bot commented Jul 31, 2025 •

edited

Loading

Uh oh!

Uh oh!

[DNM] starkware-development synced with 2.x.y #2148

[DNM] starkware-development synced with 2.x.y #2148

Uh oh!

Conversation

gabrielbosio commented Jul 31, 2025

Uh oh!

github-actions bot commented Jul 31, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov bot commented Jul 31, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

[DNM] `starkware-development` synced with `2.x.y` #2148

[DNM] `starkware-development` synced with `2.x.y` #2148

github-actions bot commented Jul 31, 2025 •

edited

Loading

codecov bot commented Jul 31, 2025 •

edited

Loading