Skip to content

Expressions #1032

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 27 commits into from
Jan 31, 2023
Merged

Expressions #1032

merged 27 commits into from
Jan 31, 2023

Conversation

katcharov
Copy link
Collaborator

JAVA-3879

Tracking PR.

This PR may be used to track anything that needs to be done prior to this expressions branch being merged into master.

stIncMale
stIncMale reviewed Nov 3, 2022
View reviewed changes
Copy link
Member

@stIncMale stIncMale left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

stIncMale
stIncMale reviewed Nov 3, 2022
View reviewed changes
@katcharov katcharov mentioned this pull request Nov 14, 2022
Merged
@katcharov katcharov mentioned this pull request Nov 22, 2022
Merged
@katcharov katcharov mentioned this pull request Nov 28, 2022
Merged
katcharov
katcharov commented Dec 8, 2022
View reviewed changes
driver-core/src/main/com/mongodb/client/model/expressions/BooleanExpression.java Outdated
* @return left if true, right if false.
* @param <T> The type of the resulting expression.
*/
<T extends Expression> T cond(T left, T right);
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

one.eq(of(2)).cond(of("yes"), of("no"));

The present variant of cond does not supply the original value to the left and right branches. Above, the value is one, but it could be a long composite expression. This is inconvenient. (It also fails to imply that the not-taken branch will not be evaluated, since there is no lambda; this problem is also present in and and or.)

one.condNumber(v -> v.eq(of(2)), v -> of("yes"), v -> of("no"));

This alternative has two problems. First, it is always verbose. Second, because there is no self type, distinct variations must be provided for each type, which makes the name confusing (ifNumber sounds like a typecheck).

If the value must be supplied, switch can be used instead. The only reason to choose the second variant is to enforce evaluation semantics, in which case the parameters of and and or should also be lambdas.

@katcharov katcharov mentioned this pull request Jan 3, 2023
Merged
@stIncMale stIncMale mentioned this pull request Jan 24, 2023
Merged
katcharov and others added 27 commits January 31, 2023 09:13
@katcharov
Implement boolean expressions (#1025)
7be39ba 
JAVA-4779
@katcharov
Implement filter, map, reduce (#1031)
2f33777 
JAVA-4781
@katcharov
Implement eq, ne, gt, gte, lt, lte (#1033)
6acb798 
JAVA-4784
@katcharov
Implement string expressions (#1036)
2d7c03c 
JAVA-4801
@katcharov
Implement arithmetic expressions (#1037)
6768db0 
Implement arithmetic expressions (from top 50, and others)

JAVA-4803
@katcharov
Implement array expressions (#1043)
7ac3ccd 
JAVA-4805
@katcharov
Implement date expressions (#1045)
8b69f18 
JAVA-4804
@katcharov
Implement conversion/type expressions (#1050)
47efc90 
JAVA-4802
@katcharov
Implement document expressions (#1052)
3dcd2ff 
JAVA-4782
@katcharov
Replace reduce with individual reductions (#1053)
1ce4912 
JAVA-4814
@katcharov
Implement map expressions (#1054)
0bfce8e 
JAVA-4817
@katcharov
Implement switch expression (#1055)
a5245b0 
JAVA-4813
@katcharov
Test expressions in context (#1057)
6436f96 
JAVA-4820
@katcharov
Add javadoc for boolean, date, number, integer, and expression (#1059)
25553d1 
 JAVA-4799
@katcharov
Update and add documentation (#1059)
1d9964b 
* Fix, tests

 JAVA-4799
@stIncMale @katcharov
Add @MqlUnchecked and a few usage examples (#1059)
347ab45 
 JAVA-4799
@katcharov
Add has to document, add tests (#1070)
7ce9cb5 
 JAVA-4799
@katcharov
Add javadocs for remaining classes (#1070)
75cb0b7 
 JAVA-4799
@katcharov
5.2 annotations (#1070)
8de3396 
 JAVA-4799
@katcharov
5.0 annotations (#1070)
5680102 
 JAVA-4799
@katcharov
4.4 annotations (#1070)
b80bfcd 
 JAVA-4799
@katcharov
4.2 annotations (#1070)
6f24bea 
 JAVA-4799
@katcharov
4.0 annotations (#1070)
b1ae65d 
 JAVA-4799
@katcharov
Update and add documentation, add tests, fix minor issues (#1070)
678cef8 
Rename extractBsonValue

Fix access modifiers

Remove excess comments

Update docs

Fix: behaviour of get

Add notNull to API, add notNullApi test

Fix docs/annotations, tests

Fix docs, annotations, since

Fix docs

Revert external

Add missing MqlUnchecked

Fix missing null checks

Checkstyle

JAVA-4799
@katcharov
Rename to Mql (automated) (#1073)
441bc53 
JAVA-3879
@katcharov
Rename methods (automated) (#1073)
6bbb231 
JAVA-3879
@katcharov
Update naming, terms, and missing checks and annotations (#1073)
6588406 
JAVA-3879
@katcharov katcharov merged commit ff83341 into master Jan 31, 2023
@katcharov katcharov deleted the expressions branch January 31, 2023 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stIncMale stIncMale stIncMale approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@katcharov @stIncMale