Implement arithmetic expressions #1037
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
katcharov
commented
Nov 9, 2022
driver-core/src/main/com/mongodb/client/model/expressions/NumberExpression.java
Show resolved
Hide resolved
katcharov
commented
Nov 9, 2022
| assertExpression(0.5, of(1).divide(2.0)); | ||
| // TODO these convenience methods are all for doubles, so while they | ||
| // TODO allow longs and ints, they do not carry that through to the server: | ||
| assertExpression(0.5, of(1).divide(2L)); |
There was a problem hiding this comment.
I have created convenience methods only for doubles. If it is critical that the underlying structure, a long, is correctly propagated into the server, the user would need to use of.
jyemin
requested changes
Nov 9, 2022
driver-core/src/main/com/mongodb/client/model/expressions/Expressions.java
Outdated
Show resolved
Hide resolved
stIncMale
reviewed
Nov 9, 2022
driver-core/src/main/com/mongodb/client/model/expressions/Expressions.java
Outdated
Show resolved
Hide resolved
katcharov
force-pushed
the
expressions-string
branch
from
5093ef5 to
1a776bf
Compare
katcharov
force-pushed
the
expressions-arithmetic
branch
from
2544993 to
146a6be
Compare
katcharov
force-pushed
the
expressions-string
branch
from
1a776bf to
d3a93e0
Compare
katcharov
commented
Nov 15, 2022
|
|
||
| // https://www.mongodb.com/docs/manual/reference/operator/aggregation/sum/ | ||
| // sum's alternative behaviour exists for purposes of reduction, but is | ||
| // inconsistent with multiply, and potentially confusing. Unimplemented. |
There was a problem hiding this comment.
Note above comment
katcharov
force-pushed
the
expressions-arithmetic
branch
from
146a6be to
7058fe5
Compare
stIncMale
requested changes
Nov 18, 2022
driver-core/src/main/com/mongodb/client/model/expressions/IntegerExpression.java
Show resolved
Hide resolved
driver-core/src/main/com/mongodb/client/model/expressions/Expressions.java
Outdated
Show resolved
Hide resolved
driver-core/src/main/com/mongodb/client/model/expressions/Expressions.java
Outdated
Show resolved
Hide resolved
driver-core/src/main/com/mongodb/client/model/expressions/MqlExpression.java
Outdated
Show resolved
Hide resolved
...est/functional/com/mongodb/client/model/expressions/ArithmeticExpressionsFunctionalTest.java
Show resolved
Hide resolved
...est/functional/com/mongodb/client/model/expressions/ArithmeticExpressionsFunctionalTest.java
Show resolved
Hide resolved
...est/functional/com/mongodb/client/model/expressions/ArithmeticExpressionsFunctionalTest.java
Outdated
Show resolved
Hide resolved
stIncMale
approved these changes
Nov 18, 2022
katcharov
commented
Nov 21, 2022
| @@ -21,4 +21,37 @@ | |||
| */ | |||
| public interface NumberExpression extends Expression { | |||
|
|
|||
| NumberExpression multiply(NumberExpression n); | |||
|
|
|||
| default NumberExpression multiply(final double multiply) { | |||
There was a problem hiding this comment.
@jyemin raised an issue with double causing unexpected promotion of underlying BSON type causing a ClassCast during:
long d1 = (long) result.get("d");
long d2 = result.getLong("d");
long d3 = result.get("d", Long.class);
Fixed in:
There was a problem hiding this comment.
I pulled this in to this PR
jyemin
reviewed
Nov 21, 2022
driver-core/src/main/com/mongodb/client/model/expressions/NumberExpression.java
Show resolved
Hide resolved
driver-core/src/main/com/mongodb/client/model/expressions/Expressions.java
Outdated
Show resolved
Hide resolved
stIncMale
requested changes
Nov 21, 2022
driver-core/src/main/com/mongodb/client/model/expressions/Expressions.java
Show resolved
Hide resolved
driver-core/src/main/com/mongodb/client/model/expressions/Expressions.java
Show resolved
Hide resolved
stIncMale
approved these changes
Nov 22, 2022
jyemin
approved these changes
Nov 22, 2022
katcharov
added a commit
that referenced
this pull request
Jan 30, 2023
Implement arithmetic expressions (from top 50, and others) JAVA-4803
katcharov
added a commit
that referenced
this pull request
Jan 31, 2023
Implement arithmetic expressions (from top 50, and others) JAVA-4803
katcharov
added a commit
that referenced
this pull request
Jan 31, 2023
* Implement boolean expressions (#1025) JAVA-4779 * Implement filter, map, reduce (#1031) JAVA-4781 * Implement eq, ne, gt, gte, lt, lte (#1033) JAVA-4784 * Implement string expressions (#1036) JAVA-4801 * Implement arithmetic expressions (#1037) Implement arithmetic expressions (from top 50, and others) JAVA-4803 * Implement array expressions (#1043) JAVA-4805 * Implement date expressions (#1045) JAVA-4804 * Implement conversion/type expressions (#1050) JAVA-4802 * Implement document expressions (#1052) JAVA-4782 * Replace reduce with individual reductions (#1053) JAVA-4814 * Implement map expressions (#1054) JAVA-4817 * Implement switch expression (#1055) JAVA-4813 * Test expressions in context (#1057) JAVA-4820 * Add javadoc for boolean, date, number, integer, and expression (#1059) JAVA-4799 * Update and add documentation (#1059) * Fix, tests JAVA-4799 * Add `@MqlUnchecked` and a few usage examples (#1059) JAVA-4799 * Add has to document, add tests (#1070) JAVA-4799 * Add javadocs for remaining classes (#1070) JAVA-4799 * 5.2 annotations (#1070) JAVA-4799 * 5.0 annotations (#1070) JAVA-4799 * 4.4 annotations (#1070) JAVA-4799 * 4.2 annotations (#1070) JAVA-4799 * 4.0 annotations (#1070) JAVA-4799 * Update and add documentation, add tests, fix minor issues (#1070) Rename extractBsonValue Fix access modifiers Remove excess comments Update docs Fix: behaviour of get Add notNull to API, add notNullApi test Fix docs/annotations, tests Fix docs, annotations, since Fix docs Revert external Add missing MqlUnchecked Fix missing null checks Checkstyle JAVA-4799 * Rename to Mql (automated) (#1073) JAVA-3879 * Rename methods (automated) (#1073) JAVA-3879 * Update naming, terms, and missing checks and annotations (#1073) JAVA-3879 --------- Co-authored-by: Valentin Kovalenko <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JAVA-4803
Implements arithmetic expressions from the top 50, and a few others.