Skip to content

Test expressions in context #1057

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jan 19, 2023
Merged

Test expressions in context #1057

merged 5 commits into from
Jan 19, 2023

Conversation

katcharov
Copy link
Collaborator

@katcharov katcharov mentioned this pull request Nov 30, 2022
Merged
katcharov
katcharov commented Dec 9, 2022
View reviewed changes
...test/functional/com/mongodb/client/model/expressions/InContextExpressionsFunctionalTest.java Outdated
Document.parse("{_id: 3, x: 1, y: 3}")));

List<Document> results = aggregate(
match(Filters.expr(current().getInteger("x").eq(of(1)))));
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was reading docs match(expr(new Document("$and", seems that we might add a version of expr such that the above would become:

Filters.expr(d -> d.getInteger("x").eq(of(1))

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am imagining that this could be something for the future.

jyemin
jyemin reviewed Dec 13, 2022
View reviewed changes
@katcharov katcharov requested a review from jyemin December 14, 2022 23:37
stIncMale
stIncMale requested changes Jan 11, 2023
View reviewed changes
...test/functional/com/mongodb/client/model/expressions/InContextExpressionsFunctionalTest.java Outdated
Document.parse("{_id: 3, x: 1, y: 3}")));

List<Document> results = aggregate(
match(Filters.expr(current().getInteger("x").eq(of(1)))));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am imagining that this could be something for the future.

@katcharov katcharov mentioned this pull request Jan 16, 2023
Merged
stIncMale
stIncMale requested changes Jan 17, 2023
View reviewed changes
@katcharov katcharov requested a review from stIncMale January 18, 2023 00:10
@katcharov katcharov force-pushed the expressions-switch2 branch 2 times, most recently from e71ebd8 to 1449f2f Compare January 18, 2023 17:10
@katcharov katcharov force-pushed the expressions-context branch from f6e5a14 to 1fb5893 Compare January 18, 2023 17:35
@katcharov
Copy link
Collaborator Author

Rebased, no conflicts

jyemin
jyemin approved these changes Jan 19, 2023
View reviewed changes
Copy link
Collaborator

@jyemin jyemin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@katcharov katcharov force-pushed the expressions-switch2 branch from 5dd9987 to 647e307 Compare January 19, 2023 15:43
Base automatically changed from expressions-switch2 to expressions January 19, 2023 15:46
@katcharov katcharov force-pushed the expressions-context branch from 1fb5893 to 458d786 Compare January 19, 2023 15:48
@katcharov katcharov merged commit 05bf67b into expressions Jan 19, 2023
@katcharov katcharov deleted the expressions-context branch January 19, 2023 15:48
katcharov added a commit that referenced this pull request Jan 30, 2023
@katcharov
Test expressions in context (#1057)
0340ae6 
JAVA-4820
katcharov added a commit that referenced this pull request Jan 31, 2023
@katcharov
Test expressions in context (#1057)
6436f96 
JAVA-4820
katcharov added a commit that referenced this pull request Jan 31, 2023
@katcharov @stIncMale
Add MQL Expressions (#1032)
ff83341 
* Implement boolean expressions (#1025)

JAVA-4779

* Implement filter, map, reduce (#1031)

JAVA-4781

* Implement eq, ne, gt, gte, lt, lte (#1033)

JAVA-4784

* Implement string expressions (#1036)

JAVA-4801

* Implement arithmetic expressions (#1037)

Implement arithmetic expressions (from top 50, and others)

JAVA-4803

* Implement array expressions (#1043)

JAVA-4805

* Implement date expressions (#1045)

JAVA-4804

* Implement conversion/type expressions (#1050)

JAVA-4802

* Implement document expressions (#1052)

JAVA-4782

* Replace reduce with individual reductions (#1053)

JAVA-4814

* Implement map expressions (#1054)

JAVA-4817

* Implement switch expression (#1055)

JAVA-4813

* Test expressions in context (#1057)

JAVA-4820

* Add javadoc for boolean, date, number, integer, and expression (#1059)

 JAVA-4799

* Update and add documentation (#1059)

* Fix, tests

 JAVA-4799

* Add `@MqlUnchecked` and a few usage examples (#1059)

 JAVA-4799

* Add has to document, add tests (#1070)

 JAVA-4799

* Add javadocs for remaining classes (#1070)

 JAVA-4799

* 5.2 annotations (#1070)

 JAVA-4799

* 5.0 annotations (#1070)

 JAVA-4799

* 4.4 annotations (#1070)

 JAVA-4799

* 4.2 annotations (#1070)

 JAVA-4799

* 4.0 annotations (#1070)

 JAVA-4799

* Update and add documentation, add tests, fix minor issues (#1070)

Rename extractBsonValue

Fix access modifiers

Remove excess comments

Update docs

Fix: behaviour of get

Add notNull to API, add notNullApi test

Fix docs/annotations, tests

Fix docs, annotations, since

Fix docs

Revert external

Add missing MqlUnchecked

Fix missing null checks

Checkstyle

JAVA-4799

* Rename to Mql (automated) (#1073)

JAVA-3879

* Rename methods (automated) (#1073)

JAVA-3879

* Update naming, terms, and missing checks and annotations (#1073)

JAVA-3879

---------

Co-authored-by: Valentin Kovalenko <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jyemin jyemin jyemin approved these changes

@stIncMale stIncMale stIncMale approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@katcharov @jyemin @stIncMale