crypto: expose process.features.openssl_is_boringssl

[codebytere]

This PR exposes process.features.openssl_is_boringssl. This allows knowing which crypto library is in use at the JS level - previously the only way to know was to check the version string, which would be 0.0.0 when built with BoringSSL.

This also sets the stage for adapting some of Node.js' crypto tests to run and pass with both BoringSSL and OpenSSL.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.22%. Comparing base (d2a1369) to head (1422921).
Report is 13 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main   #58387   +/-   ##
=======================================
  Coverage   90.21%   90.22%           
=======================================
  Files         635      635           
  Lines      187148   187150    +2     
  Branches    36740    36751   +11     
=======================================
+ Hits       168842   168849    +7     
+ Misses      11081    11073    -8     
- Partials     7225     7228    +3     

Files with missing lines	Coverage Δ
lib/internal/bootstrap/node.js	99.57% <100.00%> (+<0.01%)	⬆️
src/node_config.cc	96.55% <100.00%> (+0.12%)	⬆️

... and 31 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[legendecas]

Should we expose this bit on process.features instead? crypto.constants object does not seem to be a good place for feature detection.

[codebytere]

@legendecas i don't feel super strongly either way but via crypto.constants is a bit more straightforward imo

[jasnell]

I'm not a big fan of redefining the existing define this way. Perhaps this could just be crypto.constants.BORINGSSL and the definition here could be:

#ifdef OPENSSL_IS_BORINGSSL
  constexpr auto BORINGSSL = 1;
#else
  constexpr auto BORINGSSL = 0;
#endif
  NODE_DEFINE_CONSTANT(target, BORINGSSL);

[jasnell]

Alternatively, I do wonder if this is better exposed via process.config or process.features. We do have the existing process.config.openssl_is_fips and process.config.openssl_quic flags in process.config.

ha... I missed the previous comment about this ;-)

[jasnell]

Change generally LGTM but there's one additional test that I think needs to be updated (test-process-features.js)

[legendecas]

LGTM but test/parallel/test-process-features.js has to be updated

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/66993/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/67003/

[nodejs-github-bot]

Landed in 2b42534