Skip to content

fix: esbuild plugins not matching windows paths #695

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 10, 2025

Conversation

james-elicx
Copy link
Contributor

Some of the filters were missing Windows separators.

Copy link

changeset-bot bot commented Jan 10, 2025

🦋 Changeset detected

Latest commit: 7a62e07

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@opennextjs/aws Patch
app-pages-router Patch
app-router Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@james-elicx james-elicx force-pushed the james/fix-edge-windows branch from 2544734 to fe80b6b Compare January 10, 2025 16:51
@james-elicx james-elicx marked this pull request as ready for review January 10, 2025 16:51
@james-elicx
Copy link
Contributor Author

please can i get a review @vicb @conico974 (i can't use the request feature in this repo)

Copy link

pkg-pr-new bot commented Jan 10, 2025

Open in Stackblitz

pnpm add https://pkg.pr.new/@opennextjs/aws@695

commit: 7a62e07

@james-elicx
Copy link
Contributor Author

Sorry, I don't normally use biome. Formatting should be fixed now.

Copy link
Contributor

@conico974 conico974 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks

@conico974 conico974 merged commit e708ec4 into opennextjs:main Jan 10, 2025
3 checks passed
@github-actions github-actions bot mentioned this pull request Jan 10, 2025
@james-elicx james-elicx deleted the james/fix-edge-windows branch January 10, 2025 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants