fix: invalid paths in windows bundles #247
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: a622581 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
vicb
reviewed
Jan 10, 2025
| @@ -17,6 +17,8 @@ import { openNextReplacementPlugin } from "@opennextjs/aws/plugins/replacement.j | |||
| import { openNextResolvePlugin } from "@opennextjs/aws/plugins/resolve.js"; | |||
| import type { FunctionOptions, SplittedFunctionOptions } from "@opennextjs/aws/types/open-next.js"; | |||
|
|
|||
| import { normalizePath } from "../utils/index.js"; | |||
There was a problem hiding this comment.
would be nice to upstream those changes to aws
vicb
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes some instances of inlined paths to use the normalizePath helper (the cache one was the main problem) and updates an esbuild filter.
Bumps aws package to use the prerelease in opennextjs/opennextjs-aws#695 to fix the esbuild filters.
fixes #204
fixes #236