Skip to content

Conversation

jakedoublev
Copy link
Contributor

@jakedoublev jakedoublev commented Apr 11, 2025

Buf has new proto validation features we want to take advantage of, and we need to bump the underlying service deps in advance of utilizing those features in proto gencode. As one module requires a minimum of 1.23.4, we are bumping to 1.24.0 to avoid pinning to frequently-changing patch versions.

@jakedoublev jakedoublev requested review from a team as code owners April 11, 2025 21:54
@jakedoublev jakedoublev requested review from a team as code owners April 11, 2025 21:58
Copy link
Contributor

Benchmark Statistics

Name № Requests Avg Duration Min Duration Max Duration
publickey 3 0.064 ms 0.027 ms 0.092 ms
rewrap-nanotdf 4860 482.137 ms 50.255 ms 1269.372 ms
rewrap-tdf3 5001 502.949 ms 63.291 ms 1200.825 ms

Bulk Benchmark Results

Metric Value
Total Decrypts 100
Successful Decrypts 100
Failed Decrypts 0
Total Time 357.641892ms
Throughput 279.61 requests/second

Copy link
Contributor

Benchmark Statistics

Name № Requests Avg Duration Min Duration Max Duration
publickey 3 0.063 ms 0.035 ms 0.106 ms
rewrap-nanotdf 4645 400.055 ms 58.663 ms 1123.891 ms
rewrap-tdf3 5001 440.956 ms 59.151 ms 1188.088 ms

Bulk Benchmark Results

Metric Value
Total Decrypts 100
Successful Decrypts 100
Failed Decrypts 0
Total Time 342.483296ms
Throughput 291.99 requests/second

@jakedoublev jakedoublev enabled auto-merge April 11, 2025 22:07
elizabethhealy
elizabethhealy previously approved these changes Apr 14, 2025
Copy link
Contributor

Benchmark Statistics

Name № Requests Avg Duration Min Duration Max Duration
publickey 3 0.058 ms 0.029 ms 0.102 ms
rewrap-nanotdf 4877 416.791 ms 44.862 ms 1054.425 ms
rewrap-tdf3 5001 446.853 ms 50.555 ms 1050.524 ms

Bulk Benchmark Results

Metric Value
Total Decrypts 100
Successful Decrypts 100
Failed Decrypts 0
Total Time 369.247704ms
Throughput 270.82 requests/second

Copy link
Contributor

Benchmark Statistics

Name № Requests Avg Duration Min Duration Max Duration
publickey 3 0.094 ms 0.047 ms 0.186 ms
rewrap-nanotdf 4828 435.043 ms 123.594 ms 946.875 ms
rewrap-tdf3 5001 462.728 ms 49.884 ms 1034.890 ms

Bulk Benchmark Results

Metric Value
Total Decrypts 100
Successful Decrypts 100
Failed Decrypts 0
Total Time 360.8476ms
Throughput 277.13 requests/second

Copy link
Contributor

Benchmark Statistics

Name № Requests Avg Duration Min Duration Max Duration
publickey 3 0.063 ms 0.033 ms 0.098 ms
rewrap-nanotdf 4953 409.565 ms 46.225 ms 792.930 ms
rewrap-tdf3 5001 436.229 ms 51.019 ms 1071.023 ms

Bulk Benchmark Results

Metric Value
Total Decrypts 100
Successful Decrypts 100
Failed Decrypts 0
Total Time 360.385518ms
Throughput 277.48 requests/second

Copy link
Contributor

Benchmark Statistics

Name № Requests Avg Duration Min Duration Max Duration
publickey 3 0.065 ms 0.039 ms 0.106 ms
rewrap-nanotdf 4916 409.803 ms 61.099 ms 981.811 ms
rewrap-tdf3 5001 445.102 ms 43.979 ms 1157.826 ms

Bulk Benchmark Results

Metric Value
Total Decrypts 100
Successful Decrypts 100
Failed Decrypts 0
Total Time 358.22374ms
Throughput 279.16 requests/second

Copy link
Contributor

Benchmark Statistics

Name № Requests Avg Duration Min Duration Max Duration
publickey 3 0.066 ms 0.045 ms 0.108 ms
rewrap-nanotdf 4764 426.474 ms 42.776 ms 1015.747 ms
rewrap-tdf3 5001 460.436 ms 52.596 ms 1153.605 ms

Bulk Benchmark Results

Metric Value
Total Decrypts 100
Successful Decrypts 100
Failed Decrypts 0
Total Time 356.086643ms
Throughput 280.83 requests/second

@jakedoublev jakedoublev requested a review from a team as a code owner April 14, 2025 16:53
Copy link
Contributor

Benchmark Statistics

Name № Requests Avg Duration Min Duration Max Duration
publickey 3 0.064 ms 0.036 ms 0.103 ms
rewrap-nanotdf 4953 463.774 ms 58.298 ms 1085.135 ms
rewrap-tdf3 5001 499.552 ms 58.542 ms 1270.470 ms

Bulk Benchmark Results

Metric Value
Total Decrypts 100
Successful Decrypts 100
Failed Decrypts 0
Total Time 360.888691ms
Throughput 277.09 requests/second

Copy link
Contributor

Benchmark Statistics

Name № Requests Avg Duration Min Duration Max Duration
publickey 3 0.075 ms 0.028 ms 0.142 ms
rewrap-nanotdf 4912 413.127 ms 16.142 ms 955.888 ms
rewrap-tdf3 5001 450.670 ms 39.057 ms 1080.096 ms

Bulk Benchmark Results

Metric Value
Total Decrypts 100
Successful Decrypts 100
Failed Decrypts 0
Total Time 366.662138ms
Throughput 272.73 requests/second

@jakedoublev jakedoublev changed the title fix(core): bump service proto deps in advance of new proto validation features fix(core): bump to go 1.24 and bump service proto module dependencies Apr 14, 2025
@pflynn-virtru
Copy link
Member

No Clear Regression/Improvement Solely from Go Version:
While performance varied, the data doesn't strongly indicate a significant, consistent performance regression or improvement directly and solely caused by switching from Go 1.23.x to Go 1.24.0 within this specific test suite and set of changes. The impact of dependency updates is intertwined with the Go version change.

@strantalis strantalis requested a review from Copilot April 14, 2025 17:35
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 16 out of 18 changed files in this pull request and generated no comments.

Files not reviewed (2)
  • go.work: Language not supported
  • service/go.mod: Language not supported
Comments suppressed due to low confidence (6)

service/policy/unsafe/unsafe_test.go:16

  • Changing the return type from *protovalidate.Validator to protovalidate.Validator could affect behavior if the validator has mutable internals; please confirm that value semantics are intended and that downstream code can work with a copy rather than a pointer.
func getValidator() protovalidate.Validator {

service/policy/subjectmapping/subject_mapping_test.go:12

  • Ensure that switching from returning a pointer to a value for protovalidate.Validator is consistent with its usage in the tests and does not inadvertently alter mutable state behavior.
func getValidator() protovalidate.Validator {

service/policy/resourcemapping/resource_mapping_test.go:51

  • Verify that returning a Validator value instead of a pointer is correct for the intended test operations, especially if methods on protovalidate.Validator expect pointer semantics.
func getValidator() protovalidate.Validator {

service/policy/namespaces/namespaces_test.go:22

  • The change from a pointer to a value for the getValidator function should be reviewed to ensure that any internal mutable state in protovalidate.Validator is handled properly.
func getValidator() protovalidate.Validator {

service/policy/kasregistry/key_access_server_registry_test.go:13

  • Confirm that returning protovalidate.Validator as a value (instead of a pointer) works as expected in test scenarios and does not impact stateful behavior.
func getValidator() protovalidate.Validator {

service/policy/attributes/attributes_test.go:14

  • Review the change in getValidator's signature from a pointer to a value to ensure that this does not break any assumptions about mutability or shared state in the validator usage.
func getValidator() protovalidate.Validator {

@jakedoublev jakedoublev requested a review from jentfoo April 14, 2025 17:37
@jakedoublev jakedoublev added this pull request to the merge queue Apr 14, 2025
Merged via the queue into main with commit 94891a0 Apr 14, 2025
26 checks passed
@jakedoublev jakedoublev deleted the feat/svc-proto-deps branch April 14, 2025 17:57
jakedoublev added a commit that referenced this pull request Apr 14, 2025
github-merge-queue bot pushed a commit that referenced this pull request May 22, 2025
🤖 I have created a release *beep* *boop*
---


##
[0.5.3](service/v0.5.2...service/v0.5.3)
(2025-05-22)


### Features

* **authz:** authz v2 versioning implementation
([#2173](#2173))
([557fc21](557fc21))
* **authz:** authz v2, ers v2 protos and gencode for ABAC with actions &
registered resource
([#2124](#2124))
([ea7992a](ea7992a))
* **authz:** export entity id prefix constant from entity instead of
authorization service v1
([#2261](#2261))
([94079a9](94079a9))
* **authz:** subject mapping plugin support for ABAC with actions
([#2223](#2223))
([d08b939](d08b939))
* bulk keycloak provisioning
([#2205](#2205))
([59e4485](59e4485))
* **core:** add otel to opentdf services
([#1858](#1858))
([53a7aa0](53a7aa0))
* **core:** Adds EC withSalt options
([#2126](#2126))
([67b6fb8](67b6fb8))
* **core:** enhance db configuration options
([#2285](#2285))
([ed9ff59](ed9ff59))
* **core:** New Key Index and Manager Plugin SPI
([#2095](#2095))
([eb446fc](eb446fc))
* **core:** support onConfigUpdate hook when registering services
([#1992](#1992))
([366d4dc](366d4dc))
* **core:** v2 ERS with proto updates
([#2210](#2210))
([a161ef8](a161ef8))
* **policy:** actions crud service endpoints and proto validation
([#2037](#2037))
([e933fa9](e933fa9))
* **policy:** actions service RPCs should actually hit storage layer
CRUD ([#2063](#2063))
([da4faf5](da4faf5))
* **policy:** add enhanced standard/custom actions protos
([#2020](#2020))
([bbac53f](bbac53f))
* **policy:** Add platform key indexer.
([#2189](#2189))
([861ef8d](861ef8d))
* **policy:** consume lib/identifier parse function
([#2181](#2181))
([1cef22b](1cef22b))
* **policy:** DSPX-1018 NDR retrieval by FQN support
([#2131](#2131))
([0001041](0001041))
* **policy:** DSPX-1057 registered resource action attribute values (DB
+ Service implementation)
([#2191](#2191))
([6bf1b2e](6bf1b2e))
* **policy:** DSPX-1057 registered resource action attribute values
(protos only) ([#2217](#2217))
([6375596](6375596))
* **policy:** DSPX-893 NDR define crud protos
([#2056](#2056))
([55a5c27](55a5c27))
* **policy:** DSPX-898 NDR database schema
([#2055](#2055))
([2a10a6a](2a10a6a))
* **policy:** DSPX-901 NDR database crud
([#2071](#2071))
([20e0a5f](20e0a5f))
* **policy:** DSPX-902 NDR service crud implementation (2/2)
([#2066](#2066))
([030ad33](030ad33))
* **policy:** DSPX-902 NDR service crud protos only (1/2)
([#2092](#2092))
([24b6cb5](24b6cb5))
* **policy:** Finish resource mapping groups
([#2224](#2224))
([5ff754e](5ff754e))
* **policy:** GetMatchedSubjectMappings should provide value FQN
([#2151](#2151))
([ad80044](ad80044))
* **policy:** key management crud
([#2110](#2110))
([4c3d53d](4c3d53d))
* **policy:** Key management proto
([#2115](#2115))
([561f853](561f853))
* **policy:** Modify get request to search for keys by kasid with keyid.
([#2147](#2147))
([780d2e4](780d2e4))
* **policy:** Restrict KAS deletion when tied to Key
([#2144](#2144))
([4c4ab13](4c4ab13))
* **policy:** Return KAS Key structure
([#2172](#2172))
([7f97b99](7f97b99))
* **policy:** rotate keys rpc
([#2180](#2180))
([0d00743](0d00743))
* **policy:** stored enhanced actions database migration, CRUD queries,
SM updates ([#2040](#2040))
([e6b7c79](e6b7c79))
* **sdk:** Add a KAS allowlist
([#2085](#2085))
([d7cfdf3](d7cfdf3))
* **sdk:** add nanotdf plaintext policy
([#2182](#2182))
([e5c56db](e5c56db))
* **sdk:** Use ConnectRPC in the go client
([#2200](#2200))
([fc34ee6](fc34ee6))


### Bug Fixes

* **core:** access pdp cleanup before actions in ABAC decisioning
([#2123](#2123))
([9b38a3c](9b38a3c))
* **core:** Autobump service
([#2080](#2080))
([006c724](006c724))
* **core:** Autobump service
([#2104](#2104))
([1f72cc7](1f72cc7))
* **core:** Autobump service
([#2108](#2108))
([be5b7d7](be5b7d7))
* **core:** bump to go 1.24 and bump service proto module dependencies
([#2064](#2064))
([94891a0](94891a0))
* **core:** Fix DPoP with grpc-gateway
([#2044](#2044))
([4483ef2](4483ef2))
* **core:** fix service go.mod
([#2141](#2141))
([3b98f6d](3b98f6d))
* **core:** Improves errors when under heavy load
([#2132](#2132))
([4490a14](4490a14))
* **core:** Let legacy KAOs use new trust plugins
([#2218](#2218))
([5aa6916](5aa6916))
* **core:** migrate from mitchellh/mapstructure to go-viper/mapstructure
([#2087](#2087))
([0a3a82e](0a3a82e))
* **core:** update viper to 1.20.1
([#2088](#2088))
([09099e9](09099e9))
* **core:** Updates vulnerable dep go/x/net
([#2072](#2072))
([11c02cd](11c02cd))
* **deps:** bump github.com/creasty/defaults from 1.7.0 to 1.8.0 in
/service ([#2242](#2242))
([86a9b46](86a9b46))
* **deps:** bump github.com/jackc/pgx/v5 from 5.5.5 to 5.7.5 in /service
([#2249](#2249))
([d8f3b67](d8f3b67))
* **deps:** bump the internal group across 1 directory with 2 updates
([#2296](#2296))
([7f92c70](7f92c70))
* **deps:** bump toolchain in /lib/fixtures and /examples to resolve CVE
GO-2025-3563 ([#2061](#2061))
([9c16843](9c16843))
* handle empty private and public key ctx structs
([#2272](#2272))
([f3fc647](f3fc647))
* **policy:** remove predefined rules in actions protos
([#2069](#2069))
([060f059](060f059))
* **policy:** return kas uri on keys for definition, namespace and
values ([#2186](#2186))
([6c55fb8](6c55fb8))
* update key_mode to provide more context
([#2226](#2226))
([44d0805](44d0805))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: opentdf-automation[bot] <149537512+opentdf-automation[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants