fix(policy): remove predefined rules in actions protos #2069

jakedoublev · 2025-04-14T22:19:54Z

Proposed Changes

Utilization of newer protovalidate features broke compatibility with the Java SDK, so we are backing out those features.

Checklist

I have added or updated unit tests
I have added or updated integration tests (if appropriate)
I have added or updated documentation

Testing Instructions

github-actions · 2025-04-14T22:23:52Z

Benchmark Statistics

Name	№ Requests	Avg Duration	Min Duration	Max Duration
publickey	3	0.062 ms	0.035 ms	0.100 ms
rewrap-nanotdf	4645	397.635 ms	48.492 ms	963.863 ms
rewrap-tdf3	5001	439.097 ms	51.213 ms	1022.649 ms

Bulk Benchmark Results

Metric	Value
Total Decrypts	100
Successful Decrypts	100
Failed Decrypts	0
Total Time	352.474106ms
Throughput	283.71 requests/second

github-actions · 2025-04-14T22:26:01Z

Benchmark Statistics

Name	№ Requests	Avg Duration	Min Duration	Max Duration
publickey	3	0.063 ms	0.029 ms	0.109 ms
rewrap-nanotdf	4771	453.481 ms	78.368 ms	1047.787 ms
rewrap-tdf3	5001	461.577 ms	48.948 ms	1170.768 ms

Bulk Benchmark Results

Metric	Value
Total Decrypts	100
Successful Decrypts	100
Failed Decrypts	0
Total Time	375.389713ms
Throughput	266.39 requests/second

github-actions · 2025-04-14T22:39:17Z

Benchmark Statistics

Name	№ Requests	Avg Duration	Min Duration	Max Duration
publickey	3	0.066 ms	0.028 ms	0.107 ms
rewrap-nanotdf	4906	412.105 ms	49.577 ms	973.519 ms
rewrap-tdf3	5001	436.894 ms	47.091 ms	1022.319 ms

Bulk Benchmark Results

Metric	Value
Total Decrypts	100
Successful Decrypts	100
Failed Decrypts	0
Total Time	359.695251ms
Throughput	278.01 requests/second

jakedoublev · 2025-04-14T22:44:42Z

The x-test CI job is failing because:

protos with incompatible feature depencies were merged (due to incorrectly passing CI pipelines)
xtest runs against the main branch's protos and not the PR branch's protos
xtest then fails when "bad" protos are being removed because they are now on main

This is the same reason it failed to detect the proto incompatibility in the merge pipeline as the Java SDK continued building/testing protos from main instead of the PR branch.

github-actions · 2025-04-14T23:06:32Z

Benchmark Statistics

Name	№ Requests	Avg Duration	Min Duration	Max Duration
publickey	3	0.069 ms	0.043 ms	0.116 ms
rewrap-nanotdf	5000	406.309 ms	47.283 ms	986.846 ms
rewrap-tdf3	5001	446.132 ms	65.823 ms	1153.091 ms

Bulk Benchmark Results

Metric	Value
Total Decrypts	100
Successful Decrypts	100
Failed Decrypts	0
Total Time	369.795726ms
Throughput	270.42 requests/second

Invalidated by push of 53a7728

github-actions · 2025-04-16T14:37:16Z

Benchmark Statistics

Name	№ Requests	Avg Duration	Min Duration	Max Duration
publickey	3	0.076 ms	0.045 ms	0.100 ms
rewrap-nanotdf	4967	410.648 ms	85.374 ms	1037.441 ms
rewrap-tdf3	5001	431.811 ms	55.420 ms	1066.663 ms

Bulk Benchmark Results

Metric	Value
Total Decrypts	100
Successful Decrypts	100
Failed Decrypts	0
Total Time	370.968609ms
Throughput	269.56 requests/second

🤖 I have created a release *beep* *boop* --- ## [0.3.0](protocol/go/v0.2.29...protocol/go/v0.3.0) (2025-04-16) ### ⚠ BREAKING CHANGES * **core:** Require go 1.23+ ([#1979](#1979)) ### Features * **core:** Require go 1.23+ ([#1979](#1979)) ([164c922](164c922)) * **policy:** add enhanced standard/custom actions protos ([#2020](#2020)) ([bbac53f](bbac53f)) * **policy:** DSPX-893 NDR define crud protos ([#2056](#2056)) ([55a5c27](55a5c27)) ### Bug Fixes * **deps:** bump toolchain in /lib/fixtures and /examples to resolve CVE GO-2025-3563 ([#2061](#2061)) ([9c16843](9c16843)) * **policy:** remove predefined rules in actions protos ([#2069](#2069)) ([060f059](060f059)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: opentdf-automation[bot] <149537512+opentdf-automation[bot]@users.noreply.github.com> Co-authored-by: Dave Mihalcik <[email protected]>

🤖 I have created a release *beep* *boop* --- ## [0.5.3](service/v0.5.2...service/v0.5.3) (2025-05-22) ### Features * **authz:** authz v2 versioning implementation ([#2173](#2173)) ([557fc21](557fc21)) * **authz:** authz v2, ers v2 protos and gencode for ABAC with actions & registered resource ([#2124](#2124)) ([ea7992a](ea7992a)) * **authz:** export entity id prefix constant from entity instead of authorization service v1 ([#2261](#2261)) ([94079a9](94079a9)) * **authz:** subject mapping plugin support for ABAC with actions ([#2223](#2223)) ([d08b939](d08b939)) * bulk keycloak provisioning ([#2205](#2205)) ([59e4485](59e4485)) * **core:** add otel to opentdf services ([#1858](#1858)) ([53a7aa0](53a7aa0)) * **core:** Adds EC withSalt options ([#2126](#2126)) ([67b6fb8](67b6fb8)) * **core:** enhance db configuration options ([#2285](#2285)) ([ed9ff59](ed9ff59)) * **core:** New Key Index and Manager Plugin SPI ([#2095](#2095)) ([eb446fc](eb446fc)) * **core:** support onConfigUpdate hook when registering services ([#1992](#1992)) ([366d4dc](366d4dc)) * **core:** v2 ERS with proto updates ([#2210](#2210)) ([a161ef8](a161ef8)) * **policy:** actions crud service endpoints and proto validation ([#2037](#2037)) ([e933fa9](e933fa9)) * **policy:** actions service RPCs should actually hit storage layer CRUD ([#2063](#2063)) ([da4faf5](da4faf5)) * **policy:** add enhanced standard/custom actions protos ([#2020](#2020)) ([bbac53f](bbac53f)) * **policy:** Add platform key indexer. ([#2189](#2189)) ([861ef8d](861ef8d)) * **policy:** consume lib/identifier parse function ([#2181](#2181)) ([1cef22b](1cef22b)) * **policy:** DSPX-1018 NDR retrieval by FQN support ([#2131](#2131)) ([0001041](0001041)) * **policy:** DSPX-1057 registered resource action attribute values (DB + Service implementation) ([#2191](#2191)) ([6bf1b2e](6bf1b2e)) * **policy:** DSPX-1057 registered resource action attribute values (protos only) ([#2217](#2217)) ([6375596](6375596)) * **policy:** DSPX-893 NDR define crud protos ([#2056](#2056)) ([55a5c27](55a5c27)) * **policy:** DSPX-898 NDR database schema ([#2055](#2055)) ([2a10a6a](2a10a6a)) * **policy:** DSPX-901 NDR database crud ([#2071](#2071)) ([20e0a5f](20e0a5f)) * **policy:** DSPX-902 NDR service crud implementation (2/2) ([#2066](#2066)) ([030ad33](030ad33)) * **policy:** DSPX-902 NDR service crud protos only (1/2) ([#2092](#2092)) ([24b6cb5](24b6cb5)) * **policy:** Finish resource mapping groups ([#2224](#2224)) ([5ff754e](5ff754e)) * **policy:** GetMatchedSubjectMappings should provide value FQN ([#2151](#2151)) ([ad80044](ad80044)) * **policy:** key management crud ([#2110](#2110)) ([4c3d53d](4c3d53d)) * **policy:** Key management proto ([#2115](#2115)) ([561f853](561f853)) * **policy:** Modify get request to search for keys by kasid with keyid. ([#2147](#2147)) ([780d2e4](780d2e4)) * **policy:** Restrict KAS deletion when tied to Key ([#2144](#2144)) ([4c4ab13](4c4ab13)) * **policy:** Return KAS Key structure ([#2172](#2172)) ([7f97b99](7f97b99)) * **policy:** rotate keys rpc ([#2180](#2180)) ([0d00743](0d00743)) * **policy:** stored enhanced actions database migration, CRUD queries, SM updates ([#2040](#2040)) ([e6b7c79](e6b7c79)) * **sdk:** Add a KAS allowlist ([#2085](#2085)) ([d7cfdf3](d7cfdf3)) * **sdk:** add nanotdf plaintext policy ([#2182](#2182)) ([e5c56db](e5c56db)) * **sdk:** Use ConnectRPC in the go client ([#2200](#2200)) ([fc34ee6](fc34ee6)) ### Bug Fixes * **core:** access pdp cleanup before actions in ABAC decisioning ([#2123](#2123)) ([9b38a3c](9b38a3c)) * **core:** Autobump service ([#2080](#2080)) ([006c724](006c724)) * **core:** Autobump service ([#2104](#2104)) ([1f72cc7](1f72cc7)) * **core:** Autobump service ([#2108](#2108)) ([be5b7d7](be5b7d7)) * **core:** bump to go 1.24 and bump service proto module dependencies ([#2064](#2064)) ([94891a0](94891a0)) * **core:** Fix DPoP with grpc-gateway ([#2044](#2044)) ([4483ef2](4483ef2)) * **core:** fix service go.mod ([#2141](#2141)) ([3b98f6d](3b98f6d)) * **core:** Improves errors when under heavy load ([#2132](#2132)) ([4490a14](4490a14)) * **core:** Let legacy KAOs use new trust plugins ([#2218](#2218)) ([5aa6916](5aa6916)) * **core:** migrate from mitchellh/mapstructure to go-viper/mapstructure ([#2087](#2087)) ([0a3a82e](0a3a82e)) * **core:** update viper to 1.20.1 ([#2088](#2088)) ([09099e9](09099e9)) * **core:** Updates vulnerable dep go/x/net ([#2072](#2072)) ([11c02cd](11c02cd)) * **deps:** bump github.com/creasty/defaults from 1.7.0 to 1.8.0 in /service ([#2242](#2242)) ([86a9b46](86a9b46)) * **deps:** bump github.com/jackc/pgx/v5 from 5.5.5 to 5.7.5 in /service ([#2249](#2249)) ([d8f3b67](d8f3b67)) * **deps:** bump the internal group across 1 directory with 2 updates ([#2296](#2296)) ([7f92c70](7f92c70)) * **deps:** bump toolchain in /lib/fixtures and /examples to resolve CVE GO-2025-3563 ([#2061](#2061)) ([9c16843](9c16843)) * handle empty private and public key ctx structs ([#2272](#2272)) ([f3fc647](f3fc647)) * **policy:** remove predefined rules in actions protos ([#2069](#2069)) ([060f059](060f059)) * **policy:** return kas uri on keys for definition, namespace and values ([#2186](#2186)) ([6c55fb8](6c55fb8)) * update key_mode to provide more context ([#2226](#2226)) ([44d0805](44d0805)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: opentdf-automation[bot] <149537512+opentdf-automation[bot]@users.noreply.github.com>

🤖 I have created a release *beep* *boop* --- ## [0.7.0](protocol/go/v0.6.2...protocol/go/v0.7.0) (2025-08-08) ### ⚠ BREAKING CHANGES * **policy:** disable kas grants in favor of key mappings ([#2220](#2220)) * **core:** Require go 1.23+ ([#1979](#1979)) ### Features * add ability to retrieve policy resources by id or name ([#1901](#1901)) ([deb4455](deb4455)) * **authz:** authz v2, ers v2 protos and gencode for ABAC with actions & registered resource ([#2124](#2124)) ([ea7992a](ea7992a)) * **authz:** improve v2 request proto validation ([#2357](#2357)) ([f927b99](f927b99)) * **authz:** sensible request limit upper bounds ([#2526](#2526)) ([b3093cc](b3093cc)) * **core:** adds bulk rewrap to sdk and service ([#1835](#1835)) ([11698ae](11698ae)) * **core:** EXPERIMENTAL: EC-wrapped key support ([#1902](#1902)) ([652266f](652266f)) * **core:** Require go 1.23+ ([#1979](#1979)) ([164c922](164c922)) * **core:** v2 ERS with proto updates ([#2210](#2210)) ([a161ef8](a161ef8)) * **policy:** add enhanced standard/custom actions protos ([#2020](#2020)) ([bbac53f](bbac53f)) * **policy:** Add legacy keys. ([#2613](#2613)) ([57370b0](57370b0)) * **policy:** Add list key mappings rpc. ([#2533](#2533)) ([fbc2724](fbc2724)) * **policy:** add obligation protos ([#2579](#2579)) ([50882e1](50882e1)) * **policy:** Add validation to delete keys ([#2576](#2576)) ([cc169d9](cc169d9)) * **policy:** add values to CreateObligationRequest ([#2614](#2614)) ([94535cc](94535cc)) * **policy:** adds new public keys table ([#1836](#1836)) ([cad5048](cad5048)) * **policy:** Allow the deletion of a key. ([#2575](#2575)) ([82b96f0](82b96f0)) * **policy:** cache SubjectConditionSet selectors in dedicated column maintained via trigger ([#2320](#2320)) ([215791f](215791f)) * **policy:** Change return type for delete key proto. ([#2566](#2566)) ([c1ae924](c1ae924)) * **policy:** Default Platform Keys ([#2254](#2254)) ([d7447fe](d7447fe)) * **policy:** disable kas grants in favor of key mappings ([#2220](#2220)) ([30f8cf5](30f8cf5)) * **policy:** DSPX-1018 NDR retrieval by FQN support ([#2131](#2131)) ([0001041](0001041)) * **policy:** DSPX-1057 registered resource action attribute values (protos only) ([#2217](#2217)) ([6375596](6375596)) * **policy:** DSPX-893 NDR define crud protos ([#2056](#2056)) ([55a5c27](55a5c27)) * **policy:** DSPX-902 NDR service crud protos only (1/2) ([#2092](#2092)) ([24b6cb5](24b6cb5)) * **policy:** Finish resource mapping groups ([#2224](#2224)) ([5ff754e](5ff754e)) * **policy:** key management crud ([#2110](#2110)) ([4c3d53d](4c3d53d)) * **policy:** Key management proto ([#2115](#2115)) ([561f853](561f853)) * **policy:** Modify get request to search for keys by kasid with keyid. ([#2147](#2147)) ([780d2e4](780d2e4)) * **policy:** Return KAS Key structure ([#2172](#2172)) ([7f97b99](7f97b99)) * **policy:** Return Simple Kas Keys from non-Key RPCs ([#2387](#2387)) ([5113e0e](5113e0e)) * **policy:** rotate keys rpc ([#2180](#2180)) ([0d00743](0d00743)) * **policy:** Update key status's and UpdateKey rpc. ([#2315](#2315)) ([7908db9](7908db9)) * **policy:** Update simple kas key ([#2378](#2378)) ([09d8239](09d8239)) ### Bug Fixes * add pagination to list public key mappings response ([#1889](#1889)) ([9898fbd](9898fbd)) * **core:** Allow 521 curve to be used ([#2485](#2485)) ([aaf43dc](aaf43dc)) * **core:** Fixes protoJSON parse bug on ec rewrap ([#1943](#1943)) ([9bebfd0](9bebfd0)) * **core:** Update fixtures and flattening in sdk and service ([#1827](#1827)) ([d6d6a7a](d6d6a7a)) * **deps:** bump toolchain in /lib/fixtures and /examples to resolve CVE GO-2025-3563 ([#2061](#2061)) ([9c16843](9c16843)) * **policy:** protovalidate deprecated action types and removal of gRPC gateway in subject mappings svc ([#2377](#2377)) ([54a6de0](54a6de0)) * **policy:** remove gRPC gateway in policy except where needed ([#2382](#2382)) ([1937acb](1937acb)) * **policy:** remove new public keys rpc's ([#1962](#1962)) ([5049bab](5049bab)) * **policy:** remove predefined rules in actions protos ([#2069](#2069)) ([060f059](060f059)) * **policy:** return kas uri on keys for definition, namespace and values ([#2186](#2186)) ([6c55fb8](6c55fb8)) * **sdk:** Fix compatibility between bulk and non-bulk rewrap ([#1914](#1914)) ([74abbb6](74abbb6)) * update key_mode to provide more context ([#2226](#2226)) ([44d0805](44d0805)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: opentdf-automation[bot] <149537512+opentdf-automation[bot]@users.noreply.github.com> Co-authored-by: Krish Suchak <[email protected]>

fix(policy): remove predefined rules in actions protos

a598989

jakedoublev requested review from a team as code owners April 14, 2025 22:19

fix

7f14f6f

ryanulit previously approved these changes Apr 14, 2025

View reviewed changes

downgrade protovalidate/protocolbuffers/go

d97099d

jakedoublev dismissed ryanulit’s stale review via d97099d April 14, 2025 22:35

jakedoublev requested a review from a team as a code owner April 14, 2025 22:35

ryanulit previously approved these changes Apr 14, 2025

View reviewed changes

fix optional updation

0dd18ae

jakedoublev dismissed ryanulit’s stale review via 0dd18ae April 14, 2025 22:47

codegen

c6a2040

This comment was marked as duplicate.

Sign in to view

ryanulit previously approved these changes Apr 14, 2025

View reviewed changes

jakedoublev enabled auto-merge April 14, 2025 22:52

trigger CI

53a7728

jakedoublev dismissed ryanulit’s stale review via 53a7728 April 14, 2025 23:02

ryanulit previously approved these changes Apr 14, 2025

View reviewed changes

jrschumacher previously approved these changes Apr 15, 2025

View reviewed changes

elizabethhealy previously approved these changes Apr 15, 2025

View reviewed changes

pflynn-virtru previously approved these changes Apr 16, 2025

View reviewed changes

jentfoo previously approved these changes Apr 16, 2025

View reviewed changes

go mod tidy

d537344

jakedoublev dismissed jentfoo’s stale review via d537344 April 16, 2025 14:32

jrschumacher approved these changes Apr 16, 2025

View reviewed changes

strantalis disabled auto-merge April 16, 2025 16:41

strantalis merged commit 060f059 into main Apr 16, 2025
20 of 25 checks passed

strantalis deleted the fix/rm-predefined branch April 16, 2025 16:44

This was referenced Apr 16, 2025

chore(main): release protocol/go 0.3.0 #1983

Merged

chore(main): release service 0.5.3 #2046

Merged

opentdf-automation bot mentioned this pull request Apr 29, 2025

chore(main): release protocol/go 0.4.0 #2127

Closed

opentdf-automation bot mentioned this pull request Jul 25, 2025

chore(main): release protocol/go 0.7.0 #2567

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(policy): remove predefined rules in actions protos #2069

fix(policy): remove predefined rules in actions protos #2069

Uh oh!

jakedoublev commented Apr 14, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Apr 14, 2025

Uh oh!

github-actions bot commented Apr 14, 2025

Uh oh!

github-actions bot commented Apr 14, 2025

Uh oh!

jakedoublev commented Apr 14, 2025 •

edited

Loading

Uh oh!

This comment was marked as duplicate.

github-actions bot commented Apr 14, 2025

Uh oh!

github-actions bot commented Apr 16, 2025

Uh oh!

Uh oh!

Uh oh!

fix(policy): remove predefined rules in actions protos #2069

fix(policy): remove predefined rules in actions protos #2069

Uh oh!

Conversation

jakedoublev commented Apr 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Proposed Changes

Checklist

Testing Instructions

Uh oh!

github-actions bot commented Apr 14, 2025

Benchmark Statistics

Bulk Benchmark Results

Uh oh!

github-actions bot commented Apr 14, 2025

Benchmark Statistics

Bulk Benchmark Results

Uh oh!

github-actions bot commented Apr 14, 2025

Benchmark Statistics

Bulk Benchmark Results

Uh oh!

jakedoublev commented Apr 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment was marked as duplicate.

github-actions bot commented Apr 14, 2025

Benchmark Statistics

Bulk Benchmark Results

Uh oh!

github-actions bot commented Apr 16, 2025

Benchmark Statistics

Bulk Benchmark Results

Uh oh!

Uh oh!

Uh oh!

jakedoublev commented Apr 14, 2025 •

edited

Loading

jakedoublev commented Apr 14, 2025 •

edited

Loading