[TASK-13971] fix: scientific notation in eip681 parsing

[jjramirezn]

No description provided.

[notion-workspace]

🪲 Bug: can’t pay arbitrum QR’s this is blocking

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Preview	Comments	Updated (UTC)
peanut-wallet	✅ Ready	Preview	Comment	Aug 15, 2025 3:53am

[coderabbitai]

Walkthrough

EIP-681 parsing in DirectSendQR now converts numeric parameters into human-readable decimal strings via formatUnits; ETH uses 18 decimals, ERC-20 uses getTokenDecimals (fallback 6). Tests updated for formatted amounts. Mock token data structure changed from a chain-keyed object to an array of chain descriptors with token logoURIs.

Changes

Cohort / File(s)	Summary
DirectSendQR parsing & formatting src/components/Global/DirectSendQR/utils.ts	- Added imports: getTokenDecimals, formatUnits. - No-functionName path: read raw value, convert to BigInt, format with 18 decimals to produce human-readable amount string. - transfer path: read uint256 rawAmount→BigInt, get token decimals via getTokenDecimals(tokenAddress, chainId) (fallback 6), format to produce human-readable amount string; preserve tokenSymbol and tokenAddress. - Handles numeric inputs that may arrive in scientific notation.
Tests updated src/components/Global/DirectSendQR/__tests__/parseEip681.test.ts	- Updated expectations to assert decimal string amounts (examples: '2.014', '1.5', '0.000001', '1') instead of wei/scientific notation.
Mock token data shape changed src/utils/__mocks__/peanut-sdk.ts	- TOKEN_DETAILS changed from an object keyed by numeric chain IDs to an array of chain descriptor objects. - Token objects now include logoURI and token naming changed (e.g., Ethereum → Ether); Sepolia (11155111) entry removed.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~15 minutes

Possibly related PRs

• [TASK-10158] feat: expand qr scanner #791 — Directly modifies DirectSendQR parseEip681 behavior and tests; closely related to amount formatting changes.
• [TASK-9260 ]fix: correctly handle USD amount as token amount in payment flows #710 — Adds/exports getTokenDecimals used here to determine ERC-20 decimals.
• fix: req v2 token/balance realted bugs #720 — Related token data/formatting changes that touch token metadata handling used by payment components.

Suggested reviewers

• kushagrasarathe
• Hugo0

Tip

🔌 Remote MCP (Model Context Protocol) integration is now available!

Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats.

✨ Finishing Touches

• 📝 Generate Docstrings

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch fix/qr-handling

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

• Visit our Status Page to check the current availability of CodeRabbit.
• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 2

🔭 Outside diff range comments (1)

src/components/Global/DirectSendQR/utils.ts (1)

96-148: Action required — parseEip681 now returns formatted amounts (formatUnits).

parseEip681 returns human-readable strings (formatUnits) instead of raw wei/uint256/scientific strings — update callers or make the function return the raw value too.

Files/locations that need attention:

• src/components/Global/DirectSendQR/index.tsx — line ~270: const { address, chainId, amount, tokenSymbol } = parseEip681(data) — ensure downstream URL building / logic expects the formatted amount, or use a raw value if needed.
• src/components/Global/DirectSendQR/tests/parseEip681.test.ts — tests expect raw/scientific amounts (e.g. '2.014e18', '1.5e18', '1') — update expected values to the formatted output or update the parser to surface the raw amount.
• src/components/Global/DirectSendQR/utils.ts (parseEip681) — consider returning both formatted and raw values to avoid breaking callers. Example change (conceptual):
  • add rawAmount: rawValue (for ETH) and rawAmount: rawAmount (for ERC-20) alongside the formatted amount.

Recommended actions (pick one):

• Update callers/tests to consume the formatted amount, or
• Change parseEip681 to return both amount (formatted) and rawAmount (original wei/uint256) so existing callers/tests keep working.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

💡 Knowledge Base configuration:

• MCP integration is disabled by default for public repositories
• Jira integration is disabled by default for public repositories
• Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 03878b0 and ea8630e.

📒 Files selected for processing (1)

• src/components/Global/DirectSendQR/utils.ts (3 hunks)

🧰 Additional context used

🧠 Learnings (4)

📓 Common learnings

Learnt from: jjramirezn
PR: peanutprotocol/peanut-ui#422
File: src/components/Request/Pay/Views/Initial.view.tsx:76-78
Timestamp: 2024-10-07T15:28:25.280Z
Learning: In `src/components/Request/Pay/Views/Initial.view.tsx`, both `txFee` and `utils.formatTokenAmount(estimatedGasCost, 3)` return strings, ensuring consistent return types for `calculatedFee`.

Learnt from: jjramirezn
PR: peanutprotocol/peanut-ui#551
File: src/context/walletContext/walletContext.tsx:87-88
Timestamp: 2024-12-02T17:21:45.515Z
Learning: When converting `totalBalance` (in USD) to a `BigInt` balance in `src/context/walletContext/walletContext.tsx`, multiplying by `1e6` is intentional to maintain compatibility with USDC's 6 decimal places. The application displays only 2 decimal places, so this level of precision is sufficient.

📚 Learning: 2024-10-07T15:28:25.280Z

Learnt from: jjramirezn
PR: peanutprotocol/peanut-ui#422
File: src/components/Request/Pay/Views/Initial.view.tsx:76-78
Timestamp: 2024-10-07T15:28:25.280Z
Learning: In `src/components/Request/Pay/Views/Initial.view.tsx`, both `txFee` and `utils.formatTokenAmount(estimatedGasCost, 3)` return strings, ensuring consistent return types for `calculatedFee`.

Applied to files:

• src/components/Global/DirectSendQR/utils.ts

📚 Learning: 2024-10-07T15:25:45.170Z

Learnt from: jjramirezn
PR: peanutprotocol/peanut-ui#422
File: src/components/Request/Pay/Views/Initial.view.tsx:76-78
Timestamp: 2024-10-07T15:25:45.170Z
Learning: In `src/components/Request/Pay/Views/Initial.view.tsx`, both `txFee` and `utils.formatTokenAmount(...)` return strings, ensuring that `calculatedFee` consistently returns a string without the need for additional type conversion.

Applied to files:

• src/components/Global/DirectSendQR/utils.ts

📚 Learning: 2024-12-02T17:21:45.515Z

Learnt from: jjramirezn
PR: peanutprotocol/peanut-ui#551
File: src/context/walletContext/walletContext.tsx:87-88
Timestamp: 2024-12-02T17:21:45.515Z
Learning: When converting `totalBalance` (in USD) to a `BigInt` balance in `src/context/walletContext/walletContext.tsx`, multiplying by `1e6` is intentional to maintain compatibility with USDC's 6 decimal places. The application displays only 2 decimal places, so this level of precision is sufficient.

Applied to files:

• src/components/Global/DirectSendQR/utils.ts

🧬 Code Graph Analysis (1)

src/components/Global/DirectSendQR/utils.ts (1)

src/utils/general.utils.ts (1)

• getTokenDecimals (926-930)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

• GitHub Check: Deploy-Preview

🔇 Additional comments (2)

src/components/Global/DirectSendQR/utils.ts (2)

1-2: LGTM! Import additions are appropriate.

The new imports getTokenDecimals and formatUnits are correctly added and will be used for converting scientific notation amounts to human-readable format.

---

135-137: Good fallback decimal handling for unknown tokens.

Using getTokenDecimals with a fallback to 6 decimals is a reasonable approach. The fallback to 6 decimals aligns with the learning that shows USDC compatibility is important in this codebase.

[coderabbitai]

Actionable comments posted: 1

🧹 Nitpick comments (2)

src/components/Global/DirectSendQR/__tests__/parseEip681.test.ts (2)

47-49: pay- prefix case: expectation is good; consider one more edge case

'1' matches the formatted output from 1e18 wei. Optionally add a case with uppercase scientific notation (e.g., 1E18) to ensure consistent parsing.

---

1-1: CI failure root cause likely in general.utils; fix upstream or mock here

The error "consts.peanutTokenDetails.find is not a function" suggests peanutTokenDetails is not an array at runtime. Upstream fix options:

• Ensure peanutTokenDetails is always an array (or coerce via Array.isArray(...) ? ... : Object.values(...)) before calling .find.
• Guard access and default to [] to avoid TypeErrors.

Short-term for this test file, the jest.mock proposed above decouples parseEip681 tests from that dependency and will unblock the pipeline.

If you confirm the exact module path(s), I can draft a minimal patch either in general.utils or this test to resolve the failure.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

💡 Knowledge Base configuration:

• MCP integration is disabled by default for public repositories
• Jira integration is disabled by default for public repositories
• Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between ea8630e and a9bc44a.

📒 Files selected for processing (1)

• src/components/Global/DirectSendQR/__tests__/parseEip681.test.ts (4 hunks)

🧰 Additional context used

🪛 GitHub Actions: Tests

src/components/Global/DirectSendQR/__tests__/parseEip681.test.ts

[error] 28-28: Test 'parseEip681' failed due to runtime error: TypeError: consts.peanutTokenDetails.find is not a function (root cause in src/utils/general.utils.ts:928).

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

• GitHub Check: Deploy-Preview

🔇 Additional comments (2)

src/components/Global/DirectSendQR/__tests__/parseEip681.test.ts (2)

9-11: ETH amount as human-readable string looks correct

Returning '2.014' (string) aligns with formatting via formatUnits and avoids scientific notation in consumers. Good change.

---

20-22: ETH + chainId case: expectation LGTM

The parsed amount '1.5' (string) is consistent with the new formatting behavior. No issues.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (3)

src/utils/__mocks__/peanut-sdk.ts (3)

19-19: Align chainId type with CHAIN_DETAILS (number vs string) to avoid equality mismatches.

CHAIN_DETAILS uses numeric chainId, while TOKEN_DETAILS uses a string. If any code compares chain IDs (e.g., ===), this will fail unexpectedly.

Apply this diff:

-        chainId: '1',
+        chainId: 1,

---

31-31: Freeze the mock data to prevent accidental mutation in tests.

Marking TOKEN_DETAILS as readonly helps surface incorrect test mutations early.

Apply this diff:

-]
+] as const

---

17-31: Sepolia tokens missing from TOKEN_DETAILS — please confirm or re-add

CHAIN_DETAILS still contains Sepolia (chainId 11155111) but TOKEN_DETAILS in src/utils/mocks/peanut-sdk.ts only includes mainnet tokens, which can surprise code/tests that enumerate chains and expect matching token entries.

Files to check:

• src/utils/mocks/peanut-sdk.ts — CHAIN_DETAILS includes 11155111 (Sepolia); TOKEN_DETAILS declared nearby contains only chainId '1' tokens.
• src/constants/general.consts.ts — imports CHAIN_DETAILS and TOKEN_DETAILS and builds supportedPeanutChains / peanutTokenDetails (uses both lists).
• src/utils/mocks/wagmi.ts — sepolia mock exists (id 11155111).

Requested action:

• Confirm no consumers expect Sepolia token mocks; or
• Reintroduce a minimal Sepolia token entry into TOKEN_DETAILS (e.g., Sepolia ETH native token) or remove Sepolia from CHAIN_DETAILS if it should be unsupported.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

💡 Knowledge Base configuration:

• MCP integration is disabled by default for public repositories
• Jira integration is disabled by default for public repositories
• Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between a9bc44a and 517ffc9.

📒 Files selected for processing (1)

• src/utils/__mocks__/peanut-sdk.ts (1 hunks)

🧰 Additional context used

🧠 Learnings (1)

📓 Common learnings

Learnt from: jjramirezn
PR: peanutprotocol/peanut-ui#495
File: src/components/Cashout/Components/Initial.view.tsx:194-198
Timestamp: 2024-10-29T14:44:08.745Z
Learning: Using a fixed 6 decimal places for `floorFixed` is acceptable for token amounts in this codebase, even if tokens have varying decimal places.

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

• GitHub Check: Deploy-Preview

🔇 Additional comments (2)

src/utils/__mocks__/peanut-sdk.ts (2)

22-29: LGTM: Ether token with 18 decimals and logoURI aligns with EIP-681 decimal formatting tests.

The 18-decimal Ether entry plus a stable logoURI look correct and should support the new formatUnits-based expectations.

---

17-31: No action required: TOKEN_DETAILS is already an array in the repo and no consumers use object-style indexing.

I searched the codebase for bracket-index access, .tokens after an index, and Object-style iteration/usages — none were found.

Files of interest:

• src/utils/mocks/peanut-sdk.ts — defines export const TOKEN_DETAILS = [...] (mock, line ~17).
• src/constants/general.consts.ts — imports TOKEN_DETAILS and assigns peanutTokenDetails: interfaces.IPeanutTokenDetail[] = TOKEN_DETAILS (line ~185).
• package.json — maps ^@squirrel-labs/peanut-sdk$ to src/utils/__mocks__/peanut-sdk.ts, so tests use this mock.

Result: the original warning about a repo-wide API shape change (map → array) is not applicable here — the mock is already an array and no in-repo callers rely on bracket-indexing. No compatibility helper required.