staging country code error

[Zishan-7]

No description provided.

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Preview	Comments	Updated (UTC)
peanut-wallet	✅ Ready	Preview	Comment	Aug 15, 2025 11:44am

[coderabbitai]

Walkthrough

Introduces withdraw.utils with country/validation helpers; updates DynamicBankAccountForm to use new US/MX/IBAN validation and country-code logic; and adjusts callers (AddWithdrawCountriesList, BankFlowManager.view) to pass withdraw-compatible country codes via getCountryCodeForWithdraw.

Changes

Cohort / File(s)	Summary
Withdraw country-code mapping consumers src/components/AddWithdraw/AddWithdrawCountriesList.tsx, src/components/Claim/Link/views/BankFlowManager.view.tsx	Switch country prop passed to DynamicBankAccountForm to getCountryCodeForWithdraw(...).
Bank account form validation and country handling src/components/AddWithdraw/DynamicBankAccountForm.tsx	Replace old US validation with validateUSBankAccount; add CLABE validation; derive country from props/route; refine IBAN usage per country (USA/MX non-IBAN); cross-check IBAN country; maintain BIC derivation; adjust payload countryCode/name logic; update imports.
New withdraw utilities src/utils/withdraw.utils.ts	Add getCountryFromIban, validateUSBankAccount, validateMXCLabeAccount, getCountryCodeForWithdraw; integrate countryData/countryCodeMap.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

• HOTFIX - IBAN country detection and incorrect bank acc details #1094 — Introduces the same withdraw.utils and integrates it into DynamicBankAccountForm and related components.
• Bugfix/copy bank details #938 — Modifies DynamicBankAccountForm around account number normalization, overlapping with this form’s validation changes.
• IBAN to BIC auto-update logic implementation #925 — Adjusts IBAN onBlur/BIC derivation in DynamicBankAccountForm, related to this PR’s IBAN/BIC handling.

Suggested labels

enhancement

Suggested reviewers

• kushagrasarathe

Tip

🔌 Remote MCP (Model Context Protocol) integration is now available!

Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats.

✨ Finishing Touches

• 📝 Generate Docstrings

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch fix/-staging-country-code-error

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

• Visit our Status Page to check the current availability of CodeRabbit.
• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 2

🔭 Outside diff range comments (1)

src/components/AddWithdraw/DynamicBankAccountForm.tsx (1)

127-145: Ensure countryCode/address.country are consistent (alpha-3 for US/MX too).

When Mexico is provided as 'MEX', we should propagate 'MEX' (not 'MX') in payload fields to keep consistency with the 3-letter standard used elsewhere (as with 'USA').

Apply this diff:

-                const payload: Partial<AddBankAccountPayload> = {
+                const payload: Partial<AddBankAccountPayload> = {
                     accountType,
                     accountNumber: accountNumber.replace(/\s/g, ''),
-                    countryCode: isUs ? 'USA' : country.toUpperCase(),
+                    countryCode: isUs ? 'USA' : isMx ? 'MEX' : upperCountry,
-                    countryName: selectedCountry,
+                    countryName: selectedCountry,
                     accountOwnerType: BridgeAccountOwnerType.INDIVIDUAL,
                     accountOwnerName: {
                         firstName: firstName.trim(),
                         lastName: lastName.trim(),
                     },
                     address: {
                         street: data.street ?? '',
                         city: data.city ?? '',
                         state: data.state ?? '',
                         postalCode: data.postalCode ?? '',
-                        country: isUs ? 'USA' : country.toUpperCase(),
+                        country: isUs ? 'USA' : isMx ? 'MEX' : upperCountry,
                     },
                     ...(bic && { bic }),
                 }

🧹 Nitpick comments (1)

src/components/AddWithdraw/DynamicBankAccountForm.tsx (1)

210-223: Nit: recipientName should be the country title, not the code.

PeanutActionDetailsCard currently receives recipientName={country}, which will show codes like 'GBR' or 'MEX'. Passing the display title improves UX.

You can pass actionDetailsProps.recipientName upstream or use countryNameFromProps here when present:

-                    recipientName={country}
+                    recipientName={countryNameFromProps ?? country}

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

💡 Knowledge Base configuration:

• MCP integration is disabled by default for public repositories
• Jira integration is disabled by default for public repositories
• Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between a65bddd and 958acea.

📒 Files selected for processing (4)

• src/components/AddWithdraw/AddWithdrawCountriesList.tsx (2 hunks)
• src/components/AddWithdraw/DynamicBankAccountForm.tsx (7 hunks)
• src/components/Claim/Link/views/BankFlowManager.view.tsx (2 hunks)
• src/utils/withdraw.utils.ts (1 hunks)

🧰 Additional context used

🧠 Learnings (6)

📓 Common learnings

Learnt from: kushagrasarathe
PR: peanutprotocol/peanut-ui#869
File: src/app/(mobile-ui)/withdraw/page.tsx:82-88
Timestamp: 2025-05-22T15:38:48.586Z
Learning: The country-specific withdrawal route exists at src/app/(mobile-ui)/withdraw/[...country]/page.tsx and renders the AddWithdrawCountriesList component with flow="withdraw".

Learnt from: kushagrasarathe
PR: peanutprotocol/peanut-ui#869
File: src/app/(mobile-ui)/withdraw/page.tsx:82-88
Timestamp: 2025-05-22T15:38:48.586Z
Learning: The country-specific withdrawal route exists at src/app/(mobile-ui)/withdraw/[...country]/page.tsx and renders the AddWithdrawCountriesList component with flow="withdraw".

📚 Learning: 2025-05-22T15:38:48.586Z

Learnt from: kushagrasarathe
PR: peanutprotocol/peanut-ui#869
File: src/app/(mobile-ui)/withdraw/page.tsx:82-88
Timestamp: 2025-05-22T15:38:48.586Z
Learning: The country-specific withdrawal route exists at src/app/(mobile-ui)/withdraw/[...country]/page.tsx and renders the AddWithdrawCountriesList component with flow="withdraw".

Applied to files:

• src/components/AddWithdraw/AddWithdrawCountriesList.tsx
• src/utils/withdraw.utils.ts
• src/components/Claim/Link/views/BankFlowManager.view.tsx
• src/components/AddWithdraw/DynamicBankAccountForm.tsx

📚 Learning: 2025-08-14T14:42:54.399Z

Learnt from: Zishan-7
PR: peanutprotocol/peanut-ui#1094
File: src/utils/withdraw.utils.ts:181-191
Timestamp: 2025-08-14T14:42:54.399Z
Learning: The countryCodeMap in src/components/AddMoney/consts/index.ts uses uppercase 3-letter country codes as keys (like 'AUT', 'BEL', 'CZE') that map to 2-letter country codes, requiring input normalization to uppercase for proper lookups.

Applied to files:

• src/components/AddWithdraw/AddWithdrawCountriesList.tsx
• src/utils/withdraw.utils.ts
• src/components/Claim/Link/views/BankFlowManager.view.tsx
• src/components/AddWithdraw/DynamicBankAccountForm.tsx

📚 Learning: 2025-08-13T18:22:01.888Z

Learnt from: Zishan-7
PR: peanutprotocol/peanut-ui#1094
File: src/components/AddWithdraw/DynamicBankAccountForm.tsx:0-0
Timestamp: 2025-08-13T18:22:01.888Z
Learning: In the DynamicBankAccountForm component, the countryName parameter from useParams will always resemble a country title, not a URL slug.

Applied to files:

• src/components/AddWithdraw/AddWithdrawCountriesList.tsx
• src/components/Claim/Link/views/BankFlowManager.view.tsx
• src/components/AddWithdraw/DynamicBankAccountForm.tsx

📚 Learning: 2024-10-25T11:33:46.776Z

Learnt from: jjramirezn
PR: peanutprotocol/peanut-ui#484
File: src/components/Cashout/Components/Initial.view.tsx:273-274
Timestamp: 2024-10-25T11:33:46.776Z
Learning: In the `InitialCashoutView` component (`src/components/Cashout/Components/Initial.view.tsx`), linked bank accounts should not generate error states, and the `ValidatedInput` component will clear any error messages if needed. Therefore, it's unnecessary to manually clear the error state when selecting or clearing linked bank accounts.

Applied to files:

• src/components/Claim/Link/views/BankFlowManager.view.tsx
• src/components/AddWithdraw/DynamicBankAccountForm.tsx

📚 Learning: 2024-11-26T12:06:11.603Z

Learnt from: Hugo0
PR: peanutprotocol/peanut-ui#545
File: src/components/Global/GeneralRecipientInput/index.tsx:118-126
Timestamp: 2024-11-26T12:06:11.603Z
Learning: For bank account input fields, use `autocomplete="bank-account-number"` when the recipient type is `'us'` or `'iban'`.

Applied to files:

• src/components/AddWithdraw/DynamicBankAccountForm.tsx

🧬 Code Graph Analysis (4)

src/components/AddWithdraw/AddWithdrawCountriesList.tsx (1)

src/utils/withdraw.utils.ts (1)

• getCountryCodeForWithdraw (137-147)

src/utils/withdraw.utils.ts (1)

src/components/AddMoney/consts/index.ts (2)

• countryData (255-1943)
• countryCodeMap (1974-2016)

src/components/Claim/Link/views/BankFlowManager.view.tsx (1)

src/utils/withdraw.utils.ts (1)

• getCountryCodeForWithdraw (137-147)

src/components/AddWithdraw/DynamicBankAccountForm.tsx (2)

src/utils/withdraw.utils.ts (3)

• validateMXCLabeAccount (82-134)
• getCountryFromIban (8-27)
• validateUSBankAccount (34-74)

src/utils/bridge-accounts.utils.ts (1)

• validateIban (36-38)

🔇 Additional comments (4)

src/utils/withdraw.utils.ts (1)

110-128: Fix CLABE check-digit algorithm (mod 10 per position is missing).

The CLABE check-digit computation must apply modulo 10 to each weighted product before summing. As written, valid CLABEs will be rejected and vice versa.

Apply this diff to correct the algorithm and edge cases:

-    let sum = 0
-    for (let i = 0; i < 17; i++) {
-        sum += digits[i] * weights[i]
-    }
-
-    const remainder = sum % 10
-    const calculatedCheckDigit = remainder === 0 ? 0 : 10 - remainder
+    let sum = 0
+    for (let i = 0; i < 17; i++) {
+        sum += (digits[i] * weights[i]) % 10
+    }
+
+    // Official rule: check digit = (10 - (sum % 10)) % 10
+    const calculatedCheckDigit = (10 - (sum % 10)) % 10
     const providedCheckDigit = digits[17]

Likely an incorrect or invalid review comment.

src/components/Claim/Link/views/BankFlowManager.view.tsx (1)

30-30: LGTM on mapping country id before passing to the form.

Using getCountryCodeForWithdraw ensures DynamicBankAccountForm receives consistent (withdraw-compatible) codes. This aligns with the new utilities.

Also applies to: 414-415

src/components/AddWithdraw/AddWithdrawCountriesList.tsx (1)

24-24: Also pass countryName to avoid IBAN/country mismatch in validation.

DynamicBankAccountForm cross-checks IBAN’s country against the selected country by title. In withdraw flow we currently don’t supply countryName, so the form falls back to useParams which may be a slug, causing false validation errors.

Apply this diff to provide the human-readable country name:

                 <DynamicBankAccountForm
                     ref={formRef}
-                    country={getCountryCodeForWithdraw(currentCountry.id)}
+                    country={getCountryCodeForWithdraw(currentCountry.id)}
+                    countryName={currentCountry.title}
                     onSuccess={handleFormSubmit}
                     initialData={{}}
                 />

Also applies to: 197-202

⛔ Skipped due to learnings

Learnt from: Zishan-7
PR: peanutprotocol/peanut-ui#1094
File: src/components/AddWithdraw/DynamicBankAccountForm.tsx:0-0
Timestamp: 2025-08-13T18:22:01.888Z
Learning: In the DynamicBankAccountForm component, the countryName parameter from useParams will always resemble a country title, not a URL slug.

Learnt from: Zishan-7
PR: peanutprotocol/peanut-ui#1094
File: src/utils/withdraw.utils.ts:181-191
Timestamp: 2025-08-14T14:42:54.399Z
Learning: The countryCodeMap in src/components/AddMoney/consts/index.ts uses uppercase 3-letter country codes as keys (like 'AUT', 'BEL', 'CZE') that map to 2-letter country codes, requiring input normalization to uppercase for proper lookups.

Learnt from: kushagrasarathe
PR: peanutprotocol/peanut-ui#869
File: src/app/(mobile-ui)/withdraw/page.tsx:82-88
Timestamp: 2025-05-22T15:38:48.586Z
Learning: The country-specific withdrawal route exists at src/app/(mobile-ui)/withdraw/[...country]/page.tsx and renders the AddWithdrawCountriesList component with flow="withdraw".

Learnt from: kushagrasarathe
PR: peanutprotocol/peanut-ui#869
File: src/app/(mobile-ui)/withdraw/page.tsx:82-88
Timestamp: 2025-05-22T15:38:48.586Z
Learning: The country-specific withdrawal route exists at src/app/(mobile-ui)/withdraw/[...country]/page.tsx and renders the AddWithdrawCountriesList component with flow="withdraw".

src/components/AddWithdraw/DynamicBankAccountForm.tsx (1)

62-63: Use a proper display name for IBAN/country cross-check (avoid slug from URL).

Relying on useParams for the display name is brittle (can be slugged). Prefer the provided prop and normalize it; this prevents false errors like “IBAN does not match the selected country”.

Apply this diff:

-        let selectedCountry = (countryNameFromProps ?? (countryName as string)).toLowerCase()
+        const selectedCountryTitle =
+            (countryNameFromProps ?? ((countryName as string) || ''))
+                .replace(/-/g, ' ')
+                .trim()
+        let selectedCountry = selectedCountryTitle.toLowerCase()

-                    countryName: selectedCountry,
+                    countryName: selectedCountryTitle,

-                                            if (getCountryFromIban(val)?.toLowerCase() !== selectedCountry) {
+                                            if (getCountryFromIban(val)?.toLowerCase() !== selectedCountry) {
                                                 return 'IBAN does not match the selected country'
                                             }

Note: After you pass countryName from parents (as suggested in AddWithdrawCountriesList and already done in BankFlowManager), this will consistently use the human-readable title.

Also applies to: 131-131, 284-286

⛔ Skipped due to learnings

Learnt from: Zishan-7
PR: peanutprotocol/peanut-ui#1094
File: src/components/AddWithdraw/DynamicBankAccountForm.tsx:0-0
Timestamp: 2025-08-13T18:22:01.888Z
Learning: In the DynamicBankAccountForm component, the countryName parameter from useParams will always resemble a country title, not a URL slug.

Learnt from: Zishan-7
PR: peanutprotocol/peanut-ui#1094
File: src/utils/withdraw.utils.ts:181-191
Timestamp: 2025-08-14T14:42:54.399Z
Learning: The countryCodeMap in src/components/AddMoney/consts/index.ts uses uppercase 3-letter country codes as keys (like 'AUT', 'BEL', 'CZE') that map to 2-letter country codes, requiring input normalization to uppercase for proper lookups.

[kushagrasarathe]

lgtm 🫡