fix: external claim links history ui + badges fix

[kushagrasarathe]

• fixes TASK-14257 : history ui for send links claimed to external wallets
• also fixes TASK-13929 : badges being shown in claim activity
• also updated the logic of txn receipt component to handle rows and borders without making a mess of conditional logic loop hell

[notion-workspace]

🪲 Bug: activity for claims does not match the designs

[notion-workspace]

Implement changes on KYC Badges

[coderabbitai]

Walkthrough

Passes haveSentMoneyToUser from transactionDetails into TransactionCard, introduces a new transaction type/direction claim_external across transformer, TransactionCard, and header, and refactors TransactionDetails receipt rendering and row visibility while adding address formatting and bank/deposit rows.

Changes

Cohort / File(s)	Summary of changes
History page src/app/(mobile-ui)/history/page.tsx	Passes haveSentMoneyToUser prop to TransactionCard using transactionDetails.haveSentMoneyToUser.
Home history src/components/Home/HomeHistory.tsx	Removes local computation of haveSentMoneyToUser; reads it from transactionDetails.haveSentMoneyToUser for pending transaction cards.
TransactionCard src/components/TransactionDetails/TransactionCard.tsx	Adds claim_external to TransactionType; maps action icon/text for claim_external (up-arrow / "Claim"); uses isAddress/printableAddress to shorten/display addresses in name/VerifiedUserLabel.
Header card src/components/TransactionDetails/TransactionDetailsHeaderCard.tsx	Extends TransactionDirection with claim_external; adds title and icon branches to handle claim_external status/title generation and maps to arrow-up icon.
Receipt + utils src/components/TransactionDetails/TransactionDetailsReceipt.tsx, src/components/TransactionDetails/transaction-details.utils.ts	Centralizes row visibility into typed rowVisibilityConfig and transactionDetailsRowKeys; computes visibleRows and border logic; formats "To" and TX ID (shorten / explorer link / copy); adds EU/US bank deposit details, deposit message, original amount/exchange rate, transfer ID, and uses getBankAccountLabel.
Transformer / mapping src/components/TransactionDetails/transactionTransformer.ts	Maps SEND_LINK flows to claim_external for external-claim cases (direction & transactionCardType), sets nameForDetails from recipientAccount, marks isLinkTx where applicable, adds fallback for unrecognized roles, and requires peer to be a peanut user for isVerified; adjusts uiStatus logic for SEND_LINK.

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~60 minutes

Possibly related PRs

• feat: handle history ui changes for links v2.1 #1106 — Adds/wires haveSentMoneyToUser through transformer → TransactionCard and introduces claim/bank-claim handling; strong overlap in field wiring.
• [TASK-13865] fix: add tx info on receipt #1109 — Modifies transactionTransformer and TransactionDetails UI (explorer/token display/address explorer URL); touches same transformer → UI surfaces.
• [TASK-13864] Show sent always in receipts #1129 — Adjusts TransactionDetailsReceipt completed/visibility logic; overlaps receipt row visibility and rendering changes.

Suggested reviewers

• Zishan-7
• jjramirezn

✨ Finishing Touches

• 📝 Generate Docstrings

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch fix/claim-history

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

• Visit our Status Page to check the current availability of CodeRabbit.
• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Preview	Comments	Updated (UTC)
peanut-wallet	Ready	Preview	Comment	Aug 27, 2025 10:32am

[coderabbitai]

Actionable comments posted: 3

🧹 Nitpick comments (12)

src/app/(mobile-ui)/history/page.tsx (1)

164-165: Coerce haveSentMoneyToUser to a strict boolean.

Avoid passing undefined; coerce to boolean for consistency across call sites.

Apply this diff:

-                                            haveSentMoneyToUser={transactionDetails.haveSentMoneyToUser}
+                                            haveSentMoneyToUser={!!transactionDetails.haveSentMoneyToUser}

src/components/Home/HomeHistory.tsx (1)

231-233: Unify both sections to use transactionDetails.haveSentMoneyToUser (remove inline computation below).

The "Latest Transactions" section (Lines 268–286) still computes haveSentMoneyToUser locally, which can drift from the transformer logic. Use the mapped field for consistency.

Apply this diff:

-                        const haveSentMoneyToUser =
-                            item.userRole === 'SENDER'
-                                ? interactions[item.recipientAccount.userId]
-                                : item.senderAccount?.userId
-                                  ? interactions[item.senderAccount.userId]
-                                  : false
-
                         return (
                             <TransactionCard
                                 key={item.uuid}
                                 type={transactionCardType}
                                 name={transactionDetails.userName}
                                 amount={Number(transactionDetails.amount)}
                                 status={transactionDetails.status}
                                 initials={transactionDetails.initials}
                                 transaction={transactionDetails}
                                 position={position}
-                                haveSentMoneyToUser={haveSentMoneyToUser}
+                                haveSentMoneyToUser={!!transactionDetails.haveSentMoneyToUser}
                             />

src/components/TransactionDetails/TransactionDetailsHeaderCard.tsx (1)

104-112: Title for pending/cancelled link-claims can read as generic "Link Transaction".

When isLinkTransaction is true and status is pending/cancelled, claim_external currently falls through to "Link Transaction". Consider a clearer title.

Apply this diff to the link-transaction switch (Lines 48–65):

     if (isLinkTransaction && (status === 'pending' || status === 'cancelled' || !userName)) {
       const displayName = userName
       switch (direction) {
+        case 'claim_external':
+          titleText = status === 'cancelled' ? `Claim to ${displayName}` : `Claiming to ${displayName}`
+          break
         case 'send':
           titleText = displayName
           break

src/components/TransactionDetails/transactionTransformer.ts (1)

195-199: Be explicit about flags in the fallback SEND_LINK branch.

Set isLinkTx and isPeerActuallyUser explicitly to document intent.

Apply this diff:

       } else {
         direction = 'claim_external'
         transactionCardType = 'claim_external'
         nameForDetails = entry.recipientAccount?.username || entry.recipientAccount?.identifier
+        isPeerActuallyUser = false
+        isLinkTx = true
       }

src/components/TransactionDetails/TransactionDetailsReceipt.tsx (8)

252-258: Normalize Date conversions (avoid toString and inconsistent types)
Use new Date(value) consistently; avoid toString() which can skew parsing and locales.

- value={formatDate(new Date(transaction.createdAt!.toString()))}
+ value={formatDate(new Date(transaction.createdAt!))}
...
- value={formatDate(transaction.cancelledDate as Date)}
+ value={formatDate(new Date(transaction.cancelledDate!))}
...
- value={formatDate(new Date(transaction.claimedAt))}
+ value={formatDate(new Date(transaction.claimedAt!))}
...
- value={formatDate(new Date(transaction.completedAt!))}
+ value={formatDate(new Date(transaction.completedAt!))}

Also applies to: 331-341, 343-353, 355-363

---

452-463: Border leak: collapsible header shows a bottom border even when last row
When depositInstructions is the last visible row and details are collapsed, the extra border-b adds an unwanted trailing divider.

-<div className="border-grey-11 border-b pb-3">
+<div className={twMerge('pb-3', !shouldHideBorder('depositInstructions') && 'border-b border-grey-11')}>

---

391-411: Copy raw IBAN/account identifiers, display formatted
Copying the formatted IBAN (with spaces) can break pasting in banking apps. Display formatted, but copy the raw identifier.

- <CopyToClipboard
-   textToCopy={formatIban(transaction.bankAccountDetails.identifier)}
-   iconSize="4"
- />
+ <CopyToClipboard
+   textToCopy={transaction.bankAccountDetails.identifier}
+   iconSize="4"
+ />

- <CopyToClipboard
-   textToCopy={formatIban(
-     transaction.extraDataForDrawer.depositInstructions.iban
-   )}
-   iconSize="4"
- />
+ <CopyToClipboard
+   textToCopy={transaction.extraDataForDrawer.depositInstructions.iban}
+   iconSize="4"
+ />

Also applies to: 507-522

---

570-611: Defensive US bank fields (avoid non-null assertions)
bank_account_number/bank_routing_number might be absent. Avoid ! and provide a clear fallback in UI while copying an empty string if missing.

- <span>
-   {transaction.extraDataForDrawer.depositInstructions.bank_account_number}
- </span>
- <CopyToClipboard
-   textToCopy={
-     transaction.extraDataForDrawer.depositInstructions.bank_account_number!
-   }
-   iconSize="4"
- />
+ <span>
+   {transaction.extraDataForDrawer.depositInstructions.bank_account_number ?? '—'}
+ </span>
+ <CopyToClipboard
+   textToCopy={transaction.extraDataForDrawer.depositInstructions.bank_account_number ?? ''}
+   iconSize="4"
+ />
...
- <span>
-   {transaction.extraDataForDrawer.depositInstructions.bank_routing_number}
- </span>
- <CopyToClipboard
-   textToCopy={
-     transaction.extraDataForDrawer.depositInstructions.bank_routing_number!
-   }
-   iconSize="4"
- />
+ <span>
+   {transaction.extraDataForDrawer.depositInstructions.bank_routing_number ?? '—'}
+ </span>
+ <CopyToClipboard
+   textToCopy={transaction.extraDataForDrawer.depositInstructions.bank_routing_number ?? ''}
+   iconSize="4"
+ />

---

11-11: Prefer shortenAddressLong for Transfer ID; drop unused import
shortenAddress truncates only the start. shortenAddressLong shows both ends, improving recognition. Then remove the now-unused shortenAddress import.

-import { formatIban, printableAddress, shortenAddress, shortenAddressLong } from '@/utils/general.utils'
+import { formatIban, printableAddress, shortenAddressLong } from '@/utils/general.utils'

- <span>{shortenAddress(transaction.id.toUpperCase(), 20)}</span>
+ <span>{shortenAddressLong(transaction.id.toUpperCase(), 10, 10, 10)}</span>

Also applies to: 412-423

---

69-72: Add missing effect dependency
Include setIsModalOpen in the dependency array to satisfy Rules of Hooks and avoid stale closures.

-useEffect(() => {
-    setIsModalOpen?.(showCancelLinkModal)
-}, [showCancelLinkModal])
+useEffect(() => {
+    setIsModalOpen?.(showCancelLinkModal)
+}, [showCancelLinkModal, setIsModalOpen])

---

691-707: Align Attachment row with unified border logic
Use shouldHideBorder('attachment') for consistency (instead of a hardcoded hideBottomBorder).

-<PaymentInfoRow
+<PaymentInfoRow
   label="Attachment"
   value={
     <Link
       href={transaction.attachmentUrl}
       target="_blank"
-      rel="noreferrer"
+      rel="noopener noreferrer"
       className="flex items-center underline"
     >
       Download
       <Icon name="download" className="h-3" />
     </Link>
   }
-  hideBottomBorder
+  hideBottomBorder={shouldHideBorder('attachment')}
 />

---

260-275: Optional: simplify “To” row using PaymentInfoRow’s copy support
You can avoid custom markup by letting PaymentInfoRow render the copy icon.

-<PaymentInfoRow
-  label={'To'}
-  value={
-    <div className="flex items-center gap-2">
-      <span>
-        {isAddress(transaction.userName)
-          ? printableAddress(transaction.userName)
-          : transaction.userName}
-      </span>
-      <CopyToClipboard textToCopy={transaction.userName} iconSize="4" />
-    </div>
-  }
-  hideBottomBorder={shouldHideBorder('to')}
-/>

+<PaymentInfoRow
+  label="To"
+  value={isAddress(transaction.userName) ? printableAddress(transaction.userName) : transaction.userName}
+  allowCopy
+  copyValue={transaction.userName}
+  hideBottomBorder={shouldHideBorder('to')}
/>

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

• MCP integration is disabled by default for public repositories
• Jira integration is disabled by default for public repositories
• Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 6d71e01 and 22110d8.

📒 Files selected for processing (6)

• src/app/(mobile-ui)/history/page.tsx (1 hunks)
• src/components/Home/HomeHistory.tsx (1 hunks)
• src/components/TransactionDetails/TransactionCard.tsx (5 hunks)
• src/components/TransactionDetails/TransactionDetailsHeaderCard.tsx (3 hunks)
• src/components/TransactionDetails/TransactionDetailsReceipt.tsx (6 hunks)
• src/components/TransactionDetails/transactionTransformer.ts (2 hunks)

🧰 Additional context used

🧠 Learnings (1)

📚 Learning: 2025-04-11T11:33:53.245Z

Learnt from: kushagrasarathe
PR: peanutprotocol/peanut-ui#798
File: src/components/Home/HomeHistory.tsx:138-192
Timestamp: 2025-04-11T11:33:53.245Z
Learning: In the HomeHistory component, infinite scrolling is intentionally not implemented despite the presence of useInfiniteQuery and IntersectionObserver code. The component is designed to only display the first 5 entries with a "View all transactions" link for viewing the complete history.

Applied to files:

• src/components/Home/HomeHistory.tsx

🧬 Code graph analysis (2)

src/components/TransactionDetails/TransactionCard.tsx (1)

src/utils/general.utils.ts (1)

• printableAddress (70-73)

src/components/TransactionDetails/TransactionDetailsReceipt.tsx (2)

src/components/Payment/PaymentInfoRow.tsx (1)

• PaymentInfoRow (7-81)

src/utils/general.utils.ts (4)

• printableAddress (70-73)
• shortenAddressLong (51-68)
• shortenAddress (43-49)
• formatIban (965-972)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

• GitHub Check: Deploy-Preview

🔇 Additional comments (5)

src/components/Home/HomeHistory.tsx (1)

231-233: Good shift to data-layer provided haveSentMoneyToUser for pending section.

This aligns with the transformer and removes duplicated logic.

src/components/TransactionDetails/TransactionDetailsHeaderCard.tsx (1)

25-26: New direction and icon mapping for claim_external look correct.

Direction type extended and icon set to arrow-up match the UX for external claims.

Also applies to: 137-138

src/components/TransactionDetails/transactionTransformer.ts (1)

406-408: Verified badge gating is correct.

Only showing the badge when the peer is an actual Peanut user prevents misleading verification marks for external addresses.

src/components/TransactionDetails/TransactionCard.tsx (2)

179-182: Address-aware name rendering is a nice UX win.

Using printableAddress only for valid addresses keeps usernames intact and shortens addresses consistently. Passing haveSentMoneyToUser through to VerifiedUserLabel is consistent with the new data flow.

---

233-236: Icon and action text for claim_external are consistent with header behavior.

Arrow-up + "Claim" matches the new direction semantics.

Also applies to: 257-259

[coderabbitai]

Actionable comments posted: 0

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)

src/components/TransactionDetails/TransactionDetailsReceipt.tsx (1)

702-716: Security: include noopener on external link

Prevent window.opener hijacking.

Apply:

- rel="noreferrer"
+ rel="noopener noreferrer"

♻️ Duplicate comments (1)

src/components/TransactionDetails/TransactionDetailsReceipt.tsx (1)

317-339: TX ID: always shown, link when possible + noopener — LGTM

Matches prior recommendation and improves security.

🧹 Nitpick comments (9)

src/components/TransactionDetails/transaction-details.utils.ts (2)

20-38: Freeze and validate row order + fix comment typo

Make the order immutable and compiler-checked; also fix the “rder” typo.

Apply:

-// rder of the rows in the receipt
-export const transactionDetailsRowKeys: TransactionDetailsRowKey[] = [
+// order of the rows in the receipt
+export const transactionDetailsRowKeys = [
   'createdAt',
   'to',
   'tokenAndNetwork',
   'txId',
   'cancelled',
   'claimed',
   'completed',
   'fee',
   'exchangeRate',
   'bankAccountDetails',
   'transferId',
   'depositInstructions',
   'peanutFee',
   'comment',
   'networkFee',
   'attachment',
-]
+] as const satisfies readonly TransactionDetailsRowKey[]

---

40-49: Defensive input + alias handling in getBankAccountLabel

Avoid runtime error if type is undefined and fold common aliases.

Apply:

-export const getBankAccountLabel = (type: string) => {
-    switch (type.toLowerCase()) {
+export const getBankAccountLabel = (
+    type?: string
+): 'IBAN' | 'CLABE' | 'Account Number' => {
+    const t = (type ?? '').toLowerCase()
+    switch (t) {
         case 'iban':
             return 'IBAN'
         case 'clabe':
             return 'CLABE'
+        case 'account_number':
+        case 'accountnumber':
+            return 'Account Number'
         default:
             return 'Account Number'
     }
 }

src/components/TransactionDetails/TransactionDetailsReceipt.tsx (7)

91-128: Visibility conditions look correct; minor micro-opt

You could hoist a constant allFalse = Object.fromEntries(transactionDetailsRowKeys.map(k => [k,false])) as Record<...> outside the component to avoid re-allocating the base object, but this is non-blocking.

---

256-262: Avoid unnecessary toString() when constructing Date

Pass the value directly to new Date(...) for consistency with other rows.

Apply:

- value={formatDate(new Date(transaction.createdAt!.toString()))}
+ value={formatDate(new Date(transaction.createdAt!))}

---

264-279: Simplify address formatting: printableAddress already guards isAddress

printableAddress already checks if the string is an address; drop the extra isAddress call and add a null-safe fallback.

Apply:

- value={
-     <div className="flex items-center gap-2">
-         <span>
-             {isAddress(transaction.userName)
-                 ? printableAddress(transaction.userName)
-                 : transaction.userName}
-         </span>
-         <CopyToClipboard textToCopy={transaction.userName} iconSize="4" />
-     </div>
- }
+ value={
+     <div className="flex items-center gap-2">
+         <span>{printableAddress(transaction.userName ?? '')}</span>
+         {transaction.userName && (
+             <CopyToClipboard textToCopy={transaction.userName} iconSize="4" />
+         )}
+     </div>
+ }

---

342-351: Consistent Date construction

For consistency with other rows, wrap cancelledDate with new Date(...) instead of passing a possibly-string.

Apply:

- value={formatDate(transaction.cancelledDate as Date)}
+ value={formatDate(new Date(transaction.cancelledDate as Date))}

---

380-400: Border glitch when no exchange rate

If exchange_rate is absent, “Original amount” becomes the last rendered row in this section but keeps a bottom border. Hide it when the exchangeRate group is last.

Apply:

- hideBottomBorder={false}
+ hideBottomBorder={
+   shouldHideBorder('exchangeRate') &&
+   !transaction.extraDataForDrawer?.receipt?.exchange_rate
+ }

---

402-422: Copy raw account identifier; display formatted

Copying the spaced IBAN can fail in some bank forms. Display the formatted IBAN, but copy the raw identifier.

Apply:

- <CopyToClipboard
-     textToCopy={formatIban(transaction.bankAccountDetails.identifier)}
-     iconSize="4"
- />
+ <CopyToClipboard
+     textToCopy={transaction.bankAccountDetails.identifier.replace(/\s+/g, '')}
+     iconSize="4"
+ />

---

518-536: Deposit IBAN: copy unformatted

Same rationale as above—copy the raw IBAN while displaying the formatted one.

Apply:

- <CopyToClipboard
-     textToCopy={formatIban(
-         transaction.extraDataForDrawer.depositInstructions.iban
-     )}
-     iconSize="4"
- />
+ <CopyToClipboard
+     textToCopy={transaction.extraDataForDrawer.depositInstructions.iban.replace(/\s+/g, '')}
+     iconSize="4"
+ />

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

• MCP integration is disabled by default for public repositories
• Jira integration is disabled by default for public repositories
• Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 22110d8 and e16216c.

📒 Files selected for processing (2)

• src/components/TransactionDetails/TransactionDetailsReceipt.tsx (6 hunks)
• src/components/TransactionDetails/transaction-details.utils.ts (1 hunks)

🧰 Additional context used

🧬 Code graph analysis (1)

src/components/TransactionDetails/TransactionDetailsReceipt.tsx (3)

src/components/TransactionDetails/transaction-details.utils.ts (3)

• TransactionDetailsRowKey (2-18)
• transactionDetailsRowKeys (21-38)
• getBankAccountLabel (40-49)

src/components/Payment/PaymentInfoRow.tsx (1)

• PaymentInfoRow (7-81)

src/utils/general.utils.ts (5)

• formatDate (937-949)
• printableAddress (70-73)
• shortenAddressLong (51-68)
• shortenAddress (43-49)
• formatIban (965-972)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

• GitHub Check: Deploy-Preview

🔇 Additional comments (4)

src/components/TransactionDetails/transaction-details.utils.ts (1)

1-18: Good: central RowKey union exported

Clear, typed surface for all receipt rows; this unblocks stable ordering and safer visibility maps downstream.

src/components/TransactionDetails/TransactionDetailsReceipt.tsx (3)

77-90: Type-safe, full visibility map init

Returning a fully-shaped Record<TransactionDetailsRowKey, boolean> (all false) when !transaction is solid. Nice.

---

131-141: Stable ordering + correct last-row detection

visibleRows derived from the ordered keys and shouldHideBorder keyed by TransactionDetailsRowKey is clean.

---

951-982: Ignore the original guard suggestion; the review comment is misaligned with the store shape
The useUserStore selector returns an object whose user property is already the profile (of type IUserProfile), so in your component:
• const { user } = useUserStore() makes user the actual profile, not a nested container.
• There is no user.user; the correct field is user.username.

Because this component only renders its “Claim” action when the user is signed in (and your slice’s initial state defines user: null but you only ever reach this path with a loaded profile), you don’t need to guard against a missing store or drop an extra .user. If you do want a runtime check for extra safety, you would write:

if (!user?.username) {
  captureException(new Error('Missing username while confirming cancel/claim'))
  return
}
// …
sendLinksApi
  .claim(user.username, transaction.extraDataForDrawer!.link!)

But the original suggestion to use user?.user?.username should be ignored.

Likely an incorrect or invalid review comment.

[coderabbitai]

Actionable comments posted: 0

♻️ Duplicate comments (1)

src/components/TransactionDetails/transactionTransformer.ts (1)

324-328: Fix validated: COMPLETED no longer downgraded to pending for external-claim.

This resolves the earlier mislabel for SEND_LINK external-claim entries.

🧹 Nitpick comments (2)

src/components/TransactionDetails/transactionTransformer.ts (2)

195-198: Make role-agnostic fallback explicit about link/user flags.

Be explicit to avoid relying on earlier assignments and improve readability.

       } else {
         direction = 'claim_external'
         transactionCardType = 'claim_external'
         nameForDetails = entry.recipientAccount?.username || entry.recipientAccount?.identifier
+        isPeerActuallyUser = false
+        isLinkTx = true
       }

---

324-328: Harden condition by also checking transactionCardType.

Future refactors could change direction while keeping cardType. Guard both.

-                uiStatus =
-                    EHistoryEntryType.SEND_LINK === entry.type && direction !== 'claim_external'
-                        ? 'pending'
-                        : 'completed'
+                uiStatus =
+                    EHistoryEntryType.SEND_LINK === entry.type &&
+                    direction !== 'claim_external' &&
+                    transactionCardType !== 'claim_external'
+                        ? 'pending'
+                        : 'completed'

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

• MCP integration is disabled by default for public repositories
• Jira integration is disabled by default for public repositories
• Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between e16216c and c485a98.

📒 Files selected for processing (1)

• src/components/TransactionDetails/transactionTransformer.ts (3 hunks)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)

• GitHub Check: Deploy-Preview
• GitHub Check: test

🔇 Additional comments (3)

src/components/TransactionDetails/transactionTransformer.ts (3)

176-190: SEND_LINK (RECIPIENT) → claim_external mapping looks correct.

Direction/cardType are set to 'claim_external' only when recipient is not a Peanut user; this aligns with the PR objective.

---

176-190: Ensure display formatting for long identifiers.

nameForDetails = entry.recipientAccount.identifier may be a long address; confirm the rendering layer shortens it (e.g., 0xabc…def).

If not handled in the component, do you want a small helper wired here instead?

---

409-411: Badge gating is correct.

isVerified now shows only when the peer is an actual Peanut user; this addresses badges showing on claims to external wallets.

[Zishan-7]

Great PR