[v9] Release #1330
Merged
[v9] Release #1330
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This affects `update` and `leave` too. Closes #1000
Avoid merging `{default: context}` updates when `context` is empty, because it can get in the way of debugging.
This function will call every queued function with the same arguments.
SpringValue already worked, but Controller did not
- For the `pause` prop, check the `props.default` object (if one exists) before checking the `props` object. - Let the default `cancel` prop affect the current async animation. - Ensure each `SpringValue` object still has its default props updated when `pause: true` is defined. - Respect the `delay` prop when `cancel: true` is defined with no explicit keys in the same update.
Previously, the `pause` prop would override `default.pause` except when the latter was true. Now, the `pause` prop must be a boolean before `default.pause` is overridden. This ensures the paused async animation is resumed (if one exists) when the default `pause` prop is changed to false.
Cancellation can lead to unintended outcomes, like a transition being reset to its previous phase.
By allowing any Function type, the compiler wont try the next overload, but we still get type checking of props!
The `Controller.springs` and `SpringValue.animation` properties are overridden to throw on access.
Handlers are called once per paused/resumed value. Event batching is not currently implemented.
This behavior was changed by 4de9fd0
this was causing some elements to have an extra viewport height gap. see issue for more details. fixes #962 Co-authored-by: Josh Ellis <[email protected]>
Co-authored-by: Josh Ellis <[email protected]>
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit a9b80a4:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's been a while since a stable release. There have been some setbacks, but I think our goal should be to launch v9 as stable and fix from there. We've had 3
rcreleases and they've been great.Hopefully with the release of a stable version people will have the confidence & motivation to fix bugs that they're experiencing for themselves to make this library stronger 💪🏼
There's 2 small things we need to do first, but this way I can track which issues should be resolved with this release and attach them accordingly.
🎉