-
Notifications
You must be signed in to change notification settings - Fork 178
[beta.p5js.org] Typo: Switch "let" to "int" to make GLSL code valid #979
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Create donate.mdx Korean translation file
Update donate.mdx title
Create code-of-conduct.mdx Korean translation file
…-main2 Update contributors list
This reverts commit 568a8b8.
Fully unmount sketches that go out of frame
Add libraries, fix bug with old featured ones not getting cycled
FPS library
Signed-off-by: shiva <[email protected]>
Updated description and `sourceURL`.
…th no args and memoize getCurationSketches
Incorporate review feedback into translation
Add Korean Translation to code-of-conduct.mdx
Add Korean Translation to donate.mdx
- Change visualID type from string to number to match API response - Update all OpenProcessing functions to accept number parameters - Add explicit String() conversion in getStaticPaths for URL compatibility - Remove unnecessary type conversions in sketch lookups - Enable proper memoization to reduce API calls and prevent 429 errors
…isualId-type-mismatch Fix OpenProcessing visualID type mismatch causing rate limiting
…ibility Accessibility: Differentiate external footer links with icon and tooltip
Fix: Remove Empty Anchor Link in Jump-To Menu on Reference Pages
* solves docs issue 837 for p5.js 2.x * Update version * Merge pull request processing#812 from processing/feat/perf Fully unmount sketches that go out of frame * add updated editor images for intro tutorials * update image paths and alt text for editor images in intro tutorials * update screenshots with consistent browser theme * fixed typo: frameCount is a variable not a function * Update p5.js to v1.11.7 * Set iframe srcdoc attribute to blank to prevent iframe navigation * submission for shapeSVG library * rename file * Update p5.js to v1.11.8 * Create Accessibility Issue template * Update 4.accessibility.yml * Update placeholders in 4.accessibility.yml * Update 4.accessibility.yml to remove extra "steps to reproduce field" Fixes an accidental inclusion of an unnecessary field * Add issue-closing workflow to main branch * remove extra things, another issue entertained so removed that * pr branch update --------- Co-authored-by: Dave Pagurek <[email protected]> Co-authored-by: Dave Pagurek <[email protected]> Co-authored-by: raclim <[email protected]> Co-authored-by: Axel <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: limzykenneth <[email protected]> Co-authored-by: Ms. Feng <[email protected]> Co-authored-by: kit <[email protected]>
* Changed alt text for 2 images. * Changed excessively long alt text * Update alt text to be more descriptive * Update alt text on setting-up-your-environment.mdx --------- Co-authored-by: kit <[email protected]>
Add Foundation for Automated Accessibility Testing
adds the p5.spatial.js library to the community libraries
- Add basic validation (visualID, type check) in sketch getStaticPaths - Remove unnecessary isNaN check from SketchLayout - Prevent invalid sketch pages from being generated during build
- Add comprehensive tests for getCurationSketches memoization - Test getSketch cache usage and fallback to individual API calls - Test getSketchSize API calls during build simulation - Verify API call count regression to prevent performance issues - Include test for individual sketch fetching when not in cache
- Replace console.error with throw Error in all OpenProcessing API functions - Ensure build fails immediately when API calls fail instead of continuing with invalid data - Add comprehensive error handling tests for all API functions - Test various error scenarios: 500 Internal Server Error, 429 Rate Limit, 404 Not Found - Improve build reliability by failing fast on API issues - Export priorityIds for better test maintainability
Banner script update to fix the missing banner
…build-validation Improve OpenProcessing API error handling and add caching tests
Fix: Replace duplicate callout headings with ARIA-labeled sections
…ependency Make CI build depends on test job in github actions
Uhhhh lemme fix this 😅 |
Ah haha you may need to branch off of the |
Closed in favor of #980 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As requested by @davepagurek , this is a duplicate of #978 for the
2.0
branch/beta.p5js.orgResolves #977