Skip to content

NXP backend: Add docker image for nxp backend tests #11473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

robert-kalmar
Copy link
Collaborator

@robert-kalmar robert-kalmar commented Jun 9, 2025

Summary

NXP backend: Add docker image for nxp backend tests

Test plan

N/A

cc @digantdesai @JakeStevens

Copy link

pytorch-bot bot commented Jun 9, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/11473

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures, 44 Cancelled Jobs

As of commit 79e53eb with merge base c120b35 (image):

NEW FAILURES - The following jobs have failed:

CANCELLED JOBS - The following jobs were cancelled. Please retry:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 9, 2025
@robert-kalmar robert-kalmar added ciflow/trunk module: nxp Issues related to NXP Neutron NPU delegation and code under backends/nxp/ release notes: nxp Changes to the NXP Neutron backend delegate labels Jun 9, 2025
@@ -39,6 +39,7 @@ jobs:
executorch-ubuntu-22.04-arm-sdk,
executorch-ubuntu-22.04-qnn-sdk,
executorch-ubuntu-22.04-mediatek-sdk,
executorch-ubuntu-22.04-nxp-sdk,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't have anything special to install in the docker image right? If yes, I guess we can continue to use the base image? What are your thoughts?

@cccclai - what was the rationale for suggesting a new docker image?

Copy link
Collaborator Author

@robert-kalmar robert-kalmar Jun 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, we don't. At least not at this moment.
Looking at the docker file nobody (arm, qnn, mediatek) really does https://github.com/pytorch/executorch/blob/79e53ebd00d07bef28975b1a089ce87a074c9ab7/.ci/docker/ubuntu/Dockerfile .
Although Arm in early day installed the Arm SDK on docker-image https://github.com/pytorch/executorch/pull/1111/files#diff-f271c3ed0c135590409465f4ad55c570c418d2c0509bbf1b1352ebdd1e6611d1

+1 for the rationale @cccclai

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@huydhn to share, as @kirklandsign is out.

@robert-kalmar
Copy link
Collaborator Author

robert-kalmar commented Jun 10, 2025

Note, this PR fails with (https://github.com/pytorch/executorch/actions/runs/15534181661/job/43729414408?pr=11473#step:7:26128):

name unknown: The repository with name 'executorch/executorch-ubuntu-22.04-nxp-sdk' does not exist in the registry with id '308535385114'

and what I understood from the conversation, when Arm was introducing its docker image (#1111). Someone from you should create the registry for the executorch/executorch-ubuntu-22.04-nxp-sdk images. Correct?

@cccclai
Copy link
Contributor

cccclai commented Jun 10, 2025

Note, this PR fails with (https://github.com/pytorch/executorch/actions/runs/15534181661/job/43729414408?pr=11473#step:7:26128):

name unknown: The repository with name 'executorch/executorch-ubuntu-22.04-nxp-sdk' does not exist in the registry with id '308535385114'

and what I understood from the conversation, when Arm was introducing its docker image (#1111). Someone from you should create the registry for the executorch/executorch-ubuntu-22.04-nxp-sdk images. Correct?

Yeah @huydhn is the PoC to register.

@robert-kalmar robert-kalmar marked this pull request as draft June 18, 2025 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. module: nxp Issues related to NXP Neutron NPU delegation and code under backends/nxp/ release notes: nxp Changes to the NXP Neutron backend delegate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants