-
Notifications
You must be signed in to change notification settings - Fork 603
NXP backend: Add docker image for nxp backend tests #11473
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
NXP backend: Add docker image for nxp backend tests #11473
Conversation
Fix duplicate bpe tokenizer base symbol (pytorch#63)
@@ -39,6 +39,7 @@ jobs: | |||
executorch-ubuntu-22.04-arm-sdk, | |||
executorch-ubuntu-22.04-qnn-sdk, | |||
executorch-ubuntu-22.04-mediatek-sdk, | |||
executorch-ubuntu-22.04-nxp-sdk, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't have anything special to install in the docker image right? If yes, I guess we can continue to use the base image? What are your thoughts?
@cccclai - what was the rationale for suggesting a new docker image?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, we don't. At least not at this moment.
Looking at the docker file nobody (arm, qnn, mediatek) really does https://github.com/pytorch/executorch/blob/79e53ebd00d07bef28975b1a089ce87a074c9ab7/.ci/docker/ubuntu/Dockerfile .
Although Arm in early day installed the Arm SDK on docker-image https://github.com/pytorch/executorch/pull/1111/files#diff-f271c3ed0c135590409465f4ad55c570c418d2c0509bbf1b1352ebdd1e6611d1
+1 for the rationale @cccclai
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@huydhn to share, as @kirklandsign is out.
Note, this PR fails with (https://github.com/pytorch/executorch/actions/runs/15534181661/job/43729414408?pr=11473#step:7:26128):
and what I understood from the conversation, when Arm was introducing its docker image (#1111). Someone from you should create the registry for the executorch/executorch-ubuntu-22.04-nxp-sdk images. Correct? |
Yeah @huydhn is the PoC to register. |
Summary
NXP backend: Add docker image for nxp backend tests
Test plan
N/A
cc @digantdesai @JakeStevens