[FBcode->GH] Import fbcode changes #9159

NicolasHug · 2025-07-31T09:14:38Z

This does

git merge origin/fbsync -X theirs

revert of changes to .clang-format (86c6c15) and a flake8 fix (045ed65)

It syncs the GH codebase with what's currently in fbcode. I'll re-apply Cpp linters in a follow-up.

Marking as [FBcode->GH] because this isn't meant to be synced back to fbcode (this is where the changes come from!)

Reviewed By: vmoens Differential Revision: D58283853 fbshipit-source-id: 27d883bf5ca436b0176427413275b2764247ad32

Reviewed By: vmoens Differential Revision: D58283848 fbshipit-source-id: cfc6b13751cbcb99710e385cfa0e0e634b7cb699

Reviewed By: vmoens Differential Revision: D58283859 fbshipit-source-id: e882d7dbc22ec3e04edea50f95b6a30456f8fd2b Co-authored-by: Nicolas Hug <[email protected]> Co-authored-by: Nicolas Hug <[email protected]>

…val' (pytorch#8475) Reviewed By: vmoens Differential Revision: D58283849 fbshipit-source-id: e69b9727b7f0271cadf98c2f11edd408e9b9a8e3

…#8470) Reviewed By: vmoens Differential Revision: D58283844 fbshipit-source-id: cdaeca2d826bc3ff481286fc4dabd3ae7d6d76a4

Reviewed By: vmoens Differential Revision: D58283813 fbshipit-source-id: 749e5c793d27ea87e3e12e1b3ecc146a40530067 Co-authored-by: Nicolas Hug <[email protected]> Co-authored-by: Nicolas Hug <[email protected]>

Summary: backout this as requested by https://fburl.com/workplace/oth8mri3 Original commit changeset: 3ae8c0d78bfc Original Phabricator Diff: D58101774 Reviewed By: NicolasHug Differential Revision: D58366924 fbshipit-source-id: 8027783cd5d39c1428a65e6896a54d5246f5e134

…:test-lib Reviewed By: stanleyz510 Differential Revision: D58229540 fbshipit-source-id: 390ba03e579dc597d59f9e88e8b40892ef531777

…hvision Reviewed By: stanleyz510 Differential Revision: D58349067 fbshipit-source-id: 393267a91c70b2324a38292567af51fa730960e8

…emory Summary: We're still hitting this memory not enough issue due to ffmpeg default allocation size is too small. After talking with Bellaktris, I am bringing this back and when he forks the torchvision for MUI, this will be part of his fork. Note that ffmpeg doesn't have a mechanism to dynamically adjust allocated memory size, so this will always be a cat and mouse game. Luckily, we should have no any built-in frame in normal case so this shouldn't cause memory pressure. Differential Revision: D58703899 fbshipit-source-id: f490f345038a61f99996b2a9ae17b4df4738800d

Reviewed By: jianyuh Differential Revision: D60296927 fbshipit-source-id: 10a56935edb49173b3483142300818ec8b722d2c

Reviewed By: vmoens Differential Revision: D60596224 fbshipit-source-id: f74db31da7c828b0d37f200b1f381c5dc9d72144

Reviewed By: vmoens Differential Revision: D60596221 fbshipit-source-id: fa38b16370832e428bf9dbec1201d35c2668e20c

Summary: Co-authored-by: Nicolas Hug <[email protected]> Reviewed By: vmoens Differential Revision: D60596231 fbshipit-source-id: 8493928d6f94a3abeff6a38c9295d343127027b2

Reviewed By: vmoens Differential Revision: D60596235 fbshipit-source-id: 0c76dea583ed1cfbc49996651ee0fee57b9e4ae1 Co-authored-by: Nicolas Hug <[email protected]> Co-authored-by: Nicolas Hug <[email protected]>

Reviewed By: vmoens Differential Revision: D60596239 fbshipit-source-id: 928ea43e521eb4d902a587e759140248006d4b48

Reviewed By: vmoens Differential Revision: D60596238 fbshipit-source-id: 2a88e445ea73d0289c771ea0726fe081eaad21b7

…h#8507) Summary: Co-authored-by: Nicolas Hug <[email protected]> Reviewed By: vmoens Differential Revision: D60596242 fbshipit-source-id: c92e69be2beff212139801c581a84e1e16bd9132

Reviewed By: vmoens Differential Revision: D60596225 fbshipit-source-id: d433ee0ebbac618ec238c523b15db3805eaad5cb

…ch#8513) Reviewed By: vmoens Differential Revision: D60596229 fbshipit-source-id: c5cb0224539fd2e7b63193d14631e01aa82ac6ff

Reviewed By: vmoens Differential Revision: D60596227 fbshipit-source-id: 71b70e3277bf98897f378bc8f2324cd34a3e5146

Reviewed By: vmoens Differential Revision: D60596241 fbshipit-source-id: 4e68b5f7dba5978e8b7bd74e54116abafc95f9cb

Reviewed By: vmoens Differential Revision: D60596237 fbshipit-source-id: 009b6b6c4581623964bac3c53b5226a5dcec009e

Reviewed By: vmoens Differential Revision: D60596246 fbshipit-source-id: 956dfd072507c3205d0d928ef5d7c029b429505f

Reviewed By: vmoens Differential Revision: D60596240 fbshipit-source-id: 4987658c3ee1255a3200232768580a927e371d12

Reviewed By: vmoens Differential Revision: D60596243 fbshipit-source-id: 83414c1f05b9a83f5091b85ee51a9cd4493dcbd5

Reviewed By: vmoens Differential Revision: D60596220 fbshipit-source-id: 7b8010a1d5955028b8e764146e3e4ae785f49269

….py (pytorch#8533) Reviewed By: vmoens Differential Revision: D60596218 fbshipit-source-id: 1f4d53663c301feee862d7df129bcfd2edf39afe

Reviewed By: vmoens Differential Revision: D60596217 fbshipit-source-id: 5a1ac9ecf139859fbeb307f7e56bfbfc12c2f22c

Reviewed By: vmoens Differential Revision: D60596223 fbshipit-source-id: 3ea5a735982e1fbe04cb1ef401198ffa61a9067a

Reviewed By: AntoineSimoulin Differential Revision: D79175031 fbshipit-source-id: 555faf1b672b634b735928053b43ee0401f20ba5

…h#9114) Summary: Co-authored-by: Nicolas Hug <[email protected]> Reviewed By: AntoineSimoulin Differential Revision: D79175021 fbshipit-source-id: a4345beae9801f31b30f6394452f07adf7bcf4fb

Reviewed By: AntoineSimoulin Differential Revision: D79175023 fbshipit-source-id: e298632e8c025757316a0569556b12062f2333be

Summary: DeformConv is only implemented for forward on MPS right now, so skip backward checks Logic for modifying markers in place are stolen from `torch.testing._internal.optests`, namely from https://github.com/pytorch/pytorch/blob/310e8361c565ca1602e719e4c812dc3931ec84d7/torch/testing/_internal/optests/generate_tests.py#L269 Reviewed By: AntoineSimoulin Differential Revision: D79175050 fbshipit-source-id: 8b0ee6bad5adb9cc30ce2deeb8ea659b90d73a52

Summary: Added workflow for arm64 build of torchvision (limited to nightly branch) Reviewed By: Dan-Flores Differential Revision: D79175054 fbshipit-source-id: 4ca054e58004936fb71188fd1c9181a3bb8eab55 Co-authored-by: Nikita Shulga <[email protected]>

Reviewed By: AntoineSimoulin Differential Revision: D79175015 fbshipit-source-id: 078ad9a1250cc478685cb890e4d6ac636da835a4

Summary: Co-authored-by: Nicolas Hug <[email protected]> Reviewed By: AntoineSimoulin Differential Revision: D79175065 fbshipit-source-id: 13cdc5d07300e31438f712905751ea21e63be840

Summary: Co-authored-by: Nicolas Hug <[email protected]> Reviewed By: AntoineSimoulin Differential Revision: D79175053 fbshipit-source-id: 6cc76bc61056baa7828e60402fadbb3c529aceb9

…orch#9132) Summary: Co-authored-by: Antoine Simoulin <[email protected]> Reviewed By: AntoineSimoulin Differential Revision: D79175061 fbshipit-source-id: 8917698aca2a4c1a2702c17196984c141079af70

Reviewed By: AntoineSimoulin Differential Revision: D79175041 fbshipit-source-id: 379f76ca44397fec98348e487ba7f964490719ec

Reviewed By: AntoineSimoulin Differential Revision: D79175049 fbshipit-source-id: 28e287b1dd7d874f060c220014b978a00803ba90 Co-authored-by: Nicolas Hug <[email protected]> Co-authored-by: Nicolas Hug <[email protected]>

Reviewed By: AntoineSimoulin Differential Revision: D79175025 fbshipit-source-id: 41d032979b916f84f2f36c2f4fefc990b29142d2

Reviewed By: AntoineSimoulin Differential Revision: D79175032 fbshipit-source-id: 1ba8ad53cf5cac6327043dd06a2de9d7e696ee4c

Reviewed By: AntoineSimoulin Differential Revision: D79175046 fbshipit-source-id: fc8929d83fcfdebfa6b0427ec21f9da82171f3c7

Summary: Co-authored-by: Nicolas Hug <[email protected]> Reviewed By: AntoineSimoulin Differential Revision: D79175036 fbshipit-source-id: 8352fca52e70187a1b81d987450a6960dd8a651b

Reviewed By: AntoineSimoulin Differential Revision: D79175028 fbshipit-source-id: 8ed8fef904151637a5cbedfd76cd2c0e6e4a0b19

…9113) Reviewed By: AntoineSimoulin Differential Revision: D79175017 fbshipit-source-id: 2b50eee6e05bcae11f3f85822034f23110810451

Reviewed By: AntoineSimoulin Differential Revision: D79175018 fbshipit-source-id: 85ff7a8bd13e847a283bd9f527280fa27fd31252

Reviewed By: AntoineSimoulin Differential Revision: D79175040 fbshipit-source-id: 67a130dcdfe1c420bde815b2b5e52aa019275e04

pytorch-bot · 2025-07-31T09:14:42Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/9159

📄 Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 1 Pending

As of commit 045ed65 with merge base f52c4f1 ():

NEW FAILURE - The following job has failed:

tests / download (gh)
Process completed with exit code 1.

This comment was automatically generated by Dr. CI and updates every 15 minutes.

NicolasHug · 2025-07-31T10:02:44Z

Not sure why the download CI test job is being triggered, but it can be ignored, it's unrelated.

github-actions · 2025-07-31T10:38:47Z

Hey @NicolasHug!

You merged this PR, but no labels were added.
The list of valid labels is available at https://github.com/pytorch/vision/blob/main/.github/process_commit.py

NicolasHug and others added 30 commits June 7, 2024 10:05

[fbsync] Remove broken MPS build (pytorch#8472)

444b318

Reviewed By: vmoens Differential Revision: D58283853 fbshipit-source-id: 27d883bf5ca436b0176427413275b2764247ad32

[fbsync] Skip MPS tests (pytorch#8474)

c4d1728

Reviewed By: vmoens Differential Revision: D58283848 fbshipit-source-id: cfc6b13751cbcb99710e385cfa0e0e634b7cb699

[fbsync] Update usages of torch.library APIs (pytorch#8384)

0b43746

Reviewed By: vmoens Differential Revision: D58283859 fbshipit-source-id: e882d7dbc22ec3e04edea50f95b6a30456f8fd2b Co-authored-by: Nicolas Hug <[email protected]> Co-authored-by: Nicolas Hug <[email protected]>

[fbsync] SBDataset: Only download noval file when image_set='train_no…

ab4cced

…val' (pytorch#8475) Reviewed By: vmoens Differential Revision: D58283849 fbshipit-source-id: e69b9727b7f0271cadf98c2f11edd408e9b9a8e3

[fbsync] Load _C ops before registering meta implementations (pytorch…

936d49b

…#8470) Reviewed By: vmoens Differential Revision: D58283844 fbshipit-source-id: cdaeca2d826bc3ff481286fc4dabd3ae7d6d76a4

[fbsync] Add compatibility with FFMPEG 7.0 (pytorch#8408)

4d15e24

Reviewed By: vmoens Differential Revision: D58283813 fbshipit-source-id: 749e5c793d27ea87e3e12e1b3ecc146a40530067 Co-authored-by: Nicolas Hug <[email protected]> Co-authored-by: Nicolas Hug <[email protected]>

[Codemod][Add @manual = <dep> hints to imports] pytorch/vision/test…

d9c2494

…:test-lib Reviewed By: stanleyz510 Differential Revision: D58229540 fbshipit-source-id: 390ba03e579dc597d59f9e88e8b40892ef531777

[Codemod][Add @manual = <dep> hints to imports] pytorch/vision:torc…

b47bd31

…hvision Reviewed By: stanleyz510 Differential Revision: D58349067 fbshipit-source-id: 393267a91c70b2324a38292567af51fa730960e8

Prevent log spam in torchvision c++ decoder.

7e4c2bd

Reviewed By: jianyuh Differential Revision: D60296927 fbshipit-source-id: 10a56935edb49173b3483142300818ec8b722d2c

[fbsync] Remove unused dynamo import (pytorch#8451)

e6f61dd

Reviewed By: vmoens Differential Revision: D60596224 fbshipit-source-id: f74db31da7c828b0d37f200b1f381c5dc9d72144

[fbsync] Skip flaky earth gif test on OSS CI (pytorch#8480)

99e1064

Reviewed By: vmoens Differential Revision: D60596221 fbshipit-source-id: fa38b16370832e428bf9dbec1201d35c2668e20c

[fbsync] Re-enable vision MPS builds (pytorch#8485)

ee92cda

Summary: Co-authored-by: Nicolas Hug <[email protected]> Reviewed By: vmoens Differential Revision: D60596231 fbshipit-source-id: 8493928d6f94a3abeff6a38c9295d343127027b2

[fbsync] Adding GPU acceleration to encode_jpeg (pytorch#8391)

2aee0ab

Reviewed By: vmoens Differential Revision: D60596235 fbshipit-source-id: 0c76dea583ed1cfbc49996651ee0fee57b9e4ae1 Co-authored-by: Nicolas Hug <[email protected]> Co-authored-by: Nicolas Hug <[email protected]>

[fbsync] Update version on main branch (pytorch#8494)

e1db9db

Reviewed By: vmoens Differential Revision: D60596239 fbshipit-source-id: 928ea43e521eb4d902a587e759140248006d4b48

[fbsync] Update plot_repurposing_annotations.py (pytorch#8506)

7b38473

Reviewed By: vmoens Differential Revision: D60596238 fbshipit-source-id: 2a88e445ea73d0289c771ea0726fe081eaad21b7

[fbsync] Update plot_transforms_getting_started.py: fix typos (pytorc…

1e71200

…h#8507) Summary: Co-authored-by: Nicolas Hug <[email protected]> Reviewed By: vmoens Differential Revision: D60596242 fbshipit-source-id: c92e69be2beff212139801c581a84e1e16bd9132

[fbsync] Typo fix: collab -> Colab (pytorch#8512)

525a0a8

Reviewed By: vmoens Differential Revision: D60596225 fbshipit-source-id: d433ee0ebbac618ec238c523b15db3805eaad5cb

[fbsync] Correcting a link bracket in Classification README.md (pytor…

e749346

…ch#8513) Reviewed By: vmoens Differential Revision: D60596229 fbshipit-source-id: c5cb0224539fd2e7b63193d14631e01aa82ac6ff

[fbsync] Ignore some mypy issues (pytorch#8516)

a35a43a

Reviewed By: vmoens Differential Revision: D60596227 fbshipit-source-id: 71b70e3277bf98897f378bc8f2324cd34a3e5146

[fbsync] Ignore pickle warning for some v2 tests (pytorch#8518)

bf04da0

Reviewed By: vmoens Differential Revision: D60596241 fbshipit-source-id: 4e68b5f7dba5978e8b7bd74e54116abafc95f9cb

[fbsync] Remove warning filter in transforms test (pytorch#8523)

9f8380b

Reviewed By: vmoens Differential Revision: D60596237 fbshipit-source-id: 009b6b6c4581623964bac3c53b5226a5dcec009e

[fbsync] Add Path type annotation for ImageFolder (pytorch#8526)

c07f627

Reviewed By: vmoens Differential Revision: D60596246 fbshipit-source-id: 956dfd072507c3205d0d928ef5d7c029b429505f

[fbsync] Add support for decoding 16bits png (pytorch#8524)

ac99fda

Reviewed By: vmoens Differential Revision: D60596240 fbshipit-source-id: 4987658c3ee1255a3200232768580a927e371d12

[fbsync] Pin numpy dep to numpy<2 for windows (pytorch#8530)

79ddd40

Reviewed By: vmoens Differential Revision: D60596243 fbshipit-source-id: 83414c1f05b9a83f5091b85ee51a9cd4493dcbd5

[fbsync] Revamp setup.py and C++ extension build (pytorch#8528)

b69ff1c

Reviewed By: vmoens Differential Revision: D60596220 fbshipit-source-id: 7b8010a1d5955028b8e764146e3e4ae785f49269

[fbsync] Avoid modifying TORCHVISION_INCLUDE global variable in setup…

f6e0bdc

….py (pytorch#8533) Reviewed By: vmoens Differential Revision: D60596218 fbshipit-source-id: 1f4d53663c301feee862d7df129bcfd2edf39afe

[fbsync] Remove useless stuff from pre_build_script (pytorch#8532)

5f01d77

Reviewed By: vmoens Differential Revision: D60596217 fbshipit-source-id: 5a1ac9ecf139859fbeb307f7e56bfbfc12c2f22c

[fbsync] More debugging info to setup.py (pytorch#8535)

82831f4

Reviewed By: vmoens Differential Revision: D60596223 fbshipit-source-id: 3ea5a735982e1fbe04cb1ef401198ffa61a9067a

NicolasHug and others added 20 commits July 30, 2025 16:29

[fbsync] Use 12.6 instead of deprecated 11.8 (pytorch#9117)

db386ac

Reviewed By: AntoineSimoulin Differential Revision: D79175031 fbshipit-source-id: 555faf1b672b634b735928053b43ee0401f20ba5

[fbsync] Add error message when setting 1D tensor ToImage() (pytorc…

622dd23

…h#9114) Summary: Co-authored-by: Nicolas Hug <[email protected]> Reviewed By: AntoineSimoulin Differential Revision: D79175021 fbshipit-source-id: a4345beae9801f31b30f6394452f07adf7bcf4fb

[fbsync] Add libwebp to contributing doc (pytorch#9119)

bf4ad2e

Reviewed By: AntoineSimoulin Differential Revision: D79175023 fbshipit-source-id: e298632e8c025757316a0569556b12062f2333be

[fbsync] Allow users to choose the bbox clamping mode (pytorch#9128)

e7f123d

Reviewed By: AntoineSimoulin Differential Revision: D79175015 fbshipit-source-id: 078ad9a1250cc478685cb890e4d6ac636da835a4

[fbsync] fix: typo in fakedata.py (pytorch#9131)

889df44

Summary: Co-authored-by: Nicolas Hug <[email protected]> Reviewed By: AntoineSimoulin Differential Revision: D79175065 fbshipit-source-id: 13cdc5d07300e31438f712905751ea21e63be840

[fbsync] Adjust clamping for rotated bboxes (pytorch#9112)

6b9d876

Summary: Co-authored-by: Nicolas Hug <[email protected]> Reviewed By: AntoineSimoulin Differential Revision: D79175053 fbshipit-source-id: 6cc76bc61056baa7828e60402fadbb3c529aceb9

[fbsync] clamping_mode: Rename 'none' to None and None to 'auto' (pyt…

c10a223

…orch#9132) Summary: Co-authored-by: Antoine Simoulin <[email protected]> Reviewed By: AntoineSimoulin Differential Revision: D79175061 fbshipit-source-id: 8917698aca2a4c1a2702c17196984c141079af70

[fbsync] Enforce PIL < 11.3 (pytorch#9134)

5eb6c3b

Reviewed By: AntoineSimoulin Differential Revision: D79175041 fbshipit-source-id: 379f76ca44397fec98348e487ba7f964490719ec

[fbsync] Validate clamping_mode values (pytorch#9136)

6ee7687

Reviewed By: AntoineSimoulin Differential Revision: D79175025 fbshipit-source-id: 41d032979b916f84f2f36c2f4fefc990b29142d2

[fbsync] Fix _ImageDrawTV (pytorch#9137)

c951470

Reviewed By: AntoineSimoulin Differential Revision: D79175032 fbshipit-source-id: 1ba8ad53cf5cac6327043dd06a2de9d7e696ee4c

[fbsync] Update version to 0.24.0a0 (pytorch#9139)

eae63a0

Reviewed By: AntoineSimoulin Differential Revision: D79175046 fbshipit-source-id: fc8929d83fcfdebfa6b0427ec21f9da82171f3c7

[fbsync] Document semantics of bounding box formats (pytorch#9141)

fba9648

Summary: Co-authored-by: Nicolas Hug <[email protected]> Reviewed By: AntoineSimoulin Differential Revision: D79175036 fbshipit-source-id: 8352fca52e70187a1b81d987450a6960dd8a651b

[fbsync] Skeleton for rotated bounding box tutorial (pytorch#9140)

f7d068e

Reviewed By: AntoineSimoulin Differential Revision: D79175028 fbshipit-source-id: 8ed8fef904151637a5cbedfd76cd2c0e6e4a0b19

[fbsync] Update docs to mention rotated boxes and keypoints (pytorch#…

8f027df

…9113) Reviewed By: AntoineSimoulin Differential Revision: D79175017 fbshipit-source-id: 2b50eee6e05bcae11f3f85822034f23110810451

[fbsync] Add more rotated boxes docs (pytorch#9144)

2380d2d

Reviewed By: AntoineSimoulin Differential Revision: D79175018 fbshipit-source-id: 85ff7a8bd13e847a283bd9f527280fa27fd31252

[fbsync] Mitigate PIL Image.fromarray() mode deprecation (pytorch#9150)

1b05f31

Reviewed By: AntoineSimoulin Differential Revision: D79175040 fbshipit-source-id: 67a130dcdfe1c420bde815b2b5e52aa019275e04

Merge remote-tracking branch 'origin/fbsync' into syncccc

1f47f47

meta-cla bot added the cla signed label Jul 31, 2025

NicolasHug added 2 commits July 31, 2025 10:47

restore .clang-format

86c6c15

fix flake8

045ed65

NicolasHug changed the title ~~[WIP] import fbcode changes~~ [FBcode->GH] Import fbcode changes Jul 31, 2025

NicolasHug marked this pull request as ready for review July 31, 2025 09:52

NicolasHug merged commit c01e115 into pytorch:main Jul 31, 2025
62 of 63 checks passed

NicolasHug deleted the syncccc branch July 31, 2025 10:41

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[FBcode->GH] Import fbcode changes #9159

[FBcode->GH] Import fbcode changes #9159

Uh oh!

NicolasHug commented Jul 31, 2025 •

edited

Loading

Uh oh!

pytorch-bot bot commented Jul 31, 2025 •

edited

Loading

Uh oh!

NicolasHug commented Jul 31, 2025

Uh oh!

Uh oh!

github-actions bot commented Jul 31, 2025

Uh oh!

Uh oh!

[FBcode->GH] Import fbcode changes #9159

[FBcode->GH] Import fbcode changes #9159

Uh oh!

Conversation

NicolasHug commented Jul 31, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pytorch-bot bot commented Jul 31, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/9159

❌ 1 New Failure, 1 Pending

Uh oh!

NicolasHug commented Jul 31, 2025

Uh oh!

Uh oh!

github-actions bot commented Jul 31, 2025

Uh oh!

Uh oh!

NicolasHug commented Jul 31, 2025 •

edited

Loading

pytorch-bot bot commented Jul 31, 2025 •

edited

Loading