Skip to content

Add example for installing git in MSYS2 #29180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 23, 2015

Conversation

SingingTree
Copy link
Contributor

Adds the pacman git command to the high level Windows installation instructions. As the MSYS2 installation may not include Windows git on the path by default (based on the path settings of Windows users), I figured this could be a helpful inclusion.

@rust-highfive
Copy link
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@SingingTree SingingTree changed the title Add example for install git in MSYS2 Add example for installing git in MSYS2 Oct 20, 2015
@steveklabnik
Copy link
Member

@bors: r+ rollup

Thanks so much!

@bors
Copy link
Collaborator

bors commented Oct 20, 2015

📌 Commit 3ed49ef has been approved by steveklabnik

@bors
Copy link
Collaborator

bors commented Oct 21, 2015

⌛ Testing commit 3ed49ef with merge 6d8e72d...

@bors
Copy link
Collaborator

bors commented Oct 21, 2015

💔 Test failed - auto-linux-64-x-android-t

@alexcrichton
Copy link
Member

@bors: retry

On Wed, Oct 21, 2015 at 1:24 PM, bors [email protected] wrote:

[image: 💔] Test failed - auto-linux-64-x-android-t
http://buildbot.rust-lang.org/builders/auto-linux-64-x-android-t/builds/6787


Reply to this email directly or view it on GitHub
#29180 (comment).

Manishearth added a commit to Manishearth/rust that referenced this pull request Oct 21, 2015
…=steveklabnik

Adds the pacman git command to the high level Windows installation instructions. As the MSYS2 installation may not include Windows git on the path by default (based on the path settings of Windows users), I figured this could be a helpful inclusion.
steveklabnik added a commit to steveklabnik/rust that referenced this pull request Oct 22, 2015
…=steveklabnik

Adds the pacman git command to the high level Windows installation instructions. As the MSYS2 installation may not include Windows git on the path by default (based on the path settings of Windows users), I figured this could be a helpful inclusion.
steveklabnik added a commit to steveklabnik/rust that referenced this pull request Oct 22, 2015
…=steveklabnik

Adds the pacman git command to the high level Windows installation instructions. As the MSYS2 installation may not include Windows git on the path by default (based on the path settings of Windows users), I figured this could be a helpful inclusion.
bors added a commit that referenced this pull request Oct 22, 2015
@alexcrichton alexcrichton merged commit 3ed49ef into rust-lang:master Oct 23, 2015
@SingingTree SingingTree deleted the readme_windows_build branch October 24, 2015 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants